You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jerrinot (via GitHub)" <gi...@apache.org> on 2023/02/23 18:39:39 UTC
[GitHub] [maven-resolver] jerrinot opened a new pull request, #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
jerrinot opened a new pull request, #253:
URL: https://github.com/apache/maven-resolver/pull/253
My attempt to fix https://issues.apache.org/jira/browse/MRESOLVER-326
Feedback appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] jerrinot commented on pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "jerrinot (via GitHub)" <gi...@apache.org>.
jerrinot commented on PR #253:
URL: https://github.com/apache/maven-resolver/pull/253#issuecomment-1443614104
Thanks to both @cstamas and @slawekjaranowski for your super quick help! I wish all my PRs were merged as quickly as this one! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] slawekjaranowski commented on a diff in pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #253:
URL: https://github.com/apache/maven-resolver/pull/253#discussion_r1116149411
##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -129,6 +129,18 @@ public final class ConfigurationProperties {
*/
public static final String DEFAULT_HTTP_CREDENTIAL_ENCODING = "ISO-8859-1";
+ /**
+ * The maximum number of times a request to a remote server should be retried in case of an error.
+ *
+ * @see #DEFAULT_HTTP_RETRY_HANDLER_COUNT
+ */
+ public static final String HTTP_RETRY_HANDLER_COUNT = PREFIX_CONNECTOR + "http.retryHandler.count";
Review Comment:
New property should also be added to `src/site/markdown/configuration.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #253:
URL: https://github.com/apache/maven-resolver/pull/253#discussion_r1116150646
##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -129,6 +129,18 @@ public final class ConfigurationProperties {
*/
public static final String DEFAULT_HTTP_CREDENTIAL_ENCODING = "ISO-8859-1";
+ /**
+ * The maximum number of times a request to a remote server should be retried in case of an error.
+ *
+ * @see #DEFAULT_HTTP_RETRY_HANDLER_COUNT
+ */
+ public static final String HTTP_RETRY_HANDLER_COUNT = PREFIX_CONNECTOR + "http.retryHandler.count";
Review Comment:
that renders here (just FTR) https://maven.apache.org/resolver/configuration.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #253:
URL: https://github.com/apache/maven-resolver/pull/253#discussion_r1116117571
##########
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java:
##########
@@ -109,6 +110,8 @@ public enum ChecksumHeader {
private String proxyPassword;
+ private int connectionsToClose = 0;
Review Comment:
AtomicInteger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #253:
URL: https://github.com/apache/maven-resolver/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #253:
URL: https://github.com/apache/maven-resolver/pull/253#issuecomment-1442271270
Formatting issues: `mvn spotless:apply`, commit and push pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] jerrinot commented on a diff in pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "jerrinot (via GitHub)" <gi...@apache.org>.
jerrinot commented on code in PR #253:
URL: https://github.com/apache/maven-resolver/pull/253#discussion_r1116124588
##########
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java:
##########
@@ -109,6 +110,8 @@ public enum ChecksumHeader {
private String proxyPassword;
+ private int connectionsToClose = 0;
Review Comment:
good one, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] jerrinot commented on a diff in pull request #253: [MRESOLVER-326] Introduce retries on HTTP connection errors
Posted by "jerrinot (via GitHub)" <gi...@apache.org>.
jerrinot commented on code in PR #253:
URL: https://github.com/apache/maven-resolver/pull/253#discussion_r1116178009
##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -129,6 +129,18 @@ public final class ConfigurationProperties {
*/
public static final String DEFAULT_HTTP_CREDENTIAL_ENCODING = "ISO-8859-1";
+ /**
+ * The maximum number of times a request to a remote server should be retried in case of an error.
+ *
+ * @see #DEFAULT_HTTP_RETRY_HANDLER_COUNT
+ */
+ public static final String HTTP_RETRY_HANDLER_COUNT = PREFIX_CONNECTOR + "http.retryHandler.count";
Review Comment:
thanks to both of you!
I added a new row & copied a property description from the code. but I am not sure if the description fits the rest of the properties. it feels a bit off in style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org