You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/03/21 14:44:43 UTC

[GitHub] [hbase] wchevreuil commented on a change in pull request #4052: HBASE-25955 Setting NAMESPACES when adding a replication peer still requires scope definition at CF level

wchevreuil commented on a change in pull request #4052:
URL: https://github.com/apache/hbase/pull/4052#discussion_r831188994



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ChainWALEntryFilter.java
##########
@@ -56,6 +59,13 @@ public ChainWALEntryFilter(List<WALEntryFilter> filters) {
     initCellFilters();
   }
 
+  public ChainWALEntryFilter(List<WALEntryFilter> filters, String operatorName) {
+    this(filters);
+    if (!StringUtils.isEmpty(operatorName)) {
+      this.operator = Operator.valueOf(operatorName);

Review comment:
       You mean, beyond the checks to avoid an NPE, explicitly extra check for the valid strings and throw IllegalArgumentException, rather than letting the enum error?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org