You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by BryanCutler <gi...@git.apache.org> on 2018/10/08 21:55:02 UTC

[GitHub] spark pull request #22305: [SPARK-24561][SQL][Python] User-defined window ag...

Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22305#discussion_r223507242
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
    @@ -63,7 +65,7 @@ private[spark] object PythonEvalType {
      */
     private[spark] abstract class BasePythonRunner[IN, OUT](
         funcs: Seq[ChainedPythonFunctions],
    -    evalType: Int,
    +    evalTypes: Seq[Int],
    --- End diff --
    
    So you have a Seq now to support a mix of unbounded/bounded eval types?  Is there any other way to do this, like maybe decipher from the bounds given?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org