You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/03/13 11:34:40 UTC
Review Request 32034: Fixed build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
Commit 8385bba added a comparison operator which added a ; instead of && ignoring most of the expression creating an expression result unused when compiling with clang.
Diffs
-----
src/common/type_utils.cpp c9469912c420f9b1c01b0a3827867245f4d24dfd
Diff: https://reviews.apache.org/r/32034/diff/
Testing
-------
make && make check
Thanks,
Alexander Rojas
Re: Review Request 32034: Fixed unused comparisons on the == operator
for TaskStatus.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/#review76387
-----------------------------------------------------------
src/common/type_utils.cpp
<https://reviews.apache.org/r/32034/#comment123938>
oops. thanks for fixing!
- Vinod Kone
On March 13, 2015, 10:56 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32034/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 10:56 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-2494
> https://issues.apache.org/jira/browse/MESOS-2494
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 8385bba added a comparison operator which added a ; instead of && ignoring most of the expression creating an expression result unused when compiling with clang.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp c9469912c420f9b1c01b0a3827867245f4d24dfd
>
> Diff: https://reviews.apache.org/r/32034/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 32034: Fixed unused comparisons on the == operator
for TaskStatus.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/#review76350
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On March 13, 2015, 10:56 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32034/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 10:56 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-2494
> https://issues.apache.org/jira/browse/MESOS-2494
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 8385bba added a comparison operator which added a ; instead of && ignoring most of the expression creating an expression result unused when compiling with clang.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp c9469912c420f9b1c01b0a3827867245f4d24dfd
>
> Diff: https://reviews.apache.org/r/32034/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 32034: Fixed unused comparisons on the == operator
for TaskStatus.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/#review76352
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32034]
All tests passed.
- Mesos ReviewBot
On March 13, 2015, 10:56 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32034/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 10:56 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-2494
> https://issues.apache.org/jira/browse/MESOS-2494
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 8385bba added a comparison operator which added a ; instead of && ignoring most of the expression creating an expression result unused when compiling with clang.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp c9469912c420f9b1c01b0a3827867245f4d24dfd
>
> Diff: https://reviews.apache.org/r/32034/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 32034: Fixed unused comparisons on the == operator
for TaskStatus.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/
-----------------------------------------------------------
(Updated March 13, 2015, 11:56 a.m.)
Review request for mesos and Till Toenshoff.
Bugs: MESOS-2494
https://issues.apache.org/jira/browse/MESOS-2494
Repository: mesos
Description
-------
Commit 8385bba added a comparison operator which added a ; instead of && ignoring most of the expression creating an expression result unused when compiling with clang.
Diffs
-----
src/common/type_utils.cpp c9469912c420f9b1c01b0a3827867245f4d24dfd
Diff: https://reviews.apache.org/r/32034/diff/
Testing
-------
make && make check
Thanks,
Alexander Rojas
Re: Review Request 32034: Fixed unused comparisons on the == operator
for TaskStatus.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/
-----------------------------------------------------------
(Updated March 13, 2015, 11:56 a.m.)
Review request for mesos and Till Toenshoff.
Summary (updated)
-----------------
Fixed unused comparisons on the == operator for TaskStatus.
Repository: mesos
Description
-------
Commit 8385bba added a comparison operator which added a ; instead of && ignoring most of the expression creating an expression result unused when compiling with clang.
Diffs
-----
src/common/type_utils.cpp c9469912c420f9b1c01b0a3827867245f4d24dfd
Diff: https://reviews.apache.org/r/32034/diff/
Testing
-------
make && make check
Thanks,
Alexander Rojas