You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Jean-Sebastien Delfino (JIRA)" <de...@tuscany.apache.org> on 2008/07/22 10:30:31 UTC
[jira] Created: (TUSCANY-2491) EJB binding improvements
EJB binding improvements
------------------------
Key: TUSCANY-2491
URL: https://issues.apache.org/jira/browse/TUSCANY-2491
Project: Tuscany
Issue Type: Wish
Components: Java SCA EJB Binding Extension
Reporter: Jean-Sebastien Delfino
Fix For: Java-SCA-Next
I'd like to get the following improvements in the EJB binding:
- unused code should be removed
- the visibility of most of the classes and methods that do not belong to the public API should be fixed (should be made private or package-private).
- the lookup and initialization of the EJB stub is currently performed at each invoke, should move to the start method and some cleanup in stop
- the binding should leverage host-corba-jse and host-corba-jee to access the correct ORB instance, depending on the configured host
- test cases should be added to verify that the transaction and security context correctly flow through EJB invocations when used with the ORB obtained in a JEE environment, and run on the application servers that the Tuscany releases claim to support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2491) EJB binding improvements
Posted by "Jean-Sebastien Delfino (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615556#action_12615556 ]
Jean-Sebastien Delfino commented on TUSCANY-2491:
-------------------------------------------------
One more thing:
The current EJB reference test case is fragile and not maintainable, as it requires the maintainer to edit binary code (a hardcoded IIOP response) in a test MockServer.
Here's what I'm talking about:
public class MockServer implements Runnable {
private int listen;
byte[][] seq =
{
{79, 69, 74, 80, 47, 51, 46, 48, 1, -84, -19, 0, 5, 119, 58, 1, 27, 0, 54, 47, 104, 101, 108, 108, 111, 45,
97, 100, 100, 115, 101, 114, 118, 105, 99, 101, 47, 65, 100, 100, 83, 101, 114, 118, 105, 99, 101, 66, 101,
97, 110, 47, 99, 97, 108, 99, 117, 108, 97, 116, 111, 114, 46, 65, 100, 100, 83, 101, 114, 118, 105, 99, 101,
112},
{79, 69, 74, 80, 47, 50, 46, 48, -84, -19, 0, 5, 119, 3, 1, 13, 1, 118, 114, 0, 25, 99, 97, 108, 99, 117, 108,
97, 116, 111, 114, 46, 65, 100, 100, 83, 101, 114, 118, 105, 99, 101, 72, 111, 109, 101, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 120, 112, 118, 114, 0, 21, 99, 97, 108, 99, 117, 108, 97, 116, 111, 114, 46, 65, 100, 100, 83,
101, 114, 118, 105, 99, 101, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 120, 112, 112, 112, 119, 38, 7, 0, 31, 104,
101, 108, 108, 111, 45, 97, 100, 100, 115, 101, 114, 118, 105, 99, 101, 47, 65, 100, 100, 83, 101, 114, 118,
105, 99, 101, 66, 101, 97, 110, -1, -1, 0, 0},
{79, 69, 74, 80, 47, 51, 46, 48, 0, -84, -19, 0, 5, 119, 1, 10, 116, 0, 31, 104, 101, 108, 108, 111, 45, 97,
100, 100, 115, 101, 114, 118, 105, 99, 101, 47, 65, 100, 100, 83, 101, 114, 118, 105, 99, 101, 66, 101, 97,
110, 119, 2, -1, -1, 112, 119, 1, 1, 112, 118, 114, 0, 25, 99, 97, 108, 99, 117, 108, 97, 116, 111, 114, 46,
65, 100, 100, 83, 101, 114, 118, 105, 99, 101, 72, 111, 109, 101, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 120, 112,
119, 9, 0, 6, 99, 114, 101, 97, 116, 101, 0},
{79, 69, 74, 80, 47, 50, 46, 48, -84, -19, 0, 5, 119, 2, 1, 4, 112},
{79, 69, 74, 80, 47, 51, 46, 48, 0, -84, -19, 0, 5, 119, 1, 23, 116, 0, 31, 104, 101, 108, 108, 111, 45, 97,
100, 100, 115, 101, 114, 118, 105, 99, 101, 47, 65, 100, 100, 83, 101, 114, 118, 105, 99, 101, 66, 101, 97,
110, 119, 2, -1, -1, 112, 119, 1, 1, 112, 118, 114, 0, 21, 99, 97, 108, 99, 117, 108, 97, 116, 111, 114, 46,
65, 100, 100, 83, 101, 114, 118, 105, 99, 101, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 120, 112, 119, 24, 0, 3, 97,
100, 100, 2, 4, 64, 89, 0, 0, 0, 0, 0, 0, 4, 64, -113, 64, 0, 0, 0, 0, 0},
{79, 69, 74, 80, 47, 50, 46, 48, -84, -19, 0, 5, 119, 2, 1, 4, 115, 114, 0, 16, 106, 97, 118, 97, 46, 108, 97,
110, 103, 46, 68, 111, 117, 98, 108, 101, -128, -77, -62, 74, 41, 107, -5, 4, 2, 0, 1, 68, 0, 5, 118, 97,
108, 117, 101, 120, 114, 0, 16, 106, 97, 118, 97, 46, 108, 97, 110, 103, 46, 78, 117, 109, 98, 101, 114,
-122, -84, -107, 29, 11, -108, -32, -117, 2, 0, 0, 120, 112, 64, -111, 48, 0, 0, 0, 0, 0}
};
not quite easy to maintain... and fragile. For example updating the level of geronimo dependencies to 2.1.1 breaks the test case.
> EJB binding improvements
> ------------------------
>
> Key: TUSCANY-2491
> URL: https://issues.apache.org/jira/browse/TUSCANY-2491
> Project: Tuscany
> Issue Type: Wish
> Components: Java SCA EJB Binding Extension
> Reporter: Jean-Sebastien Delfino
> Fix For: Java-SCA-Next
>
>
> I'd like to get the following improvements in the EJB binding:
> - unused code should be removed
> - the visibility of most of the classes and methods that do not belong to the public API should be fixed (should be made private or package-private).
> - the lookup and initialization of the EJB stub is currently performed at each invoke, should move to the start method and some cleanup in stop
> - the binding should leverage host-corba-jse and host-corba-jee to access the correct ORB instance, depending on the configured host
> - test cases should be added to verify that the transaction and security context correctly flow through EJB invocations when used with the ORB obtained in a JEE environment, and run on the application servers that the Tuscany releases claim to support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.