You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/24 23:21:59 UTC
[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15286
Change subject: [webserver] HtmlOutputSchemaTable() is gone
......................................................................
[webserver] HtmlOutputSchemaTable() is gone
A clean-up on webui_util.{h,cc}:
* removed HtmlOutputSchemaTable() from the header file since it's
gone long time ago
* modernize the include guard in webui_util.h
Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
---
M src/kudu/server/webui_util.cc
M src/kudu/server/webui_util.h
2 files changed, 3 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/15286/1
--
To view, visit http://gerrit.cloudera.org:8080/15286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Gerrit-Change-Number: 15286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [webserver] HtmlOutputSchemaTable() is gone
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Gerrit-Change-Number: 15286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15286 )
Change subject: [webserver] HtmlOutputSchemaTable() is gone
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Gerrit-Change-Number: 15286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 00:33:38 +0000
Gerrit-HasComments: No
[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15286 )
Change subject: [webserver] HtmlOutputSchemaTable() is gone
......................................................................
[webserver] HtmlOutputSchemaTable() is gone
A clean-up on webui_util.{h,cc}:
* removed HtmlOutputSchemaTable() from the header file since it's
gone long time ago
* modernize the include guard in webui_util.h
Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Reviewed-on: http://gerrit.cloudera.org:8080/15286
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/server/webui_util.cc
M src/kudu/server/webui_util.h
2 files changed, 3 insertions(+), 14 deletions(-)
Approvals:
Bankim Bhavsar: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Gerrit-Change-Number: 15286
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15286 )
Change subject: [webserver] HtmlOutputSchemaTable() is gone
......................................................................
Patch Set 1: Verified+1
unrelated test failure: BadMultiMasterAuthzTokenTest.TestMasterElectionStorms
--
To view, visit http://gerrit.cloudera.org:8080/15286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Gerrit-Change-Number: 15286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 00:51:41 +0000
Gerrit-HasComments: No
[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15286 )
Change subject: [webserver] HtmlOutputSchemaTable() is gone
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15286/1/src/kudu/server/webui_util.h
File src/kudu/server/webui_util.h:
http://gerrit.cloudera.org:8080/#/c/15286/1/src/kudu/server/webui_util.h@a37
PS1, Line 37:
Q: I'd expect compiler/linker to complain with definition missing but I guess there is no caller so it doesn't?
--
To view, visit http://gerrit.cloudera.org:8080/15286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Gerrit-Change-Number: 15286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 00:09:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [webserver] HtmlOutputSchemaTable() is gone
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15286 )
Change subject: [webserver] HtmlOutputSchemaTable() is gone
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15286/1/src/kudu/server/webui_util.h
File src/kudu/server/webui_util.h:
http://gerrit.cloudera.org:8080/#/c/15286/1/src/kudu/server/webui_util.h@a37
PS1, Line 37:
> Q: I'd expect compiler/linker to complain with definition missing but I gue
Yup, it seems so. Probably, there is a way to configure clang-tidy to warn about this type of things -- I'll take a closer look.
--
To view, visit http://gerrit.cloudera.org:8080/15286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54
Gerrit-Change-Number: 15286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 00:51:28 +0000
Gerrit-HasComments: Yes