You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/01/31 18:32:26 UTC
Re: Review Request 54061: Augmented FrameworkInfo to support multiple
roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54061/#review163686
-----------------------------------------------------------
include/mesos/mesos.proto (line 256)
<https://reviews.apache.org/r/54061/#comment235159>
Should this still be deprecated if master is advising not to use the roles field?
- David McLaughlin
On Nov. 30, 2016, 9:58 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54061/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 9:58 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang.
>
>
> Bugs: MESOS-6628
> https://issues.apache.org/jira/browse/MESOS-6628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the initial patch to introduce multi-role frameworks.
> A new section `repeated string roles` is added to FrameworkInfo.
> Old `optional string role` is kept for backwards compatability.
> To distinguish single-role and multi-role frameworks, a new framework
> capability `MULTI_ROLE` is introduced. See MESOS-6628 for more info.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
> include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
>
> Diff: https://reviews.apache.org/r/54061/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54061: Augmented FrameworkInfo to support multiple
roles.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Jan. 31, 2017, 6:32 p.m., David McLaughlin wrote:
> > include/mesos/mesos.proto, line 256
> > <https://reviews.apache.org/r/54061/diff/3/?file=1572827#file1572827line256>
> >
> > Should this still be deprecated if master is advising not to use the roles field?
We should have added the deprecated flag once MULTI_ROLE was completed. Jay can you remove it for now?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54061/#review163686
-----------------------------------------------------------
On Nov. 30, 2016, 9:58 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54061/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 9:58 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang.
>
>
> Bugs: MESOS-6628
> https://issues.apache.org/jira/browse/MESOS-6628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the initial patch to introduce multi-role frameworks.
> A new section `repeated string roles` is added to FrameworkInfo.
> Old `optional string role` is kept for backwards compatability.
> To distinguish single-role and multi-role frameworks, a new framework
> capability `MULTI_ROLE` is introduced. See MESOS-6628 for more info.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05
> include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13
>
> Diff: https://reviews.apache.org/r/54061/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>