You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/19 09:19:30 UTC
[GitHub] [inlong] dockerzhang opened a new pull request, #5125: [INLONG-5124][Docker] Add initial sort connectors to the manager docker image
dockerzhang opened a new pull request, #5125:
URL: https://github.com/apache/inlong/pull/5125
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #5124
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] lucaspeng12138 commented on a diff in pull request #5125: [INLONG-5124][Docker] Add initial sort connectors to the manager docker image
Posted by GitBox <gi...@apache.org>.
lucaspeng12138 commented on code in PR #5125:
URL: https://github.com/apache/inlong/pull/5125#discussion_r924272894
##########
inlong-manager/manager-docker/Dockerfile:
##########
@@ -37,10 +37,14 @@ ENV AUDIT_PROXY_URL=127.0.0.1:10081
# JVM env
ENV MANAGER_JVM_HEAP_OPTS="-XX:+UseContainerSupport -XX:InitialRAMPercentage=40.0 -XX:MaxRAMPercentage=80.0 -XX:-UseAdaptiveSizePolicy"
WORKDIR /opt/inlong-manager
-
-# add tarball from manager output
-ARG MANAGER_TARBALL
Review Comment:
docker/build-docker-images.sh has used MANAGER_TARBALL at line 122, need to change into version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5125: [INLONG-5124][Docker] Add initial sort connectors to the manager docker image
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5125:
URL: https://github.com/apache/inlong/pull/5125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org