You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/05 22:55:45 UTC
[GitHub] [pinot] Jackie-Jiang opened a new issue #7714: Ignore query option from the commented out queries
Jackie-Jiang opened a new issue #7714:
URL: https://github.com/apache/pinot/issues/7714
Currently query option is processed as a regex (see `CalciteSqlParser.java` for details). This behavior will cause options being picked up from commented out queries. E.g.
```
SELECT * FROM table
-- SELECT * FROM table OPTION(...)
```
To fix this issue, we can consider switching to the standard SQL option syntax supported by Calcite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kriti-sc commented on issue #7714: Ignore query option from the commented out queries
Posted by GitBox <gi...@apache.org>.
kriti-sc commented on issue #7714:
URL: https://github.com/apache/pinot/issues/7714#issuecomment-986094174
>we can consider switching to the standard SQL option syntax supported by Calcite
I tried looking this up but seems to me that specifying query options is not a part of the ANSI SQL standard, they differ on a vendor to vendor basis.
There is also this comment in the code: https://github.com/apache/pinot/blob/9a61b491da01afa23d5788dd42a6ee579bcb118e/pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java#L106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #7714: Ignore query option from the commented out queries
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #7714:
URL: https://github.com/apache/pinot/issues/7714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kriti-sc commented on issue #7714: Ignore query option from the commented out queries
Posted by GitBox <gi...@apache.org>.
kriti-sc commented on issue #7714:
URL: https://github.com/apache/pinot/issues/7714#issuecomment-986087416
@Jackie-Jiang added a possible fix. Introduced a regex for detecting commented-out queries. If a commented-out query is detected, the regex matching for query options is bypassed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org