You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2016/03/22 08:32:57 UTC
Review Request 45151: Updated FrameworkInfo::Capability::Type enum for
upgradability.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45151/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Vinod Kone.
Bugs: MESOS-4977
https://issues.apache.org/jira/browse/MESOS-4977
Repository: mesos
Description
-------
Per [MESOS-4977](https://issues.apache.org/jira/browse/MESOS-4977), having a required enum field is problematic for supporting adding new enum values.
This updates FrameworkInfo::Capability to support the addition of new capabilities while allowing old masters to deserialize the new messages.
Diffs
-----
include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403
include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682
Diff: https://reviews.apache.org/r/45151/diff/
Testing
-------
make check
manually validated the upgrade / backwards compatibility of enum fields
Thanks,
Ben Mahler
Re: Review Request 45151: Updated FrameworkInfo::Capability::Type
enum for upgradability.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45151/#review125151
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45151]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 23, 2016, 5:58 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45151/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 5:58 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Bugs: MESOS-4997
> https://issues.apache.org/jira/browse/MESOS-4997
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per [MESOS-4977](https://issues.apache.org/jira/browse/MESOS-4977), having a required enum field is problematic for supporting adding new enum values.
>
> This updates FrameworkInfo::Capability to support the addition of new capabilities while allowing old masters to deserialize the new messages.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403
> include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682
>
> Diff: https://reviews.apache.org/r/45151/diff/
>
>
> Testing
> -------
>
> make check
>
> manually validated the upgrade / backwards compatibility of enum fields
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 45151: Updated FrameworkInfo::Capability::Type
enum for upgradability.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45151/
-----------------------------------------------------------
(Updated March 23, 2016, 5:58 p.m.)
Review request for mesos, Joris Van Remoortere and Vinod Kone.
Changes
-------
fixed the bug id -- @vinodkone
Bugs: MESOS-4997
https://issues.apache.org/jira/browse/MESOS-4997
Repository: mesos
Description
-------
Per [MESOS-4977](https://issues.apache.org/jira/browse/MESOS-4977), having a required enum field is problematic for supporting adding new enum values.
This updates FrameworkInfo::Capability to support the addition of new capabilities while allowing old masters to deserialize the new messages.
Diffs
-----
include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403
include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682
Diff: https://reviews.apache.org/r/45151/diff/
Testing
-------
make check
manually validated the upgrade / backwards compatibility of enum fields
Thanks,
Ben Mahler
Re: Review Request 45151: Updated FrameworkInfo::Capability::Type
enum for upgradability.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45151/#review124757
-----------------------------------------------------------
The bug should be MESOS-4997 here
- Guangya Liu
On 三月 22, 2016, 7:32 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45151/
> -----------------------------------------------------------
>
> (Updated 三月 22, 2016, 7:32 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Bugs: MESOS-4977
> https://issues.apache.org/jira/browse/MESOS-4977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per [MESOS-4977](https://issues.apache.org/jira/browse/MESOS-4977), having a required enum field is problematic for supporting adding new enum values.
>
> This updates FrameworkInfo::Capability to support the addition of new capabilities while allowing old masters to deserialize the new messages.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403
> include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682
>
> Diff: https://reviews.apache.org/r/45151/diff/
>
>
> Testing
> -------
>
> make check
>
> manually validated the upgrade / backwards compatibility of enum fields
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 45151: Updated FrameworkInfo::Capability::Type
enum for upgradability.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45151/#review125076
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 22, 2016, 7:32 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45151/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 7:32 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Bugs: MESOS-4977
> https://issues.apache.org/jira/browse/MESOS-4977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per [MESOS-4977](https://issues.apache.org/jira/browse/MESOS-4977), having a required enum field is problematic for supporting adding new enum values.
>
> This updates FrameworkInfo::Capability to support the addition of new capabilities while allowing old masters to deserialize the new messages.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403
> include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682
>
> Diff: https://reviews.apache.org/r/45151/diff/
>
>
> Testing
> -------
>
> make check
>
> manually validated the upgrade / backwards compatibility of enum fields
>
>
> Thanks,
>
> Ben Mahler
>
>