[jira] [Commented] (YARN-3281) Add RMStateStore to StateMachine visualization list

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341462#comment-14341462 ] 

Hadoop QA commented on YARN-3281:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12701568/YARN-3281.01.patch
  against trunk revision 2e44b75.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6796//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6796//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6796//console

This message is automatically generated.

> Add RMStateStore to StateMachine visualization list
> ---------------------------------------------------
>
>                 Key: YARN-3281
>                 URL: https://issues.apache.org/jira/browse/YARN-3281
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.6.0
>            Reporter: Chengbing Liu
>            Assignee: Chengbing Liu
>            Priority: Minor
>         Attachments: YARN-3281.01.patch
>
>
> The command "mvn compile -Pvisualize" should generate graph representations for all state machines in the project. We are still missing {{org.apache.hadoop.yarn.server.resourcemanager.recovery.RMStateStore}} for resourcemanager project.
> Another class {{org.apache.hadoop.yarn.client.api.async.impl.NMClientAsyncImpl.StatefulContainer}} also has a state machine. However this one is a protected inner class, hence cannot be seen by class {{VisualizeStateMachine}}. Any suggestions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)