You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/23 18:36:25 UTC

[GitHub] [hudi] qjqqyy edited a comment on issue #5101: [SUPPORT] Deltastreamer: setting hoodie.datasource.hive_sync.partition_fields to blank results in empty partition being used in hive sync

qjqqyy edited a comment on issue #5101:
URL: https://github.com/apache/hudi/issues/5101#issuecomment-1076384540


   Some key generators such as ComplexKeyGenerator requires you to pass in `hoodie.datasource.write.partitionpath.field=` to indicate that the table is non-partitioned.
   
   Seems like HoodieSyncConfig will infer this setting differently <https://github.com/apache/hudi/blob/5f570ea151d0212ab1bb2d1f5693035626b76d31/hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncConfig.java#L113>
   and set partitionFields as a 1-length list containing "", which has different semantics to partitionFields = null.
   
   Related question: is there a valid usecase for `TypedProperties#getStringList` of "" to return [""]?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org