[jira] Commented: (VELOCITY-565) EvaluateContext does not take account of inner.localContext

["Etienne Massip (JIRA)" <de...@velocity.apache.org>]

    [ https://issues.apache.org/jira/browse/VELOCITY-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531704 ] 

Etienne Massip commented on VELOCITY-565:
-----------------------------------------

Please, could you tell us when you plan to commit this patch, I mean if it is okay for you ?

> EvaluateContext does not take account of inner.localContext
> -----------------------------------------------------------
>
>                 Key: VELOCITY-565
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-565
>             Project: Velocity
>          Issue Type: Bug
>            Reporter: Will Glass-Husain
>            Assignee: Will Glass-Husain
>            Priority: Minor
>             Fix For: 1.6
>
>         Attachments: EvaluateContext.java, evalvmcontext.patch
>
>
> the following vtl does not render what is, IMHO, expected :
> #macro(testEval $expr)
>     #foreach($value in ["val1", "val2"])
>         value is : #evaluate( $expr )
>     #end
> #end
> #testEval( "${value}" )
> renders :
> value is : ${value}
> value is : ${value}
> The reason is that EvaluateContext ctor assigns 'inner.getBaseContext()'
> to instance variable 'innerContext', and getBaseContext() does not
> return VMContext localContext refs (of the #foreach directive).
> Changing the EvaluateContext ctor so that 'innerContext' is set to
> 'inner' allow velocity to render the right result :
> value is : val1
> value is : val2
> But I'm not sure this would be a correct fix, should the VMContext
> return all current refs ? Could you tell me what the normal behavior is
> and what is the way all that stuff sould work ?
> Etienne Massip

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org