You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/21 19:51:51 UTC

[GitHub] [beam] laraschmidt opened a new pull request #17142: Fixing a small bug in TypedSchemaTransformTest that caused it to flake.

laraschmidt opened a new pull request #17142:
URL: https://github.com/apache/beam/pull/17142


   The row builder seemed to have trouble converting the int to Integer automatically, so wrap it in an Integer.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] laraschmidt commented on pull request #17142: Fixing a small bug in TypedSchemaTransformTest that caused it to flake.

Posted by GitBox <gi...@apache.org>.
laraschmidt commented on pull request #17142:
URL: https://github.com/apache/beam/pull/17142#issuecomment-1075731139


   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] laraschmidt commented on pull request #17142: Fixing a small bug in TypedSchemaTransformTest that caused it to flake.

Posted by GitBox <gi...@apache.org>.
laraschmidt commented on pull request #17142:
URL: https://github.com/apache/beam/pull/17142#issuecomment-1074487051


   It was the java unit tests which apparently runs via git hub actions, not jenkins. Seems like it doesn't fail on linux, only mac and PC. That would explain why the precommit wasn't red though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] laraschmidt commented on pull request #17142: Fixing a small bug in TypedSchemaTransformTest that caused it to flake.

Posted by GitBox <gi...@apache.org>.
laraschmidt commented on pull request #17142:
URL: https://github.com/apache/beam/pull/17142#issuecomment-1075362296


   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] laraschmidt commented on pull request #17142: Fixing a small bug in TypedSchemaTransformTest that caused it to flake.

Posted by GitBox <gi...@apache.org>.
laraschmidt commented on pull request #17142:
URL: https://github.com/apache/beam/pull/17142#issuecomment-1075615197


   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] TheNeuralBit merged pull request #17142: Fixing a small bug in TypedSchemaTransformTest that caused it to flake.

Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #17142:
URL: https://github.com/apache/beam/pull/17142


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org