You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/11 17:56:12 UTC
[GitHub] [cloudstack] mib1185 opened a new pull request #5197: UI: register vue component Descriptions
mib1185 opened a new pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197
### Description
This PR fixes a small UI bug, where `a-descriptions` is used by `NicsTable` but component is not registered properly, so UI looks bad and erros were thrown in debug console:
```
[Vue warn]: Unknown custom element: <a-descriptions> - did you register the component correctly? For recursive components, make sure to provide the "name" option.
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Local with CS simulator
Screenshot prior this change:
Screenshot after this change:
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877841166
you're welcome @mib1185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5197: UI: fix NIC table on instance view
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877981997
@mib1185 good to have in 4.15 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877842230
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5197: UI: fix NIC table on instance view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-878034364
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5197 (SL-JID-346)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877839009
@mib1185 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877839484
@mib1185 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877838949
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #5197: UI: fix NIC table on instance view
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-878006154
@shwstppr yeah sure, it is a quiet small fix 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #5197: UI: fix NIC table on instance view
Posted by GitBox <gi...@apache.org>.
mib1185 edited a comment on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-878006154
@shwstppr yeah sure, it is a quiet small fix 🙂
ah ... now I see .... need to rebase to 4.15 and change target branch for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5197: UI: fix NIC table on instance view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-878031785
@mib1185 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877840299
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5197 (SL-JID-340)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877839349
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #5197: UI: register vue component Descriptions
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-877841053
@blueorangutan thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #5197: UI: fix NIC table on instance view
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197#issuecomment-878031574
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5197: UI: fix NIC table on instance view
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5197:
URL: https://github.com/apache/cloudstack/pull/5197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org