You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ha...@apache.org on 2009/07/21 10:34:27 UTC
svn commit: r796178 - /ofbiz/trunk/applications/accounting/widget/Menus.xml
Author: hansbak
Date: Tue Jul 21 08:34:27 2009
New Revision: 796178
URL: http://svn.apache.org/viewvc?rev=796178&view=rev
Log:
cannot cancel a paid invoice, add find button
Modified:
ofbiz/trunk/applications/accounting/widget/Menus.xml
Modified: ofbiz/trunk/applications/accounting/widget/Menus.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/Menus.xml?rev=796178&r1=796177&r2=796178&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/widget/Menus.xml (original)
+++ ofbiz/trunk/applications/accounting/widget/Menus.xml Tue Jul 21 08:34:27 2009
@@ -47,6 +47,9 @@
</menu>
<menu name="InvoiceTabBar" extends="CommonTabBarMenu" extends-resource="component://common/widget/CommonMenus.xml">
+ <menu-item name="find" title="${uiLabelMap.CommonFind}">
+ <link target="findInvoices"/>
+ </menu-item>
<menu-item name="invoiceOverview" title="${uiLabelMap.AccountingInvoiceOverview}">
<condition>
<not><if-empty field="invoice.invoiceId"/></not>
@@ -298,7 +301,6 @@
<if-compare field="invoice.statusId" operator="equals" value="INVOICE_SENT"/>
<if-compare field="invoice.statusId" operator="equals" value="INVOICE_RECEIVED"/>
<if-compare field="invoice.statusId" operator="equals" value="INVOICE_READY"/>
- <if-compare field="invoice.statusId" operator="equals" value="INVOICE_PAID"/>
</or>
</and>
</condition>
Re: svn commit: r796178 -
/ofbiz/trunk/applications/accounting/widget/Menus.xml
Posted by Hans Bakker <ma...@antwebsystems.com>.
ok i missed that...still i am very surprised how you can cancel a posted
and paid invoice...
i tried it and it did not work anyway....that is why i changed it.
Regards,
Hans
On Tue, 2009-07-21 at 07:32 -0700, Adrian Crum wrote:
> Hans,
>
> This commit reverts rev 792188. Perhaps it would be best if business
> logic changes were discussed on the mailing list before making these
> kind of changes.
>
> -Adrian
>
> hansbak@apache.org wrote:
> > Author: hansbak
> > Date: Tue Jul 21 08:34:27 2009
> > New Revision: 796178
> >
> > URL: http://svn.apache.org/viewvc?rev=796178&view=rev
> > Log:
> > cannot cancel a paid invoice, add find button
> >
> > Modified:
> > ofbiz/trunk/applications/accounting/widget/Menus.xml
> >
> > Modified: ofbiz/trunk/applications/accounting/widget/Menus.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/Menus.xml?rev=796178&r1=796177&r2=796178&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/applications/accounting/widget/Menus.xml (original)
> > +++ ofbiz/trunk/applications/accounting/widget/Menus.xml Tue Jul 21 08:34:27 2009
> > @@ -47,6 +47,9 @@
> > </menu>
> >
> > <menu name="InvoiceTabBar" extends="CommonTabBarMenu" extends-resource="component://common/widget/CommonMenus.xml">
> > + <menu-item name="find" title="${uiLabelMap.CommonFind}">
> > + <link target="findInvoices"/>
> > + </menu-item>
> > <menu-item name="invoiceOverview" title="${uiLabelMap.AccountingInvoiceOverview}">
> > <condition>
> > <not><if-empty field="invoice.invoiceId"/></not>
> > @@ -298,7 +301,6 @@
> > <if-compare field="invoice.statusId" operator="equals" value="INVOICE_SENT"/>
> > <if-compare field="invoice.statusId" operator="equals" value="INVOICE_RECEIVED"/>
> > <if-compare field="invoice.statusId" operator="equals" value="INVOICE_READY"/>
> > - <if-compare field="invoice.statusId" operator="equals" value="INVOICE_PAID"/>
> > </or>
> > </and>
> > </condition>
> >
> >
> >
--
Antwebsystems.com: Quality OFBiz services for competitive rates
Re: svn commit: r796178 - /ofbiz/trunk/applications/accounting/widget/Menus.xml
Posted by Anil Patel <an...@hotwaxmedia.com>.
I wanted to object as well. Before writing email I discussed with
Jacopo and concluded that their is no sense in fighting, instead we'll
maintain patch in our deployments.
Regards
Anil Patel
On Jul 21, 2009, at 8:02 PM, Adrian Crum wrote:
> Hans,
>
> This commit reverts rev 792188. Perhaps it would be best if business
> logic changes were discussed on the mailing list before making these
> kind of changes.
>
> -Adrian
>
> hansbak@apache.org wrote:
>> Author: hansbak
>> Date: Tue Jul 21 08:34:27 2009
>> New Revision: 796178
>> URL: http://svn.apache.org/viewvc?rev=796178&view=rev
>> Log:
>> cannot cancel a paid invoice, add find button
>> Modified:
>> ofbiz/trunk/applications/accounting/widget/Menus.xml
>> Modified: ofbiz/trunk/applications/accounting/widget/Menus.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/Menus.xml?rev=796178&r1=796177&r2=796178&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/accounting/widget/Menus.xml (original)
>> +++ ofbiz/trunk/applications/accounting/widget/Menus.xml Tue Jul 21
>> 08:34:27 2009
>> @@ -47,6 +47,9 @@
>> </menu>
>> <menu name="InvoiceTabBar" extends="CommonTabBarMenu" extends-
>> resource="component://common/widget/CommonMenus.xml">
>> + <menu-item name="find" title="${uiLabelMap.CommonFind}">
>> + <link target="findInvoices"/>
>> + </menu-item>
>> <menu-item name="invoiceOverview" title="$
>> {uiLabelMap.AccountingInvoiceOverview}">
>> <condition>
>> <not><if-empty field="invoice.invoiceId"/></not>
>> @@ -298,7 +301,6 @@
>> <if-compare field="invoice.statusId"
>> operator="equals" value="INVOICE_SENT"/>
>> <if-compare field="invoice.statusId"
>> operator="equals" value="INVOICE_RECEIVED"/>
>> <if-compare field="invoice.statusId"
>> operator="equals" value="INVOICE_READY"/>
>> - <if-compare field="invoice.statusId"
>> operator="equals" value="INVOICE_PAID"/>
>> </or>
>> </and>
>> </condition>
Re: svn commit: r796178 -
/ofbiz/trunk/applications/accounting/widget/Menus.xml
Posted by Hans Bakker <ma...@antwebsystems.com>.
Ok i tried to cancel a paid invoice and got the following error:
The Following Errors Occurred:
Error calling event: org.ofbiz.webapp.event.EventHandlerException:
Service invocation error (Could not commit transaction for service
[setInvoiceStatus] call: Roll back error, could not commit transaction,
was rolled back instead because of: Error in simple-method [Remove an
existing payment application
[file:/home/hans/ofbiz/svn/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml#removePaymentApplication]]: ; [PaymentID [10021] has status 'confirmed', cannot remove application.])
perhaps fix this first before the button is put back?
Regards,
Hans
On Tue, 2009-07-21 at 07:32 -0700, Adrian Crum wrote:
> Hans,
>
> This commit reverts rev 792188. Perhaps it would be best if business
> logic changes were discussed on the mailing list before making these
> kind of changes.
>
> -Adrian
>
> hansbak@apache.org wrote:
> > Author: hansbak
> > Date: Tue Jul 21 08:34:27 2009
> > New Revision: 796178
> >
> > URL: http://svn.apache.org/viewvc?rev=796178&view=rev
> > Log:
> > cannot cancel a paid invoice, add find button
> >
> > Modified:
> > ofbiz/trunk/applications/accounting/widget/Menus.xml
> >
> > Modified: ofbiz/trunk/applications/accounting/widget/Menus.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/Menus.xml?rev=796178&r1=796177&r2=796178&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/applications/accounting/widget/Menus.xml (original)
> > +++ ofbiz/trunk/applications/accounting/widget/Menus.xml Tue Jul 21 08:34:27 2009
> > @@ -47,6 +47,9 @@
> > </menu>
> >
> > <menu name="InvoiceTabBar" extends="CommonTabBarMenu" extends-resource="component://common/widget/CommonMenus.xml">
> > + <menu-item name="find" title="${uiLabelMap.CommonFind}">
> > + <link target="findInvoices"/>
> > + </menu-item>
> > <menu-item name="invoiceOverview" title="${uiLabelMap.AccountingInvoiceOverview}">
> > <condition>
> > <not><if-empty field="invoice.invoiceId"/></not>
> > @@ -298,7 +301,6 @@
> > <if-compare field="invoice.statusId" operator="equals" value="INVOICE_SENT"/>
> > <if-compare field="invoice.statusId" operator="equals" value="INVOICE_RECEIVED"/>
> > <if-compare field="invoice.statusId" operator="equals" value="INVOICE_READY"/>
> > - <if-compare field="invoice.statusId" operator="equals" value="INVOICE_PAID"/>
> > </or>
> > </and>
> > </condition>
> >
> >
> >
--
Antwebsystems.com: Quality OFBiz services for competitive rates
Re: svn commit: r796178 - /ofbiz/trunk/applications/accounting/widget/Menus.xml
Posted by Adrian Crum <ad...@hlmksw.com>.
Hans,
This commit reverts rev 792188. Perhaps it would be best if business
logic changes were discussed on the mailing list before making these
kind of changes.
-Adrian
hansbak@apache.org wrote:
> Author: hansbak
> Date: Tue Jul 21 08:34:27 2009
> New Revision: 796178
>
> URL: http://svn.apache.org/viewvc?rev=796178&view=rev
> Log:
> cannot cancel a paid invoice, add find button
>
> Modified:
> ofbiz/trunk/applications/accounting/widget/Menus.xml
>
> Modified: ofbiz/trunk/applications/accounting/widget/Menus.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/Menus.xml?rev=796178&r1=796177&r2=796178&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/widget/Menus.xml (original)
> +++ ofbiz/trunk/applications/accounting/widget/Menus.xml Tue Jul 21 08:34:27 2009
> @@ -47,6 +47,9 @@
> </menu>
>
> <menu name="InvoiceTabBar" extends="CommonTabBarMenu" extends-resource="component://common/widget/CommonMenus.xml">
> + <menu-item name="find" title="${uiLabelMap.CommonFind}">
> + <link target="findInvoices"/>
> + </menu-item>
> <menu-item name="invoiceOverview" title="${uiLabelMap.AccountingInvoiceOverview}">
> <condition>
> <not><if-empty field="invoice.invoiceId"/></not>
> @@ -298,7 +301,6 @@
> <if-compare field="invoice.statusId" operator="equals" value="INVOICE_SENT"/>
> <if-compare field="invoice.statusId" operator="equals" value="INVOICE_RECEIVED"/>
> <if-compare field="invoice.statusId" operator="equals" value="INVOICE_READY"/>
> - <if-compare field="invoice.statusId" operator="equals" value="INVOICE_PAID"/>
> </or>
> </and>
> </condition>
>
>
>