You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2017/12/18 14:41:31 UTC
svn commit: r1818578 - /subversion/trunk/subversion/libsvn_repos/list.c
Author: stefan2
Date: Mon Dec 18 14:41:31 2017
New Revision: 1818578
URL: http://svn.apache.org/viewvc?rev=1818578&view=rev
Log:
Fix svn_repos_stat() implemention for directories to match the svn_dirent_t
docstring.
* subversion/libsvn_repos/list.c
(fill_dirent): Make sure SIZE is 0 for directories.
Modified:
subversion/trunk/subversion/libsvn_repos/list.c
Modified: subversion/trunk/subversion/libsvn_repos/list.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/list.c?rev=1818578&r1=1818577&r2=1818578&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/list.c (original)
+++ subversion/trunk/subversion/libsvn_repos/list.c Mon Dec 18 14:41:31 2017
@@ -50,6 +50,8 @@ fill_dirent(svn_dirent_t *dirent,
if (dirent->kind == svn_node_file)
SVN_ERR(svn_fs_file_length(&(dirent->size), root, path, scratch_pool));
+ else
+ dirent->size = 0;
SVN_ERR(svn_fs_node_has_props(&dirent->has_props, root, path,
scratch_pool));
Re: svn commit: r1818578 -
/subversion/trunk/subversion/libsvn_repos/list.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Good morning Stefan,
stefan2@apache.org wrote on Mon, 18 Dec 2017 14:41 +0000:
> Fix svn_repos_stat() implemention for directories to match the svn_dirent_t
> docstring.
>
> * subversion/libsvn_repos/list.c
> (fill_dirent): Make sure SIZE is 0 for directories.
>
> +++ subversion/trunk/subversion/libsvn_repos/list.c Mon Dec 18 14:41:31 2017
> @@ -50,6 +50,8 @@ fill_dirent(svn_dirent_t *dirent,
> if (dirent->kind == svn_node_file)
> SVN_ERR(svn_fs_file_length(&(dirent->size), root, path, scratch_pool));
> + else
> + dirent->size = 0;
Should this be backported?
Daniel
Re: svn commit: r1818578 -
/subversion/trunk/subversion/libsvn_repos/list.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Good morning Stefan,
stefan2@apache.org wrote on Mon, 18 Dec 2017 14:41 +0000:
> Fix svn_repos_stat() implemention for directories to match the svn_dirent_t
> docstring.
>
> * subversion/libsvn_repos/list.c
> (fill_dirent): Make sure SIZE is 0 for directories.
>
> +++ subversion/trunk/subversion/libsvn_repos/list.c Mon Dec 18 14:41:31 2017
> @@ -50,6 +50,8 @@ fill_dirent(svn_dirent_t *dirent,
> if (dirent->kind == svn_node_file)
> SVN_ERR(svn_fs_file_length(&(dirent->size), root, path, scratch_pool));
> + else
> + dirent->size = 0;
Should this be backported?
Daniel