You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/12 21:35:01 UTC

[kudu-CR] [java] one more option forcing tests to run

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15422


Change subject: [java] one more option forcing tests to run
......................................................................

[java] one more option forcing tests to run

Updated README.adoc adding one more option to force tests to run
with gradle.

Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
---
M java/README.adoc
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/15422/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
Gerrit-Change-Number: 15422
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [java] one more option forcing tests to run

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15422 )

Change subject: [java] one more option forcing tests to run
......................................................................


Patch Set 2: Code-Review+2

Carrying over Grant's +2 from PS1.


-- 
To view, visit http://gerrit.cloudera.org:8080/15422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
Gerrit-Change-Number: 15422
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 03:50:17 +0000
Gerrit-HasComments: No

[kudu-CR] [java] one more option forcing tests to run

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15422 )

Change subject: [java] one more option forcing tests to run
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15422/1/java/README.adoc
File java/README.adoc:

http://gerrit.cloudera.org:8080/#/c/15422/1/java/README.adoc@65
PS1, Line 65: you can pass `-PrerunTests`. Another option is to run
> The difference here is that one will spend a bunch of extra time re-buildin
I'll add that info, thanks.  For some reason, -PrerunTests didn't work for me in a couple of times.



-- 
To view, visit http://gerrit.cloudera.org:8080/15422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
Gerrit-Change-Number: 15422
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 22:01:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] one more option forcing tests to run

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15422 )

Change subject: [java] one more option forcing tests to run
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15422/1/java/README.adoc
File java/README.adoc:

http://gerrit.cloudera.org:8080/#/c/15422/1/java/README.adoc@65
PS1, Line 65: you can pass `-PrerunTests`. Another option is to run
The difference here is that one will spend a bunch of extra time re-building test state, while the other will just run them again. Using -PrerunTests can be useful to quickly loop on tests with less slowdown.



-- 
To view, visit http://gerrit.cloudera.org:8080/15422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
Gerrit-Change-Number: 15422
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 21:38:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] one more option forcing tests to run

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15422

to look at the new patch set (#2).

Change subject: [java] one more option forcing tests to run
......................................................................

[java] one more option forcing tests to run

Updated README.adoc adding one more option to force tests to run
with gradle.

Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
---
M java/README.adoc
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/15422/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
Gerrit-Change-Number: 15422
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] one more option forcing tests to run

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15422 )

Change subject: [java] one more option forcing tests to run
......................................................................

[java] one more option forcing tests to run

Updated README.adoc adding one more option to force tests to run
with gradle.

Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
Reviewed-on: http://gerrit.cloudera.org:8080/15422
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/README.adoc
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ed02b5b7e7011adacea2e447ce1c7f99d6deb56
Gerrit-Change-Number: 15422
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)