[GitHub] [kafka] lct45 commented on a change in pull request #10813: KAFKA-9559: Change default serde to be `null`

[GitBox <gi...@apache.org>]

lct45 commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r646593361



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java
##########
@@ -78,6 +79,10 @@
                 throw new StreamsException("Fatal user code error in deserialization error callback", fatalUserException);
             }
 
+            if (deserializationException instanceof ConfigException) {

Review comment:
       I think it could be, but I'm not sure I understand why that might be preferable. I guess we wouldn't want the config exception overridden by a user exception? In that case,  yeah it would make sense to move it up. When I saw this in testing the first check for user error didn't interfere with seeing the config error, but I can see how that would change when running a full app




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org