[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7137: T3C parent.config simulate topology for non topo delivery services

[GitBox <gi...@apache.org>]

rob05c commented on code in PR #7137:
URL: https://github.com/apache/trafficcontrol/pull/7137#discussion_r997367115


##########
lib/go-atscfg/parentdotconfig.go:
##########
@@ -165,6 +165,11 @@ func MakeParentDotConfig(
 	}, nil
 }
 
+// Check if this ds type is edge only

Review Comment:
   Symbol comments should be complete sentences starting with the symbol name and ending with a period, for GoDoc. Should be `// IsGoDirect checks if this ds type is edge only.`
   
   Also, would you object to moving this func to `atscfg.go`? Seems fairly generic, might be useful in other configs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org