You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/02/18 22:28:50 UTC
[GitHub] [tinkerpop] rdtr opened a new pull request #1392: add a public helper method to retrieve select key from WherePredicate…
rdtr opened a new pull request #1392:
URL: https://github.com/apache/tinkerpop/pull/1392
…Step
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] rdtr closed pull request #1392: add a public helper method to retrieve select key from WherePredicate…
Posted by GitBox <gi...@apache.org>.
rdtr closed pull request #1392:
URL: https://github.com/apache/tinkerpop/pull/1392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1392: add a public helper method to retrieve select key from WherePredicate…
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1392:
URL: https://github.com/apache/tinkerpop/pull/1392#issuecomment-784183555
I think that the issue is that the new method is referring the member variable of `parameters` rather than the one local to the calling method:
https://github.com/apache/tinkerpop/pull/1392/files#diff-0e30cd3ebe2d8f6d9ac7ce6c9e91762ed7a98ff2f7682b4041faf8dbd8bb9898R68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1392: add a public helper method to retrieve select key from WherePredicate…
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1392:
URL: https://github.com/apache/tinkerpop/pull/1392#issuecomment-782309837
Looks like Travis is getting some build failures with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org