You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jsoref <gi...@git.apache.org> on 2014/06/11 22:26:29 UTC

[GitHub] cordova-blackberry pull request: CB-6925 simulator detection: fail...

GitHub user jsoref opened a pull request:

    https://github.com/apache/cordova-blackberry/pull/161

    CB-6925 simulator detection: fail gracefully w/ no DHCP leases

    r? @bryanhiggins 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blackberry/cordova-blackberry cb_6925

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-blackberry/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 8ca4044df41637fbebf39e6a3ac7a13e80cbc9c1
Author: Josh Soref <js...@blackberry.com>
Date:   2014-06-11T20:25:24Z

    CB-6925 simulator detection: fail gracefully w/ no DHCP leases

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-blackberry pull request: CB-6925 simulator detection: fail...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-blackberry/pull/161


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-blackberry pull request: CB-6925 simulator detection: fail...

Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:

    https://github.com/apache/cordova-blackberry/pull/161#issuecomment-45795283
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---