You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/25 05:02:42 UTC
[GitHub] [iceberg] kbendick opened a new pull request #1249: Fix missing Override warnings in org.apache.iceberg.BaseFile
kbendick opened a new pull request #1249:
URL: https://github.com/apache/iceberg/pull/1249
When building the project for the first time, the compiler warns that there are several places that are missing overrides.
I've discussed the issue here: https://github.com/apache/iceberg/issues/1248
I have taken a shot at removing these warnings and adding the `@Override` annotation to non-abstract methods in `BaseFile` from the `iceberg-core` module. There are more warnings than just this one file, but I wanted to keep the workload light in this first PR in case the missing Overrides were intentional (in which case we might consider the use of `@SuppressWarnings`).
As I'm relatively new to the project, I'd love any feedback possible. I'm tagging @openinx as I've recently commented on their PR's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdsr commented on pull request #1249: Fix missing Override warnings in org.apache.iceberg.BaseFile
Posted by GitBox <gi...@apache.org>.
rdsr commented on pull request #1249:
URL: https://github.com/apache/iceberg/pull/1249#issuecomment-663890336
Welcome @kbendick. I think the override annotations are great to have. +1 from me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1249: Fix missing Override warnings in org.apache.iceberg.BaseFile
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1249:
URL: https://github.com/apache/iceberg/pull/1249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1249: Fix missing Override warnings in org.apache.iceberg.BaseFile
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1249:
URL: https://github.com/apache/iceberg/pull/1249#issuecomment-663910306
Thank you @rdsr! Once I get an approval, what's the process to merge? Should I continue to the override work in this PR or make a separate PR for the rest of them?
I really appreciate you taking a look. OSS can feel a bit daunting at times but I'm really interested in contributing, especially to this project, any way I can. This project really feels like the next generation of data lakes to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1249: Fix missing Override warnings in org.apache.iceberg.BaseFile
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1249:
URL: https://github.com/apache/iceberg/pull/1249#issuecomment-663810622
I tested this by running `./gradlew clean && ./gradlew build` and observing that the warnings about missing overrides were gone from BaseFile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1249: Fix missing Override warnings in org.apache.iceberg.BaseFile
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1249:
URL: https://github.com/apache/iceberg/pull/1249#issuecomment-663924865
I think @rdsr was just allowing time for other people to review. There aren't any extra steps necessary once a committer approves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org