You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/11 15:39:43 UTC
[GitHub] [beam] eantyshev opened a new pull request, #24118: [Tour Of Beam] verify that unit exists when saving progress
eantyshev opened a new pull request, #24118:
URL: https://github.com/apache/beam/pull/24118
addresses #24088
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #24118: [Tour Of Beam] verify that unit exists when saving progress
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #24118:
URL: https://github.com/apache/beam/pull/24118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24118: [Tour Of Beam] verify that unit exists when saving progress
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24118:
URL: https://github.com/apache/beam/pull/24118#issuecomment-1314060343
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24118: [Tour Of Beam] verify that unit exists when saving progress
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24118:
URL: https://github.com/apache/beam/pull/24118#discussion_r1021680956
##########
learning/tour-of-beam/backend/integration_tests/auth_test.go:
##########
@@ -36,76 +37,100 @@ func TestMain(m *testing.M) {
os.Exit(m.Run())
}
+func makeUserCodeRequest() UserCodeRequest {
+ return UserCodeRequest{
+ Files: []UserCodeFile{
+ {Name: "main.py", Content: "import sys; sys.exit(0)", IsMain: true},
+ },
+ PipelineOptions: "some opts",
+ }
+}
+
+func checkBadHttpCode(t *testing.T, err error, code int) {
+ if err == nil {
+ t.Fatal("error expected")
+ }
+ if err, ok := err.(*ErrBadResponse); ok {
+ if err.Code == code {
+ return
+ }
+ }
+ t.Fatal(err)
Review Comment:
```suggestion
t.Fatal("Expected ErrBadResponse with code %v, got %v", code, err)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #24118: [Tour Of Beam] verify that unit exists when saving progress
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #24118:
URL: https://github.com/apache/beam/pull/24118#issuecomment-1313469792
LGTM! Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org