You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/12/18 18:35:20 UTC
Review Request 64683: Updated support/mesos-style.py to build the
virtualenv less often.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64683/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benno Evers.
Bugs: MESOS-8217
https://issues.apache.org/jira/browse/MESOS-8217
Repository: mesos
Description
-------
Instead of just checking if the virtual environment exists, we now
also check if it is required to lint the modified files or not.
The virtual environment will thus be built when using the script as
a git hook only if JavaScript or Python files have been modified.
Diffs
-----
support/mesos-style.py 315955e3533fce0cbf820fad03b3707049cdffe0
Diff: https://reviews.apache.org/r/64683/diff/1/
Testing
-------
Tested the commit hook with multiple combinations and checked that the result was the one expected.
Thanks,
Armand Grillet
Re: Review Request 64683: Updated support/mesos-style.py to build the
virtualenv less often.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64683/#review194081
-----------------------------------------------------------
PASS: Mesos patch 64683 was successfully built and tested.
Reviews applied: `['64683']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64683
- Mesos Reviewbot Windows
On Dec. 18, 2017, 8:35 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64683/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2017, 8:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Bugs: MESOS-8217
> https://issues.apache.org/jira/browse/MESOS-8217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of just checking if the virtual environment exists, we now
> also check if it is required to lint the modified files or not.
>
> The virtual environment will thus be built when using the script as
> a git hook only if JavaScript or Python files have been modified.
>
>
> Diffs
> -----
>
> support/mesos-style.py 315955e3533fce0cbf820fad03b3707049cdffe0
>
>
> Diff: https://reviews.apache.org/r/64683/diff/1/
>
>
> Testing
> -------
>
> Tested the commit hook with multiple combinations and checked that the result was the one expected.
>
>
> Thanks,
>
> Armand Grillet
>
>