You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Richard Hirsch <hi...@gmail.com> on 2010/02/15 16:05:43 UTC
[VOTE] Approve the release of apache-esme-incubating-1.0
The ESME community has voted on and approved the release of ESME 1.0.
We would now like to request the approval of the Incubator PMC for
this release.
Details of the ESME community vote can be found here:
http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3Cfa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
The candidate can be found at:
http://people.apache.org/~rhirsch/esme/
See the CHANGES.txt file for details on release contents. The release
candidate is a tar archive of the sources in
https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
The MD5 checksum of the apache-esme-incubating-1.0-
src.tar.gz release package is
A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
Please vote on releasing this package as Apache ESME 1.0-incubating.
Please vote to publish this release by Thursday, Feb 18 16:03 CET,
please include the testing you performed to arrive at your vote
[ ] +1 Publish
[ ] 0 Abstain
[ ] -1 Don't publish, because...
Below is a summary of the vote on the ESME mailing list
Thanks
Dick
---------------
Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆
to esme-dev@incubator.apache.org
date Mon, Feb 15, 2010 at 4:00 PM
subject [VOTE][RESULT] ESME 1.0
mailed-by gmail.com
Hello All,
Voting on the ESME 1.0 candidate release has concluded
Results:
6 binding +1 vote
Dick Hirsch +1
Mrinal Wadhwa +1
Vassil Dichev +1
Ethan Jewett +1
Anne Kathrine Petteroe +1
Darren Hague +1
1 non-binding +1 votes
Daniel Koller +1
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Wed, Feb 17, 2010 at 4:22 PM, Richard Hirsch <hi...@gmail.com> wrote:
> Working on the problerm with signing the release and I'm getting the same
> problem that Bertrand describes. Maybe it is a difference between using SHA1
> and SHA512. ..
Ah ok - I assumed SHA1 (and my openssl doesn't do sha512), but
re-reading http://www.apache.org/dev/release-signing.html I see that
SHA512 is recommended there, with a .sha extension.
If you generate an SHA512 digest (which is fine), using an .sha512
extension instead would IMHO make it clearer which digest algorithm is
used.
For Sling releases we use .sha1 (http://www.apache.org/dist/sling/) -
I think using just .sha leaves room for confusion, as happened to me
;-)
-Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
Thanks.
So I assume the SHA and MD5 files are OK.
I'll put everything on my people.apache.org account later - I can't access
it right now - and restart the vote.
D.
On Wed, Feb 17, 2010 at 4:49 PM, Daniel Kulp <dk...@apache.org> wrote:
>
> Normally to generate the md5 and sha1, I just use the md5sum/md5 and
> sha1sum/sah1 commands on pretty much any unix box. You could do it
> right
> on people.apache.org if you wanted. "sha1 -q file > file.sha1"
>
> Dan
>
>
> On Wed February 17 2010 10:22:01 am Richard Hirsch wrote:
> > Working on the problerm with signing the release and I'm getting the same
> > problem that Bertrand describes. Maybe it is a difference between using
> > SHA1 and SHA512. ..
> >
> > I verified it and it looks OK:
> >
> > C:\Program Files\GNU\GnuPG>gpg --verify
> > apache-esme-1-0-0-incubating.src.tar.gz.
> > asc apache-esme-1-0-0-incubating.src.tar.gz
> > gpg: Unterschrift vom 02/17/10 15:48:32 mittels RSA-Schlüssel ID 6FACF917
> > gpg: Korrekte Unterschrift von "Richard Hirsch (CODE SIGNING KEY) <
> > rhirsch@apache.org>"
> >
> > I signed the release with the following commands:
> >
> > gpg --armor --output apache-esme-1-0-0-incubating.src.tar.gz.asc
> > --detach-sig apache-esme-1-0-0-incubating.src.tar.gz
> > gpg --print-md SHA512 apache-esme-1-0-0-incubating.src.tar.gz >
> > apache-esme-1-0-0-incubating.src.tar.gz.sha
> > gpg --print-md MD5 apache-esme-1-0-0-incubating.src.tar.gz >
> > apache-esme-1-0-0-incubating.src.tar.gz.md5
> >
> >
> > What I don't know how to do is verify using MD5 or SHA? I found this
> > sentence in the "Signing Releases" Apache Documen": "MD5 <#md5> and
> > SHA<#sha-checksum>checksums provide a simple, means of verifying the
> > integrity of a download.
> > You can simply create a checksum (in the same way as the release manager)
> > after download, and compare the result to the checksum downloaded from
> the
> > main Apache site. " but I have no idea how it is done.
> >
> > The contents of the files are
> >
> > * output apache-esme-1-0-0-incubating.src.tar.gz.asc:
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.10 (MingW32)
> >
> > iQIcBAABCgAGBQJLfAHAAAoJEItBUOZvrPkXfeQP/ie7n1axfF5xBb/HbtatCUzW
> > TbYIznhhLZ4xq1bitxA5clSveUnH7O8oRsEmCUBbzday90qHhZUzkVEspr30DB/5
> > j9Tx2+Ov09lShX+L24rKGeL9ReZ5YbiuSxh7WmaESlnSnP3J5NMsG7Um+v2ICyhb
> > NM1HUO7P1D5Xn9LZragOS0dt9VRAEb6h38rbBarRrFjKADf9gLqdkXmv7NgIWWwI
> > AFSJKzUATShT6u4sRJDlauSB0VS8NGfV4F+10OKsmIIHbMyDyTt01chr4KCXcjnf
> > siGHABBPBDUytjx648ohiXJPtmyovBTcqWtn3RF/dneSSCwibKgCGbJQgPCaWxvR
> > uh14gLTdSt2c4VMs0reychMh/fGfAumuPDL2voS+AHc1QCALRiePnqgfxVwW40nP
> > olQP5EPJpVr7vmOrOD29WgxEAlTqDsKLgTAkXAi1sPHpiHapDwu5PalaIMcmw8CS
> > ZBj39pdKFLUQkxgPU08nS/2n6BUcRkNpH6e4ngfQIltSaYN501CUrqi3nLMwx006
> > 3zgTxm/ob6E6z13djolix2w0GQE6hkKDwesCj6K1h/sWp7y9rYiqIqS5A3WO+jAz
> > yij43gkNYzPnjr8Dz8mJM53FWWA+kQvF8E1iesIdTk1s5IaUno9ipqFSHv6wf1TQ
> > PfkCUjE05RyhSY3lDAmY
> > =Y4I/
> > -----END PGP SIGNATURE-----
> >
> >
> > * apache-esme-1-0-0-incubating.src.tar.gz.sha
> >
> > apache-esme-1-0-0-incubating.src.tar.gz:
> > 771A97EB 34FD26C1 D431E4EA D7D4FC4C 3971DB42 F50B0B66 C32D601F 70D450FB
> > 06F73667
> > 8E118141 5A83C40A 84C1ABDF 808551DC 10949049 1962C634 FFBFAE69
> >
> > * apache-esme-1-0-0-incubating.src.tar.gz.md5
> >
> > apache-esme-1-0-0-incubating.src.tar.gz:
> > 8E 43 0D DF F8 FE 15 9B 22 47 C2 C0 CC 30 21 2C
> >
> > I then used this command: openssl sha1
> > apache-esme-1-0-0-incubating.src.tar.gz
> > SHA1(apache-esme-1-0-0-incubating.src.tar.gz)=
> > e87405b0df026fde41c65c31c11b8026c
> > a06687d
> >
> > Does somebody have a clue if I'm doing something wrong...
> >
> > Thanks.
> >
> > D.
> >
> > On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz
> > <bdelacretaz@apache.org
> >
> > > wrote:
> > >
> > > Hi,
> > >
> > > On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hirsch.dick@gmail.com
> >
> > >
> > > wrote:
> > > > ...The candidate can be found at:
> > > > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
> <http://people.apache.org/%7Erh
> > > > irsch/esme/>
> > >
> > > Unfortunately I'm -1 on the release, I have a few issues including a
> > > GPL dependency.
> > >
> > > 1) jwebunit dependency is GPL
> > > The server module depends on
> > >
> > > net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
> > >
> > > which according to http://jwebunit.sourceforge.net/license.html is
> GPL.
> > >
> > > 2) The sha1 digest does not match, did I do something wrong?
> > >
> > > $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> > > SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> > > a9ec8d95266d5944d493392a06eb1651c03222f1
> > >
> > > $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> > > apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516
> > > C2448CB6
> > >
> > > 64B3B76C 747BA64A FFC9A836
> EDAB8D86
> > > 4E0735CC AA29ACA9 07767C58
> D1C0FEDA
> > > CA7E73A3 ADA3944D 464314B2
> 4BE0E476
> > >
> > > 3) mvn dependency:analyze of the server module shows lots of unused
> > > declared dependencies, those should be cleaned up, especially
> > > openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
> > > either GPL or CDDL license. Not sure which parts of OpenDMK are which
> > > license, but as it's unused better remove it.
> > >
> > > 4) When trying to build esme-java-client with "mvn clean install" I
> > > get "Embedded error: Error while executing the external compiler" if
> > > JAVA_HOME is not set.
> > >
> > > 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> > > should not have that. You could have created the release using svn
> > > export of
> > >
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incub
> > > ating/ to avoid that.
> > >
> > > 6) I couldn't find license information for the
> > > com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> > > ok?
> > >
> > > Sorry that I didn't have time to look at that during the ESME podling
> > > vote.
> > >
> > > Apart from the GPL dependency the release preparation looks mostly ok,
> > > rat reports are good, license/notice are provided, etc.
> > >
> > > -Bertrand
>
> --
> Daniel Kulp
> dkulp@apache.org
> http://www.dankulp.com/blog
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Daniel Kulp <dk...@apache.org>.
Normally to generate the md5 and sha1, I just use the md5sum/md5 and
sha1sum/sah1 commands on pretty much any unix box. You could do it right
on people.apache.org if you wanted. "sha1 -q file > file.sha1"
Dan
On Wed February 17 2010 10:22:01 am Richard Hirsch wrote:
> Working on the problerm with signing the release and I'm getting the same
> problem that Bertrand describes. Maybe it is a difference between using
> SHA1 and SHA512. ..
>
> I verified it and it looks OK:
>
> C:\Program Files\GNU\GnuPG>gpg --verify
> apache-esme-1-0-0-incubating.src.tar.gz.
> asc apache-esme-1-0-0-incubating.src.tar.gz
> gpg: Unterschrift vom 02/17/10 15:48:32 mittels RSA-Schlüssel ID 6FACF917
> gpg: Korrekte Unterschrift von "Richard Hirsch (CODE SIGNING KEY) <
> rhirsch@apache.org>"
>
> I signed the release with the following commands:
>
> gpg --armor --output apache-esme-1-0-0-incubating.src.tar.gz.asc
> --detach-sig apache-esme-1-0-0-incubating.src.tar.gz
> gpg --print-md SHA512 apache-esme-1-0-0-incubating.src.tar.gz >
> apache-esme-1-0-0-incubating.src.tar.gz.sha
> gpg --print-md MD5 apache-esme-1-0-0-incubating.src.tar.gz >
> apache-esme-1-0-0-incubating.src.tar.gz.md5
>
>
> What I don't know how to do is verify using MD5 or SHA? I found this
> sentence in the "Signing Releases" Apache Documen": "MD5 <#md5> and
> SHA<#sha-checksum>checksums provide a simple, means of verifying the
> integrity of a download.
> You can simply create a checksum (in the same way as the release manager)
> after download, and compare the result to the checksum downloaded from the
> main Apache site. " but I have no idea how it is done.
>
> The contents of the files are
>
> * output apache-esme-1-0-0-incubating.src.tar.gz.asc:
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (MingW32)
>
> iQIcBAABCgAGBQJLfAHAAAoJEItBUOZvrPkXfeQP/ie7n1axfF5xBb/HbtatCUzW
> TbYIznhhLZ4xq1bitxA5clSveUnH7O8oRsEmCUBbzday90qHhZUzkVEspr30DB/5
> j9Tx2+Ov09lShX+L24rKGeL9ReZ5YbiuSxh7WmaESlnSnP3J5NMsG7Um+v2ICyhb
> NM1HUO7P1D5Xn9LZragOS0dt9VRAEb6h38rbBarRrFjKADf9gLqdkXmv7NgIWWwI
> AFSJKzUATShT6u4sRJDlauSB0VS8NGfV4F+10OKsmIIHbMyDyTt01chr4KCXcjnf
> siGHABBPBDUytjx648ohiXJPtmyovBTcqWtn3RF/dneSSCwibKgCGbJQgPCaWxvR
> uh14gLTdSt2c4VMs0reychMh/fGfAumuPDL2voS+AHc1QCALRiePnqgfxVwW40nP
> olQP5EPJpVr7vmOrOD29WgxEAlTqDsKLgTAkXAi1sPHpiHapDwu5PalaIMcmw8CS
> ZBj39pdKFLUQkxgPU08nS/2n6BUcRkNpH6e4ngfQIltSaYN501CUrqi3nLMwx006
> 3zgTxm/ob6E6z13djolix2w0GQE6hkKDwesCj6K1h/sWp7y9rYiqIqS5A3WO+jAz
> yij43gkNYzPnjr8Dz8mJM53FWWA+kQvF8E1iesIdTk1s5IaUno9ipqFSHv6wf1TQ
> PfkCUjE05RyhSY3lDAmY
> =Y4I/
> -----END PGP SIGNATURE-----
>
>
> * apache-esme-1-0-0-incubating.src.tar.gz.sha
>
> apache-esme-1-0-0-incubating.src.tar.gz:
> 771A97EB 34FD26C1 D431E4EA D7D4FC4C 3971DB42 F50B0B66 C32D601F 70D450FB
> 06F73667
> 8E118141 5A83C40A 84C1ABDF 808551DC 10949049 1962C634 FFBFAE69
>
> * apache-esme-1-0-0-incubating.src.tar.gz.md5
>
> apache-esme-1-0-0-incubating.src.tar.gz:
> 8E 43 0D DF F8 FE 15 9B 22 47 C2 C0 CC 30 21 2C
>
> I then used this command: openssl sha1
> apache-esme-1-0-0-incubating.src.tar.gz
> SHA1(apache-esme-1-0-0-incubating.src.tar.gz)=
> e87405b0df026fde41c65c31c11b8026c
> a06687d
>
> Does somebody have a clue if I'm doing something wrong...
>
> Thanks.
>
> D.
>
> On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz
> <bdelacretaz@apache.org
>
> > wrote:
> >
> > Hi,
> >
> > On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com>
> >
> > wrote:
> > > ...The candidate can be found at:
> > > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erh
> > > irsch/esme/>
> >
> > Unfortunately I'm -1 on the release, I have a few issues including a
> > GPL dependency.
> >
> > 1) jwebunit dependency is GPL
> > The server module depends on
> >
> > net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
> >
> > which according to http://jwebunit.sourceforge.net/license.html is GPL.
> >
> > 2) The sha1 digest does not match, did I do something wrong?
> >
> > $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> > SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> > a9ec8d95266d5944d493392a06eb1651c03222f1
> >
> > $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> > apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516
> > C2448CB6
> >
> > 64B3B76C 747BA64A FFC9A836 EDAB8D86
> > 4E0735CC AA29ACA9 07767C58 D1C0FEDA
> > CA7E73A3 ADA3944D 464314B2 4BE0E476
> >
> > 3) mvn dependency:analyze of the server module shows lots of unused
> > declared dependencies, those should be cleaned up, especially
> > openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
> > either GPL or CDDL license. Not sure which parts of OpenDMK are which
> > license, but as it's unused better remove it.
> >
> > 4) When trying to build esme-java-client with "mvn clean install" I
> > get "Embedded error: Error while executing the external compiler" if
> > JAVA_HOME is not set.
> >
> > 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> > should not have that. You could have created the release using svn
> > export of
> > http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incub
> > ating/ to avoid that.
> >
> > 6) I couldn't find license information for the
> > com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> > ok?
> >
> > Sorry that I didn't have time to look at that during the ESME podling
> > vote.
> >
> > Apart from the GPL dependency the release preparation looks mostly ok,
> > rat reports are good, license/notice are provided, etc.
> >
> > -Bertrand
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
Working on the problerm with signing the release and I'm getting the same
problem that Bertrand describes. Maybe it is a difference between using SHA1
and SHA512. ..
I verified it and it looks OK:
C:\Program Files\GNU\GnuPG>gpg --verify
apache-esme-1-0-0-incubating.src.tar.gz.
asc apache-esme-1-0-0-incubating.src.tar.gz
gpg: Unterschrift vom 02/17/10 15:48:32 mittels RSA-Schlüssel ID 6FACF917
gpg: Korrekte Unterschrift von "Richard Hirsch (CODE SIGNING KEY) <
rhirsch@apache.org>"
I signed the release with the following commands:
gpg --armor --output apache-esme-1-0-0-incubating.src.tar.gz.asc
--detach-sig apache-esme-1-0-0-incubating.src.tar.gz
gpg --print-md SHA512 apache-esme-1-0-0-incubating.src.tar.gz >
apache-esme-1-0-0-incubating.src.tar.gz.sha
gpg --print-md MD5 apache-esme-1-0-0-incubating.src.tar.gz >
apache-esme-1-0-0-incubating.src.tar.gz.md5
What I don't know how to do is verify using MD5 or SHA? I found this
sentence in the "Signing Releases" Apache Documen": "MD5 <#md5> and
SHA<#sha-checksum>checksums provide a simple, means of verifying the
integrity of a download.
You can simply create a checksum (in the same way as the release manager)
after download, and compare the result to the checksum downloaded from the
main Apache site. " but I have no idea how it is done.
The contents of the files are
* output apache-esme-1-0-0-incubating.src.tar.gz.asc:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
iQIcBAABCgAGBQJLfAHAAAoJEItBUOZvrPkXfeQP/ie7n1axfF5xBb/HbtatCUzW
TbYIznhhLZ4xq1bitxA5clSveUnH7O8oRsEmCUBbzday90qHhZUzkVEspr30DB/5
j9Tx2+Ov09lShX+L24rKGeL9ReZ5YbiuSxh7WmaESlnSnP3J5NMsG7Um+v2ICyhb
NM1HUO7P1D5Xn9LZragOS0dt9VRAEb6h38rbBarRrFjKADf9gLqdkXmv7NgIWWwI
AFSJKzUATShT6u4sRJDlauSB0VS8NGfV4F+10OKsmIIHbMyDyTt01chr4KCXcjnf
siGHABBPBDUytjx648ohiXJPtmyovBTcqWtn3RF/dneSSCwibKgCGbJQgPCaWxvR
uh14gLTdSt2c4VMs0reychMh/fGfAumuPDL2voS+AHc1QCALRiePnqgfxVwW40nP
olQP5EPJpVr7vmOrOD29WgxEAlTqDsKLgTAkXAi1sPHpiHapDwu5PalaIMcmw8CS
ZBj39pdKFLUQkxgPU08nS/2n6BUcRkNpH6e4ngfQIltSaYN501CUrqi3nLMwx006
3zgTxm/ob6E6z13djolix2w0GQE6hkKDwesCj6K1h/sWp7y9rYiqIqS5A3WO+jAz
yij43gkNYzPnjr8Dz8mJM53FWWA+kQvF8E1iesIdTk1s5IaUno9ipqFSHv6wf1TQ
PfkCUjE05RyhSY3lDAmY
=Y4I/
-----END PGP SIGNATURE-----
* apache-esme-1-0-0-incubating.src.tar.gz.sha
apache-esme-1-0-0-incubating.src.tar.gz:
771A97EB 34FD26C1 D431E4EA D7D4FC4C 3971DB42 F50B0B66 C32D601F 70D450FB
06F73667
8E118141 5A83C40A 84C1ABDF 808551DC 10949049 1962C634 FFBFAE69
* apache-esme-1-0-0-incubating.src.tar.gz.md5
apache-esme-1-0-0-incubating.src.tar.gz:
8E 43 0D DF F8 FE 15 9B 22 47 C2 C0 CC 30 21 2C
I then used this command: openssl sha1
apache-esme-1-0-0-incubating.src.tar.gz
SHA1(apache-esme-1-0-0-incubating.src.tar.gz)=
e87405b0df026fde41c65c31c11b8026c
a06687d
Does somebody have a clue if I'm doing something wrong...
Thanks.
D.
On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> Hi,
>
> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com>
> wrote:
> > ...The candidate can be found at:
> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
>
> Unfortunately I'm -1 on the release, I have a few issues including a
> GPL dependency.
>
> 1) jwebunit dependency is GPL
> The server module depends on
>
> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>
> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>
> 2) The sha1 digest does not match, did I do something wrong?
>
> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> a9ec8d95266d5944d493392a06eb1651c03222f1
>
> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
> 64B3B76C 747BA64A FFC9A836 EDAB8D86
> 4E0735CC AA29ACA9 07767C58 D1C0FEDA
> CA7E73A3 ADA3944D 464314B2 4BE0E476
>
> 3) mvn dependency:analyze of the server module shows lots of unused
> declared dependencies, those should be cleaned up, especially
> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
> either GPL or CDDL license. Not sure which parts of OpenDMK are which
> license, but as it's unused better remove it.
>
> 4) When trying to build esme-java-client with "mvn clean install" I
> get "Embedded error: Error while executing the external compiler" if
> JAVA_HOME is not set.
>
> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> should not have that. You could have created the release using svn
> export of
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
> to avoid that.
>
> 6) I couldn't find license information for the
> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> ok?
>
> Sorry that I didn't have time to look at that during the ESME podling vote.
>
> Apart from the GPL dependency the release preparation looks mostly ok,
> rat reports are good, license/notice are provided, etc.
>
> -Bertrand
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
@Ethan: Thanks for making the code change
I'll take a look at the other dependencies this morning and make the
appropriate changes.
D.
On Wed, Feb 17, 2010 at 12:45 AM, Ethan Jewett <es...@gmail.com> wrote:
> This turned out to be easy, as jwebunit is only used in the "browse"
> method of the JettyServer, and no one uses the "browse" method, so I
> could just delete it.
>
> I've committed the changes to trunk. We should now be jwebunit-free :-)
>
> Ethan
>
> On Tue, Feb 16, 2010 at 6:29 PM, Ethan Jewett <es...@gmail.com> wrote:
> > Ok, I'm playing email-amateur today. Please respond to this email (to
> > just the ESME list) instead of the detailed email I mistakenly sent
> > out to the general list.
> >
> > Just to re-outline what I mistakenly sent to the general list:
> >
> > I'll try to spend some time looking at it. On the surface, it looks
> > like it's imported into my API2 tests but is not really used. I'll try
> > removing it from the tests in general, not just API2.
> >
> > It looks like it really is used in the JettySetup.scala file. I can
> > try removing it from there as well, but I'm less optimistic that tests
> > will still run. Who originally created this setup? David?
> >
> > Thanks,
> > Ethan
> >
> > On Tue, Feb 16, 2010 at 6:26 PM, Ethan Jewett <es...@gmail.com>
> wrote:
> >> Thanks Joe and Bertrand. Point taken. Better to be safe and respectful
> >> than sorry.
> >>
> >> I'll try to spend some time looking at it. On the surface, it looks
> >> like it's imported into my API2 tests but is not really used. I'll try
> >> removing it from the tests in general, not just API2.
> >>
> >> It looks like it really is used in the JettySetup.scala file. I can
> >> try removing it from there as well, but I'm less optimistic that tests
> >> will still run. Who originally created this setup? David?
> >>
> >> Ethan
> >>
> >> On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz
> >> <bd...@apache.org> wrote:
> >>> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com>
> wrote:
> >>>> ----- Original Message ----
> >>>>
> >>>>> From: Bertrand Delacretaz <bd...@apache.org>
> >>>>> ...Unfortunately I'm -1 on the release, I have a few issues including
> a
> >>>>> GPL dependency.
> >>>>>
> >>>>> 1) jwebunit dependency is GPL
> >>>>> The server module depends on
> >>>>>
> >>>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
> >>>>>
> >>>>> which according to http://jwebunit.sourceforge.net/license.html is
> GPL.
> >>>>
> >>>> Well isn't jwebunit a test framework, in which case, (and assuming
> there
> >>>> are no dependencies on it in the production-ready codebase of esme) do
> >>>> we really care that it's GPL or not? ...
> >>>
> >>> I see your point, one could argue that people don't need jwebunit to
> >>> *run* ESME, they only need it to run the tests when building it.
> >>>
> >>> Still, the code that is distributed contains imports of jwebunit, so I
> >>> think that's stretching the concept too far.
> >>>
> >>>>... (Note an exception to the (L)GPL
> >>>> policy was recently granted for build dependencies, so I think it's
> might
> >>>> be possible to extend that to test deps.)...
> >>>
> >>> Might be possible, but getting rid of that jwwebunit dependency would
> >>> be much cleaner IMO. I haven't checked how much work that represents,
> >>> but according to http://jwebunit.sourceforge.net/ that's "just" a
> >>> wrapper on top of HtmlUnit which has an Apache license, so using
> >>> HtmlUnit instead might not be too hard.
> >>>
> >>> -Bertrand
> >>>
> >>
> >
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Feb 17, 2010 at 12:45 AM, Ethan Jewett <es...@gmail.com> wrote:
> This turned out to be easy, as jwebunit is only used in the "browse"
> method of the JettyServer, and no one uses the "browse" method, so I
> could just delete it.
>
> I've committed the changes to trunk. We should now be jwebunit-free :-)...
Great! It was worth a -1 then ;-)
-Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Ethan Jewett <es...@gmail.com>.
This turned out to be easy, as jwebunit is only used in the "browse"
method of the JettyServer, and no one uses the "browse" method, so I
could just delete it.
I've committed the changes to trunk. We should now be jwebunit-free :-)
Ethan
On Tue, Feb 16, 2010 at 6:29 PM, Ethan Jewett <es...@gmail.com> wrote:
> Ok, I'm playing email-amateur today. Please respond to this email (to
> just the ESME list) instead of the detailed email I mistakenly sent
> out to the general list.
>
> Just to re-outline what I mistakenly sent to the general list:
>
> I'll try to spend some time looking at it. On the surface, it looks
> like it's imported into my API2 tests but is not really used. I'll try
> removing it from the tests in general, not just API2.
>
> It looks like it really is used in the JettySetup.scala file. I can
> try removing it from there as well, but I'm less optimistic that tests
> will still run. Who originally created this setup? David?
>
> Thanks,
> Ethan
>
> On Tue, Feb 16, 2010 at 6:26 PM, Ethan Jewett <es...@gmail.com> wrote:
>> Thanks Joe and Bertrand. Point taken. Better to be safe and respectful
>> than sorry.
>>
>> I'll try to spend some time looking at it. On the surface, it looks
>> like it's imported into my API2 tests but is not really used. I'll try
>> removing it from the tests in general, not just API2.
>>
>> It looks like it really is used in the JettySetup.scala file. I can
>> try removing it from there as well, but I'm less optimistic that tests
>> will still run. Who originally created this setup? David?
>>
>> Ethan
>>
>> On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz
>> <bd...@apache.org> wrote:
>>> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
>>>> ----- Original Message ----
>>>>
>>>>> From: Bertrand Delacretaz <bd...@apache.org>
>>>>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>>>>> GPL dependency.
>>>>>
>>>>> 1) jwebunit dependency is GPL
>>>>> The server module depends on
>>>>>
>>>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>>>>
>>>>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>>>>
>>>> Well isn't jwebunit a test framework, in which case, (and assuming there
>>>> are no dependencies on it in the production-ready codebase of esme) do
>>>> we really care that it's GPL or not? ...
>>>
>>> I see your point, one could argue that people don't need jwebunit to
>>> *run* ESME, they only need it to run the tests when building it.
>>>
>>> Still, the code that is distributed contains imports of jwebunit, so I
>>> think that's stretching the concept too far.
>>>
>>>>... (Note an exception to the (L)GPL
>>>> policy was recently granted for build dependencies, so I think it's might
>>>> be possible to extend that to test deps.)...
>>>
>>> Might be possible, but getting rid of that jwwebunit dependency would
>>> be much cleaner IMO. I haven't checked how much work that represents,
>>> but according to http://jwebunit.sourceforge.net/ that's "just" a
>>> wrapper on top of HtmlUnit which has an Apache license, so using
>>> HtmlUnit instead might not be too hard.
>>>
>>> -Bertrand
>>>
>>
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Ethan Jewett <es...@gmail.com>.
Ok, I'm playing email-amateur today. Please respond to this email (to
just the ESME list) instead of the detailed email I mistakenly sent
out to the general list.
Just to re-outline what I mistakenly sent to the general list:
I'll try to spend some time looking at it. On the surface, it looks
like it's imported into my API2 tests but is not really used. I'll try
removing it from the tests in general, not just API2.
It looks like it really is used in the JettySetup.scala file. I can
try removing it from there as well, but I'm less optimistic that tests
will still run. Who originally created this setup? David?
Thanks,
Ethan
On Tue, Feb 16, 2010 at 6:26 PM, Ethan Jewett <es...@gmail.com> wrote:
> Thanks Joe and Bertrand. Point taken. Better to be safe and respectful
> than sorry.
>
> I'll try to spend some time looking at it. On the surface, it looks
> like it's imported into my API2 tests but is not really used. I'll try
> removing it from the tests in general, not just API2.
>
> It looks like it really is used in the JettySetup.scala file. I can
> try removing it from there as well, but I'm less optimistic that tests
> will still run. Who originally created this setup? David?
>
> Ethan
>
> On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz
> <bd...@apache.org> wrote:
>> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
>>> ----- Original Message ----
>>>
>>>> From: Bertrand Delacretaz <bd...@apache.org>
>>>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>>>> GPL dependency.
>>>>
>>>> 1) jwebunit dependency is GPL
>>>> The server module depends on
>>>>
>>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>>>
>>>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>>>
>>> Well isn't jwebunit a test framework, in which case, (and assuming there
>>> are no dependencies on it in the production-ready codebase of esme) do
>>> we really care that it's GPL or not? ...
>>
>> I see your point, one could argue that people don't need jwebunit to
>> *run* ESME, they only need it to run the tests when building it.
>>
>> Still, the code that is distributed contains imports of jwebunit, so I
>> think that's stretching the concept too far.
>>
>>>... (Note an exception to the (L)GPL
>>> policy was recently granted for build dependencies, so I think it's might
>>> be possible to extend that to test deps.)...
>>
>> Might be possible, but getting rid of that jwwebunit dependency would
>> be much cleaner IMO. I haven't checked how much work that represents,
>> but according to http://jwebunit.sourceforge.net/ that's "just" a
>> wrapper on top of HtmlUnit which has an Apache license, so using
>> HtmlUnit instead might not be too hard.
>>
>> -Bertrand
>>
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Ethan Jewett <es...@gmail.com>.
Thanks Joe and Bertrand. Point taken. Better to be safe and respectful
than sorry.
I'll try to spend some time looking at it. On the surface, it looks
like it's imported into my API2 tests but is not really used. I'll try
removing it from the tests in general, not just API2.
It looks like it really is used in the JettySetup.scala file. I can
try removing it from there as well, but I'm less optimistic that tests
will still run. Who originally created this setup? David?
Ethan
On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
>> ----- Original Message ----
>>
>>> From: Bertrand Delacretaz <bd...@apache.org>
>>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>>> GPL dependency.
>>>
>>> 1) jwebunit dependency is GPL
>>> The server module depends on
>>>
>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>>
>>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>>
>> Well isn't jwebunit a test framework, in which case, (and assuming there
>> are no dependencies on it in the production-ready codebase of esme) do
>> we really care that it's GPL or not? ...
>
> I see your point, one could argue that people don't need jwebunit to
> *run* ESME, they only need it to run the tests when building it.
>
> Still, the code that is distributed contains imports of jwebunit, so I
> think that's stretching the concept too far.
>
>>... (Note an exception to the (L)GPL
>> policy was recently granted for build dependencies, so I think it's might
>> be possible to extend that to test deps.)...
>
> Might be possible, but getting rid of that jwwebunit dependency would
> be much cleaner IMO. I haven't checked how much work that represents,
> but according to http://jwebunit.sourceforge.net/ that's "just" a
> wrapper on top of HtmlUnit which has an Apache license, so using
> HtmlUnit instead might not be too hard.
>
> -Bertrand
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Ethan Jewett <es...@gmail.com>.
Thanks Joe and Bertrand. Point taken. Better to be safe and respectful
than sorry. I'll continue the discussion on the ESME list alone.
Ethan
On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
>> ----- Original Message ----
>>
>>> From: Bertrand Delacretaz <bd...@apache.org>
>>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>>> GPL dependency.
>>>
>>> 1) jwebunit dependency is GPL
>>> The server module depends on
>>>
>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>>
>>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>>
>> Well isn't jwebunit a test framework, in which case, (and assuming there
>> are no dependencies on it in the production-ready codebase of esme) do
>> we really care that it's GPL or not? ...
>
> I see your point, one could argue that people don't need jwebunit to
> *run* ESME, they only need it to run the tests when building it.
>
> Still, the code that is distributed contains imports of jwebunit, so I
> think that's stretching the concept too far.
>
>>... (Note an exception to the (L)GPL
>> policy was recently granted for build dependencies, so I think it's might
>> be possible to extend that to test deps.)...
>
> Might be possible, but getting rid of that jwwebunit dependency would
> be much cleaner IMO. I haven't checked how much work that represents,
> but according to http://jwebunit.sourceforge.net/ that's "just" a
> wrapper on top of HtmlUnit which has an Apache license, so using
> HtmlUnit instead might not be too hard.
>
> -Bertrand
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Ethan Jewett <es...@gmail.com>.
Thanks Joe and Bertrand. Point taken. Better to be safe and respectful
than sorry.
I'll try to spend some time looking at it. On the surface, it looks
like it's imported into my API2 tests but is not really used. I'll try
removing it from the tests in general, not just API2.
It looks like it really is used in the JettySetup.scala file. I can
try removing it from there as well, but I'm less optimistic that tests
will still run. Who originally created this setup? David?
Ethan
On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
>> ----- Original Message ----
>>
>>> From: Bertrand Delacretaz <bd...@apache.org>
>>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>>> GPL dependency.
>>>
>>> 1) jwebunit dependency is GPL
>>> The server module depends on
>>>
>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>>
>>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>>
>> Well isn't jwebunit a test framework, in which case, (and assuming there
>> are no dependencies on it in the production-ready codebase of esme) do
>> we really care that it's GPL or not? ...
>
> I see your point, one could argue that people don't need jwebunit to
> *run* ESME, they only need it to run the tests when building it.
>
> Still, the code that is distributed contains imports of jwebunit, so I
> think that's stretching the concept too far.
>
>>... (Note an exception to the (L)GPL
>> policy was recently granted for build dependencies, so I think it's might
>> be possible to extend that to test deps.)...
>
> Might be possible, but getting rid of that jwwebunit dependency would
> be much cleaner IMO. I haven't checked how much work that represents,
> but according to http://jwebunit.sourceforge.net/ that's "just" a
> wrapper on top of HtmlUnit which has an Apache license, so using
> HtmlUnit instead might not be too hard.
>
> -Bertrand
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Ethan Jewett <es...@gmail.com>.
Thanks Joe and Bertrand. Point taken. Better to be safe and respectful
than sorry. I'll continue the discussion on the ESME list alone.
Ethan
On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
>> ----- Original Message ----
>>
>>> From: Bertrand Delacretaz <bd...@apache.org>
>>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>>> GPL dependency.
>>>
>>> 1) jwebunit dependency is GPL
>>> The server module depends on
>>>
>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>>
>>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>>
>> Well isn't jwebunit a test framework, in which case, (and assuming there
>> are no dependencies on it in the production-ready codebase of esme) do
>> we really care that it's GPL or not? ...
>
> I see your point, one could argue that people don't need jwebunit to
> *run* ESME, they only need it to run the tests when building it.
>
> Still, the code that is distributed contains imports of jwebunit, so I
> think that's stretching the concept too far.
>
>>... (Note an exception to the (L)GPL
>> policy was recently granted for build dependencies, so I think it's might
>> be possible to extend that to test deps.)...
>
> Might be possible, but getting rid of that jwwebunit dependency would
> be much cleaner IMO. I haven't checked how much work that represents,
> but according to http://jwebunit.sourceforge.net/ that's "just" a
> wrapper on top of HtmlUnit which has an Apache license, so using
> HtmlUnit instead might not be too hard.
>
> -Bertrand
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
> ----- Original Message ----
>
>> From: Bertrand Delacretaz <bd...@apache.org>
>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>> GPL dependency.
>>
>> 1) jwebunit dependency is GPL
>> The server module depends on
>>
>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>
>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>
> Well isn't jwebunit a test framework, in which case, (and assuming there
> are no dependencies on it in the production-ready codebase of esme) do
> we really care that it's GPL or not? ...
I see your point, one could argue that people don't need jwebunit to
*run* ESME, they only need it to run the tests when building it.
Still, the code that is distributed contains imports of jwebunit, so I
think that's stretching the concept too far.
>... (Note an exception to the (L)GPL
> policy was recently granted for build dependencies, so I think it's might
> be possible to extend that to test deps.)...
Might be possible, but getting rid of that jwwebunit dependency would
be much cleaner IMO. I haven't checked how much work that represents,
but according to http://jwebunit.sourceforge.net/ that's "just" a
wrapper on top of HtmlUnit which has an Apache license, so using
HtmlUnit instead might not be too hard.
-Bertrand
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <jo...@yahoo.com> wrote:
> ----- Original Message ----
>
>> From: Bertrand Delacretaz <bd...@apache.org>
>> ...Unfortunately I'm -1 on the release, I have a few issues including a
>> GPL dependency.
>>
>> 1) jwebunit dependency is GPL
>> The server module depends on
>>
>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>
>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>
> Well isn't jwebunit a test framework, in which case, (and assuming there
> are no dependencies on it in the production-ready codebase of esme) do
> we really care that it's GPL or not? ...
I see your point, one could argue that people don't need jwebunit to
*run* ESME, they only need it to run the tests when building it.
Still, the code that is distributed contains imports of jwebunit, so I
think that's stretching the concept too far.
>... (Note an exception to the (L)GPL
> policy was recently granted for build dependencies, so I think it's might
> be possible to extend that to test deps.)...
Might be possible, but getting rid of that jwwebunit dependency would
be much cleaner IMO. I haven't checked how much work that represents,
but according to http://jwebunit.sourceforge.net/ that's "just" a
wrapper on top of HtmlUnit which has an Apache license, so using
HtmlUnit instead might not be too hard.
-Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Joe Schaefer <jo...@yahoo.com>.
----- Original Message ----
> From: Bertrand Delacretaz <bd...@apache.org>
> To: esme-dev@incubator.apache.org
> Cc: general@incubator.apache.org
> Sent: Tue, February 16, 2010 11:28:22 AM
> Subject: Re: [VOTE] Approve the release of apache-esme-incubating-1.0
>
> Hi,
>
> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch wrote:
> > ...The candidate can be found at:
> > http://people.apache.org/~rhirsch/esme/
>
> Unfortunately I'm -1 on the release, I have a few issues including a
> GPL dependency.
>
> 1) jwebunit dependency is GPL
> The server module depends on
>
> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>
> which according to http://jwebunit.sourceforge.net/license.html is GPL.
Well isn't jwebunit a test framework, in which case, (and assuming there
are no dependencies on it in the production-ready codebase of esme) do
we really care that it's GPL or not? (Note an exception to the (L)GPL
policy was recently granted for build dependencies, so I think it's might
be possible to extend that to test deps.)
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
On Wed, Feb 17, 2010 at 10:16 AM, Bertrand Delacretaz <
bdelacretaz@apache.org> wrote:
> Hi Dick,
>
> On Wed, Feb 17, 2010 at 10:10 AM, Richard Hirsch <hi...@gmail.com>
> wrote:
> > On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
> bdelacretaz@apache.org
> >> wrote:
> >> ...5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> >> should not have that. You could have created the release using svn
> >> export of
> >>
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
> >> to avoid that.
> >>
> >
> > How do you create the release without the SVN info? I tried with SVN
> export
> > via SVNTortoise and still got the SVN info....
>
It works with TortoiseSVN as well when you do an export based on a tag
> I'm not familiar with tortoise, but at the command line this works:
>
> svn export
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
>
> gets you the contents of that svn tag, without any .svn metadata folders.
>
> -Bertrand
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Dick,
On Wed, Feb 17, 2010 at 10:10 AM, Richard Hirsch <hi...@gmail.com> wrote:
> On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <bdelacretaz@apache.org
>> wrote:
>> ...5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
>> should not have that. You could have created the release using svn
>> export of
>> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
>> to avoid that.
>>
>
> How do you create the release without the SVN info? I tried with SVN export
> via SVNTortoise and still got the SVN info....
I'm not familiar with tortoise, but at the command line this works:
svn export http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
gets you the contents of that svn tag, without any .svn metadata folders.
-Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> Hi,
>
> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com>
> wrote:
> > ...The candidate can be found at:
> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
>
> Unfortunately I'm -1 on the release, I have a few issues including a
> GPL dependency.
>
> 1) jwebunit dependency is GPL
> The server module depends on
>
> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>
> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>
> 2) The sha1 digest does not match, did I do something wrong?
>
> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> a9ec8d95266d5944d493392a06eb1651c03222f1
>
> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
> 64B3B76C 747BA64A FFC9A836 EDAB8D86
> 4E0735CC AA29ACA9 07767C58 D1C0FEDA
> CA7E73A3 ADA3944D 464314B2 4BE0E476
>
> 3) mvn dependency:analyze of the server module shows lots of unused
> declared dependencies, those should be cleaned up, especially
> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
> either GPL or CDDL license. Not sure which parts of OpenDMK are which
> license, but as it's unused better remove it.
>
> 4) When trying to build esme-java-client with "mvn clean install" I
> get "Embedded error: Error while executing the external compiler" if
> JAVA_HOME is not set.
>
> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> should not have that. You could have created the release using svn
> export of
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
> to avoid that.
>
How do you create the release without the SVN info? I tried with SVN export
via SVNTortoise and still got the SVN info.
>
> 6) I couldn't find license information for the
> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> ok?
>
Here are the current unknowns:
Unnamed - com.twitter:json:jar:1.1, Unnamed - com.twitter:stats:jar:1.3,
Unnamed - com.twitter:xrayspecs:pom:1.0.4, Unnamed -
javax.servlet:servlet-api:jar:2.5, Unnamed - net.lag:configgy:jar:1.4
configgy : http://github.com/robey/configgy with a Apache 2.0 license
for the com.twitter.* jars there is no license information available and it
looks like the developer has created a new git project with Apache 2.0
license:
http://github.com/robey/ostrich. We'll move to it next release.
>
> Sorry that I didn't have time to look at that during the ESME podling vote.
>
> Apart from the GPL dependency the release preparation looks mostly ok,
> rat reports are good, license/notice are provided, etc.
>
> -Bertrand
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Daniel Kulp <dk...@apache.org>.
On Tue February 16 2010 2:56:49 pm Richard Hirsch wrote:
> I'll probably start with a "mvn dependency:analyze" to see what I can toss.
> I've already found some tests that will have to rewritten.
>
> I'm hoping that once I get rid of the unneeded dependencies, I can do a
> "mvn site" to get the licenses.
>
> I've got to ask... what is a "version 3 pom"?
Don't really know. :-) Probably something from maven1 days.
When I ran mvn site, it complained that a couple of the poms were not a
version 4 pom. Example is:
~/.m2/repository/commons-httpclient/commons-httpclient/3.0.1/commons-
httpclient-3.0.1.pom
If you look at that, it says version 3. If you could upgrade to httpclient
3.1, then you get a version 4 pom which is the norm for Maven 2.
Dan
>
> D.
>
> On Tue, Feb 16, 2010 at 8:48 PM, Daniel Kulp <dk...@apache.org> wrote:
> > On Tue February 16 2010 2:39:19 pm Richard Hirsch wrote:
> > > Taking this off general ML and back to esme-dev
> > >
> > > Is there any particular way/location to document what the maven
> > > dependencies are and their respective licenses. For example, "specs" (
> > > http://code.google.com/p/specs/) has a MIT License do I add that to our
> > > existing MIT-LICENSE.txt
> >
> > Normally, you could run "mvn site" and the dependency page of the
> > generated site would show the licenses that it found in the poms.
> >
> > However, this doesn't seem to work with ESME as the dependencies pull in
> > invalid poms that seem to break it. (more specifically, version 3 poms)
> >
> > I don't know if you started going through the deps and updating to newer
> > versions if that would help or not.
> >
> > Dan
> >
> > > We are going to have to change code based on the removal of GPL-based
> > > dependencies. I'll see what the impact is tomorrow when I try and clean
> >
> > up
> >
> > > our pom.xml
> > >
> > > All-in-all, Bertrand "-1" is a good thing. I would have loved to have
> > > gotten the release through this week but having a clean RC is more
> > > important. It will be the basis for all our future releases.
> > >
> > > D.
> > >
> > > On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch
> >
> > <hi...@gmail.com>wrote:
> > > > Like I said - I'm seeing this first release as a learning experience
> > > > (grin, grin)
> > > >
> > > > On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
> > > >
> > > > bdelacretaz@apache.org> wrote:
> > > >> Hi,
> > > >>
> > > >> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <
> >
> > hirsch.dick@gmail.com>
> >
> > > >> wrote:
> > > >> > ...The candidate can be found at:
> > > >> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/
> > > >> > %7Erhirsch/esme/>
> >
> > <http://people.apache.org/%7Er
> >
> > > >> > hirsch/esme/>
> > > >>
> > > >> Unfortunately I'm -1 on the release, I have a few issues including a
> > > >> GPL dependency.
> > > >>
> > > >> 1) jwebunit dependency is GPL
> > > >> The server module depends on
> > > >>
> > > >> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
> > > >>
> > > >> which according to http://jwebunit.sourceforge.net/license.html is
> >
> > GPL.
> >
> > > > I didn't check any maven dependencies, because they weren't part of
> >
> > SVN.
> >
> > > >> 2) The sha1 digest does not match, did I do something wrong?
> > > >>
> > > >> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> > > >> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> > > >> a9ec8d95266d5944d493392a06eb1651c03222f1
> > > >>
> > > >> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> > > >> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516
> > > >> C2448CB6
> > > >>
> > > >> 64B3B76C 747BA64A FFC9A836
> > > >> EDAB8D86 4E0735CC AA29ACA9
> > > >> 07767C58 D1C0FEDA CA7E73A3
> > > >> ADA3944D 464314B2 4BE0E476
> > > >>
> > > >> I'm assuming I did something wrong. It was my first attempt at
> >
> > signing.
> >
> > > > I'll take another shot at it.
> > > >
> > > >> 3) mvn dependency:analyze of the server module shows lots of unused
> > > >> declared dependencies, those should be cleaned up, especially
> > > >> openDMK:jdmkrt:jar which according to
> > > >> https://opendmk.dev.java.net/is either GPL or CDDL license. Not
> > > >> sure which parts of OpenDMK are which license, but as it's unused
> > > >> better remove it.
> > > >
> > > > OK - I'll take a look at it.
> > > >
> > > >> 4) When trying to build esme-java-client with "mvn clean install" I
> > > >> get "Embedded error: Error while executing the external compiler" if
> > > >> JAVA_HOME is not set.
> > > >
> > > > How can you deal with this via maven? Is this an ESME problem or a
> >
> > maven
> >
> > > > problem?
> > > >
> > > >> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> > > >> should not have that. You could have created the release using svn
> > > >> export of
> >
> > http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incu
> >
> > > >> bating/ to avoid that.
> > > >
> > > > OK. Didn't know that.
> > > >
> > > >> 6) I couldn't find license information for the
> > > >> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> > > >> ok?
> > > >
> > > > Don't know - I'll have to check. This was from our JMX interface .
> > > >
> > > >> Sorry that I didn't have time to look at that during the ESME
> > > >> podling vote.
> > > >>
> > > >> Apart from the GPL dependency the release preparation looks mostly
> > > >> ok, rat reports are good, license/notice are provided, etc.
> > > >>
> > > >> -Bertrand
> >
> > --
> > Daniel Kulp
> > dkulp@apache.org
> > http://www.dankulp.com/blog
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Feb 16, 2010 at 11:04 PM, Ethan Jewett <es...@gmail.com> wrote:
> Pre-emptive question on the GPL license issue for dependencies:
>
> Since we aren't distributing a WAR, and hence aren't distributing the
> GPL code, is this a problem for this release?...
Apache releases consist of source code, binaries are provided as
convenience only - so a war file doesn't make a difference. Requiring
GPL dependencies for an Apache release to work is not ok.
See http://apache.org/dev/release.html.
-Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Joe Schaefer <jo...@yahoo.com>.
----- Original Message ----
> From: Ethan Jewett <es...@gmail.com>
> To: esme-dev@incubator.apache.org
> Sent: Tue, February 16, 2010 5:04:43 PM
> Subject: Re: [VOTE] Approve the release of apache-esme-incubating-1.0
>
> Pre-emptive question on the GPL license issue for dependencies:
>
> Since we aren't distributing a WAR, and hence aren't distributing the
> GPL code, is this a problem for this release?
It is if there are core dependencies on GPL code. According to GPL
purists a dependency makes your work a derivative and thus subject
to the GPL. Reasonable people disagree here and there about this topic,
but at Apache we tend to respect the wishes of the copyright author even
if we don't necessarily agree with their interpretation of the law.
If it's just a dependency based on a test suite you are distributing, consider
not distributing the test suite.
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Ethan Jewett <es...@gmail.com>.
Pre-emptive question on the GPL license issue for dependencies:
Since we aren't distributing a WAR, and hence aren't distributing the
GPL code, is this a problem for this release?
I think that in the future we will want to distribute a WAR, in which
case we clearly must get rid of the GPL dependencies, but since we're
not doing it this time around, will this stop the release?
Also, sorry I'm not really contributing to this release. I'm in the
middle of a month-long go-live at work, so it could be a while until
I'm contributing actively again. For now I'll stick with building and
testing Dick's releases, watching Hudson, and gardening Jira :-)
Thanks,
Ethan
On Tue, Feb 16, 2010 at 2:56 PM, Richard Hirsch <hi...@gmail.com> wrote:
> I'll probably start with a "mvn dependency:analyze" to see what I can toss.
> I've already found some tests that will have to rewritten.
>
> I'm hoping that once I get rid of the unneeded dependencies, I can do a "mvn
> site" to get the licenses.
>
> I've got to ask... what is a "version 3 pom"?
>
> D.
>
>
>
> On Tue, Feb 16, 2010 at 8:48 PM, Daniel Kulp <dk...@apache.org> wrote:
>
>> On Tue February 16 2010 2:39:19 pm Richard Hirsch wrote:
>> > Taking this off general ML and back to esme-dev
>> >
>> > Is there any particular way/location to document what the maven
>> > dependencies are and their respective licenses. For example, "specs" (
>> > http://code.google.com/p/specs/) has a MIT License do I add that to our
>> > existing MIT-LICENSE.txt
>>
>> Normally, you could run "mvn site" and the dependency page of the generated
>> site would show the licenses that it found in the poms.
>>
>> However, this doesn't seem to work with ESME as the dependencies pull in
>> invalid poms that seem to break it. (more specifically, version 3 poms)
>>
>> I don't know if you started going through the deps and updating to newer
>> versions if that would help or not.
>>
>> Dan
>>
>>
>>
>> > We are going to have to change code based on the removal of GPL-based
>> > dependencies. I'll see what the impact is tomorrow when I try and clean
>> up
>> > our pom.xml
>> >
>> > All-in-all, Bertrand "-1" is a good thing. I would have loved to have
>> > gotten the release through this week but having a clean RC is more
>> > important. It will be the basis for all our future releases.
>> >
>> > D.
>> >
>> > On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch
>> <hi...@gmail.com>wrote:
>> > > Like I said - I'm seeing this first release as a learning experience
>> > > (grin, grin)
>> > >
>> > > On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
>> > >
>> > > bdelacretaz@apache.org> wrote:
>> > >> Hi,
>> > >>
>> > >> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <
>> hirsch.dick@gmail.com>
>> > >>
>> > >> wrote:
>> > >> > ...The candidate can be found at:
>> > >> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
>> <http://people.apache.org/%7Er
>> > >> > hirsch/esme/>
>> > >>
>> > >> Unfortunately I'm -1 on the release, I have a few issues including a
>> > >> GPL dependency.
>> > >>
>> > >> 1) jwebunit dependency is GPL
>> > >> The server module depends on
>> > >>
>> > >> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>> > >>
>> > >> which according to http://jwebunit.sourceforge.net/license.html is
>> GPL.
>> > >
>> > > I didn't check any maven dependencies, because they weren't part of
>> SVN.
>> > >
>> > >> 2) The sha1 digest does not match, did I do something wrong?
>> > >>
>> > >> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
>> > >> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
>> > >> a9ec8d95266d5944d493392a06eb1651c03222f1
>> > >>
>> > >> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
>> > >> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516
>> > >> C2448CB6
>> > >>
>> > >> 64B3B76C 747BA64A FFC9A836
>> > >> EDAB8D86 4E0735CC AA29ACA9
>> > >> 07767C58 D1C0FEDA CA7E73A3
>> > >> ADA3944D 464314B2 4BE0E476
>> > >>
>> > >> I'm assuming I did something wrong. It was my first attempt at
>> signing.
>> > >
>> > > I'll take another shot at it.
>> > >
>> > >> 3) mvn dependency:analyze of the server module shows lots of unused
>> > >> declared dependencies, those should be cleaned up, especially
>> > >> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/is
>> > >> either GPL or CDDL license. Not sure which parts of OpenDMK are which
>> > >> license, but as it's unused better remove it.
>> > >
>> > > OK - I'll take a look at it.
>> > >
>> > >> 4) When trying to build esme-java-client with "mvn clean install" I
>> > >> get "Embedded error: Error while executing the external compiler" if
>> > >> JAVA_HOME is not set.
>> > >
>> > > How can you deal with this via maven? Is this an ESME problem or a
>> maven
>> > > problem?
>> > >
>> > >> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
>> > >> should not have that. You could have created the release using svn
>> > >> export of
>> > >>
>> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incu
>> > >> bating/ to avoid that.
>> > >
>> > > OK. Didn't know that.
>> > >
>> > >> 6) I couldn't find license information for the
>> > >> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
>> > >> ok?
>> > >
>> > > Don't know - I'll have to check. This was from our JMX interface .
>> > >
>> > >> Sorry that I didn't have time to look at that during the ESME podling
>> > >> vote.
>> > >>
>> > >> Apart from the GPL dependency the release preparation looks mostly ok,
>> > >> rat reports are good, license/notice are provided, etc.
>> > >>
>> > >> -Bertrand
>>
>> --
>> Daniel Kulp
>> dkulp@apache.org
>> http://www.dankulp.com/blog
>>
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Tue, Feb 16, 2010 at 8:56 PM, Richard Hirsch <hi...@gmail.com> wrote:
> I'll probably start with a "mvn dependency:analyze" to see what I can toss.
> I've already found some tests that will have to rewritten.
>
> I'm hoping that once I get rid of the unneeded dependencies, I can do a "mvn
> site" to get the licenses....
In theory yes, but that info is often not reliable as people don't
include up to date license info in their poms.
I generally use mvn dependency:tree to see all dependencies and look
for the ones that are not well-known.
What's important for ESME at this stage I think, is to realize that
when adding new dependencies people should make sure their license is
ok (including transitive dependencies shown by mvn dependency:tree),
and update the LICENSE/NOTICE files when needed.
-Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
I'll probably start with a "mvn dependency:analyze" to see what I can toss.
I've already found some tests that will have to rewritten.
I'm hoping that once I get rid of the unneeded dependencies, I can do a "mvn
site" to get the licenses.
I've got to ask... what is a "version 3 pom"?
D.
On Tue, Feb 16, 2010 at 8:48 PM, Daniel Kulp <dk...@apache.org> wrote:
> On Tue February 16 2010 2:39:19 pm Richard Hirsch wrote:
> > Taking this off general ML and back to esme-dev
> >
> > Is there any particular way/location to document what the maven
> > dependencies are and their respective licenses. For example, "specs" (
> > http://code.google.com/p/specs/) has a MIT License do I add that to our
> > existing MIT-LICENSE.txt
>
> Normally, you could run "mvn site" and the dependency page of the generated
> site would show the licenses that it found in the poms.
>
> However, this doesn't seem to work with ESME as the dependencies pull in
> invalid poms that seem to break it. (more specifically, version 3 poms)
>
> I don't know if you started going through the deps and updating to newer
> versions if that would help or not.
>
> Dan
>
>
>
> > We are going to have to change code based on the removal of GPL-based
> > dependencies. I'll see what the impact is tomorrow when I try and clean
> up
> > our pom.xml
> >
> > All-in-all, Bertrand "-1" is a good thing. I would have loved to have
> > gotten the release through this week but having a clean RC is more
> > important. It will be the basis for all our future releases.
> >
> > D.
> >
> > On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch
> <hi...@gmail.com>wrote:
> > > Like I said - I'm seeing this first release as a learning experience
> > > (grin, grin)
> > >
> > > On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
> > >
> > > bdelacretaz@apache.org> wrote:
> > >> Hi,
> > >>
> > >> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <
> hirsch.dick@gmail.com>
> > >>
> > >> wrote:
> > >> > ...The candidate can be found at:
> > >> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
> <http://people.apache.org/%7Er
> > >> > hirsch/esme/>
> > >>
> > >> Unfortunately I'm -1 on the release, I have a few issues including a
> > >> GPL dependency.
> > >>
> > >> 1) jwebunit dependency is GPL
> > >> The server module depends on
> > >>
> > >> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
> > >>
> > >> which according to http://jwebunit.sourceforge.net/license.html is
> GPL.
> > >
> > > I didn't check any maven dependencies, because they weren't part of
> SVN.
> > >
> > >> 2) The sha1 digest does not match, did I do something wrong?
> > >>
> > >> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> > >> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> > >> a9ec8d95266d5944d493392a06eb1651c03222f1
> > >>
> > >> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> > >> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516
> > >> C2448CB6
> > >>
> > >> 64B3B76C 747BA64A FFC9A836
> > >> EDAB8D86 4E0735CC AA29ACA9
> > >> 07767C58 D1C0FEDA CA7E73A3
> > >> ADA3944D 464314B2 4BE0E476
> > >>
> > >> I'm assuming I did something wrong. It was my first attempt at
> signing.
> > >
> > > I'll take another shot at it.
> > >
> > >> 3) mvn dependency:analyze of the server module shows lots of unused
> > >> declared dependencies, those should be cleaned up, especially
> > >> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/is
> > >> either GPL or CDDL license. Not sure which parts of OpenDMK are which
> > >> license, but as it's unused better remove it.
> > >
> > > OK - I'll take a look at it.
> > >
> > >> 4) When trying to build esme-java-client with "mvn clean install" I
> > >> get "Embedded error: Error while executing the external compiler" if
> > >> JAVA_HOME is not set.
> > >
> > > How can you deal with this via maven? Is this an ESME problem or a
> maven
> > > problem?
> > >
> > >> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> > >> should not have that. You could have created the release using svn
> > >> export of
> > >>
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incu
> > >> bating/ to avoid that.
> > >
> > > OK. Didn't know that.
> > >
> > >> 6) I couldn't find license information for the
> > >> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> > >> ok?
> > >
> > > Don't know - I'll have to check. This was from our JMX interface .
> > >
> > >> Sorry that I didn't have time to look at that during the ESME podling
> > >> vote.
> > >>
> > >> Apart from the GPL dependency the release preparation looks mostly ok,
> > >> rat reports are good, license/notice are provided, etc.
> > >>
> > >> -Bertrand
>
> --
> Daniel Kulp
> dkulp@apache.org
> http://www.dankulp.com/blog
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Daniel Kulp <dk...@apache.org>.
On Tue February 16 2010 2:39:19 pm Richard Hirsch wrote:
> Taking this off general ML and back to esme-dev
>
> Is there any particular way/location to document what the maven
> dependencies are and their respective licenses. For example, "specs" (
> http://code.google.com/p/specs/) has a MIT License do I add that to our
> existing MIT-LICENSE.txt
Normally, you could run "mvn site" and the dependency page of the generated
site would show the licenses that it found in the poms.
However, this doesn't seem to work with ESME as the dependencies pull in
invalid poms that seem to break it. (more specifically, version 3 poms)
I don't know if you started going through the deps and updating to newer
versions if that would help or not.
Dan
> We are going to have to change code based on the removal of GPL-based
> dependencies. I'll see what the impact is tomorrow when I try and clean up
> our pom.xml
>
> All-in-all, Bertrand "-1" is a good thing. I would have loved to have
> gotten the release through this week but having a clean RC is more
> important. It will be the basis for all our future releases.
>
> D.
>
> On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch
<hi...@gmail.com>wrote:
> > Like I said - I'm seeing this first release as a learning experience
> > (grin, grin)
> >
> > On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
> >
> > bdelacretaz@apache.org> wrote:
> >> Hi,
> >>
> >> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com>
> >>
> >> wrote:
> >> > ...The candidate can be found at:
> >> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Er
> >> > hirsch/esme/>
> >>
> >> Unfortunately I'm -1 on the release, I have a few issues including a
> >> GPL dependency.
> >>
> >> 1) jwebunit dependency is GPL
> >> The server module depends on
> >>
> >> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
> >>
> >> which according to http://jwebunit.sourceforge.net/license.html is GPL.
> >
> > I didn't check any maven dependencies, because they weren't part of SVN.
> >
> >> 2) The sha1 digest does not match, did I do something wrong?
> >>
> >> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> >> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> >> a9ec8d95266d5944d493392a06eb1651c03222f1
> >>
> >> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> >> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516
> >> C2448CB6
> >>
> >> 64B3B76C 747BA64A FFC9A836
> >> EDAB8D86 4E0735CC AA29ACA9
> >> 07767C58 D1C0FEDA CA7E73A3
> >> ADA3944D 464314B2 4BE0E476
> >>
> >> I'm assuming I did something wrong. It was my first attempt at signing.
> >
> > I'll take another shot at it.
> >
> >> 3) mvn dependency:analyze of the server module shows lots of unused
> >> declared dependencies, those should be cleaned up, especially
> >> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
> >> either GPL or CDDL license. Not sure which parts of OpenDMK are which
> >> license, but as it's unused better remove it.
> >
> > OK - I'll take a look at it.
> >
> >> 4) When trying to build esme-java-client with "mvn clean install" I
> >> get "Embedded error: Error while executing the external compiler" if
> >> JAVA_HOME is not set.
> >
> > How can you deal with this via maven? Is this an ESME problem or a maven
> > problem?
> >
> >> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> >> should not have that. You could have created the release using svn
> >> export of
> >> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incu
> >> bating/ to avoid that.
> >
> > OK. Didn't know that.
> >
> >> 6) I couldn't find license information for the
> >> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> >> ok?
> >
> > Don't know - I'll have to check. This was from our JMX interface .
> >
> >> Sorry that I didn't have time to look at that during the ESME podling
> >> vote.
> >>
> >> Apart from the GPL dependency the release preparation looks mostly ok,
> >> rat reports are good, license/notice are provided, etc.
> >>
> >> -Bertrand
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
Taking this off general ML and back to esme-dev
Is there any particular way/location to document what the maven dependencies
are and their respective licenses. For example, "specs" (
http://code.google.com/p/specs/) has a MIT License do I add that to our
existing MIT-LICENSE.txt
We are going to have to change code based on the removal of GPL-based
dependencies. I'll see what the impact is tomorrow when I try and clean up
our pom.xml
All-in-all, Bertrand "-1" is a good thing. I would have loved to have gotten
the release through this week but having a clean RC is more important. It
will be the basis for all our future releases.
D.
On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch <hi...@gmail.com>wrote:
> Like I said - I'm seeing this first release as a learning experience (grin,
> grin)
>
> On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
> bdelacretaz@apache.org> wrote:
>
>> Hi,
>>
>> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com>
>> wrote:
>> > ...The candidate can be found at:
>> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
>>
>> Unfortunately I'm -1 on the release, I have a few issues including a
>> GPL dependency.
>>
>> 1) jwebunit dependency is GPL
>> The server module depends on
>>
>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>>
>> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>>
>
> I didn't check any maven dependencies, because they weren't part of SVN.
>
>>
>> 2) The sha1 digest does not match, did I do something wrong?
>>
>> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
>> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
>> a9ec8d95266d5944d493392a06eb1651c03222f1
>>
>> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
>> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
>> 64B3B76C 747BA64A FFC9A836 EDAB8D86
>> 4E0735CC AA29ACA9 07767C58 D1C0FEDA
>> CA7E73A3 ADA3944D 464314B2 4BE0E476
>>
>> I'm assuming I did something wrong. It was my first attempt at signing.
> I'll take another shot at it.
>
>
>
>> 3) mvn dependency:analyze of the server module shows lots of unused
>> declared dependencies, those should be cleaned up, especially
>> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
>> either GPL or CDDL license. Not sure which parts of OpenDMK are which
>> license, but as it's unused better remove it.
>>
>
> OK - I'll take a look at it.
>
>
>>
>> 4) When trying to build esme-java-client with "mvn clean install" I
>> get "Embedded error: Error while executing the external compiler" if
>> JAVA_HOME is not set.
>>
>
> How can you deal with this via maven? Is this an ESME problem or a maven
> problem?
>
>
>>
>> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
>> should not have that. You could have created the release using svn
>> export of
>> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
>> to avoid that.
>>
>
> OK. Didn't know that.
>
>>
>> 6) I couldn't find license information for the
>> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
>> ok?
>>
>
> Don't know - I'll have to check. This was from our JMX interface .
>
>
>>
>> Sorry that I didn't have time to look at that during the ESME podling
>> vote.
>>
>> Apart from the GPL dependency the release preparation looks mostly ok,
>> rat reports are good, license/notice are provided, etc.
>>
>> -Bertrand
>>
>
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Anne Kathrine Petterøe <yo...@gmail.com>.
I am beginning to understand why it is so important to go through a release process a couple of times before graduation ;-)
On 17. feb. 2010, at 10.30, Richard Hirsch wrote:
> Don't forget that ESME currently only works with JDK 1.6 which might be your
> problem.
>
> There is a note about this in the README.
>
> D.
>
> On Wed, Feb 17, 2010 at 9:18 AM, Bertrand Delacretaz <bdelacretaz@apache.org
>> wrote:
>
>> Hi,
>>
>> On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch <hi...@gmail.com>
>> wrote:
>>> On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
>> bdelacretaz@apache.org
>>>> wrote:
>>
>>>> ... 4) When trying to build esme-java-client with "mvn clean install" I
>>>> get "Embedded error: Error while executing the external compiler" if
>>>> JAVA_HOME is not set.
>>>>
>>>
>>> How can you deal with this via maven? Is this an ESME problem or a maven
>>> problem?...
>>
>> Looks just like a weird maven-compiler-plugin setup in
>> esme-java-client/pom.xml, the patch below fixes it. I get test
>> failures then, but that's another story.
>>
>> -Bertrand
>>
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 910855)
>> +++ pom.xml (working copy)
>> @@ -46,26 +46,6 @@
>> <configuration>
>> <verbose>true</verbose>
>> <fork>true</fork>
>> - <executable>${JAVA_HOME}/bin/javac</executable>
>> - <!--
>> - define the JAVA_1_4_HOME property in .m2/settings.xml for
>> portability, e.g.:
>> - <settings>
>> - [...]
>> - <profiles>
>> - [...]
>> - <profile>
>> - <id>compiler</id>
>> - <properties>
>> - <JAVA_1_4_HOME>C:\Program
>> Files\Java\j2sdk1.4.2_09</JAVA_1_4_HOME>
>> - </properties>
>> - </profile>
>> - </profiles>
>> - [...]
>> - <activeProfiles>
>> - <activeProfile>compiler</activeProfile>
>> - </activeProfiles>
>> - </settings>
>> - -->
>> <compilerVersion>1.4</compilerVersion>
>> </configuration>
>> </plugin>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
Don't forget that ESME currently only works with JDK 1.6 which might be your
problem.
There is a note about this in the README.
D.
On Wed, Feb 17, 2010 at 9:18 AM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> Hi,
>
> On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch <hi...@gmail.com>
> wrote:
> > On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <
> bdelacretaz@apache.org
> >> wrote:
>
> >>... 4) When trying to build esme-java-client with "mvn clean install" I
> >> get "Embedded error: Error while executing the external compiler" if
> >> JAVA_HOME is not set.
> >>
> >
> > How can you deal with this via maven? Is this an ESME problem or a maven
> > problem?...
>
> Looks just like a weird maven-compiler-plugin setup in
> esme-java-client/pom.xml, the patch below fixes it. I get test
> failures then, but that's another story.
>
> -Bertrand
>
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 910855)
> +++ pom.xml (working copy)
> @@ -46,26 +46,6 @@
> <configuration>
> <verbose>true</verbose>
> <fork>true</fork>
> - <executable>${JAVA_HOME}/bin/javac</executable>
> - <!--
> - define the JAVA_1_4_HOME property in .m2/settings.xml for
> portability, e.g.:
> - <settings>
> - [...]
> - <profiles>
> - [...]
> - <profile>
> - <id>compiler</id>
> - <properties>
> - <JAVA_1_4_HOME>C:\Program
> Files\Java\j2sdk1.4.2_09</JAVA_1_4_HOME>
> - </properties>
> - </profile>
> - </profiles>
> - [...]
> - <activeProfiles>
> - <activeProfile>compiler</activeProfile>
> - </activeProfiles>
> - </settings>
> - -->
> <compilerVersion>1.4</compilerVersion>
> </configuration>
> </plugin>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch <hi...@gmail.com> wrote:
> On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <bdelacretaz@apache.org
>> wrote:
>>... 4) When trying to build esme-java-client with "mvn clean install" I
>> get "Embedded error: Error while executing the external compiler" if
>> JAVA_HOME is not set.
>>
>
> How can you deal with this via maven? Is this an ESME problem or a maven
> problem?...
Looks just like a weird maven-compiler-plugin setup in
esme-java-client/pom.xml, the patch below fixes it. I get test
failures then, but that's another story.
-Bertrand
Index: pom.xml
===================================================================
--- pom.xml (revision 910855)
+++ pom.xml (working copy)
@@ -46,26 +46,6 @@
<configuration>
<verbose>true</verbose>
<fork>true</fork>
- <executable>${JAVA_HOME}/bin/javac</executable>
- <!--
- define the JAVA_1_4_HOME property in .m2/settings.xml for
portability, e.g.:
- <settings>
- [...]
- <profiles>
- [...]
- <profile>
- <id>compiler</id>
- <properties>
- <JAVA_1_4_HOME>C:\Program Files\Java\j2sdk1.4.2_09</JAVA_1_4_HOME>
- </properties>
- </profile>
- </profiles>
- [...]
- <activeProfiles>
- <activeProfile>compiler</activeProfile>
- </activeProfiles>
- </settings>
- -->
<compilerVersion>1.4</compilerVersion>
</configuration>
</plugin>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Tue, Feb 16, 2010 at 8:12 PM, Richard Hirsch <hi...@gmail.com> wrote:
> On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <bdelacretaz@apache.org
>> wrote:
>>... 4) When trying to build esme-java-client with "mvn clean install" I
>> get "Embedded error: Error while executing the external compiler" if
>> JAVA_HOME is not set.
>>
>
> How can you deal with this via maven? Is this an ESME problem or a maven
> problem?...
Looks just like a weird maven-compiler-plugin setup in
esme-java-client/pom.xml, the patch below fixes it. I get test
failures then, but that's another story.
-Bertrand
Index: pom.xml
===================================================================
--- pom.xml (revision 910855)
+++ pom.xml (working copy)
@@ -46,26 +46,6 @@
<configuration>
<verbose>true</verbose>
<fork>true</fork>
- <executable>${JAVA_HOME}/bin/javac</executable>
- <!--
- define the JAVA_1_4_HOME property in .m2/settings.xml for
portability, e.g.:
- <settings>
- [...]
- <profiles>
- [...]
- <profile>
- <id>compiler</id>
- <properties>
- <JAVA_1_4_HOME>C:\Program Files\Java\j2sdk1.4.2_09</JAVA_1_4_HOME>
- </properties>
- </profile>
- </profiles>
- [...]
- <activeProfiles>
- <activeProfile>compiler</activeProfile>
- </activeProfiles>
- </settings>
- -->
<compilerVersion>1.4</compilerVersion>
</configuration>
</plugin>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
Like I said - I'm seeing this first release as a learning experience (grin,
grin)
On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> Hi,
>
> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com>
> wrote:
> > ...The candidate can be found at:
> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
>
> Unfortunately I'm -1 on the release, I have a few issues including a
> GPL dependency.
>
> 1) jwebunit dependency is GPL
> The server module depends on
>
> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>
> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>
I didn't check any maven dependencies, because they weren't part of SVN.
>
> 2) The sha1 digest does not match, did I do something wrong?
>
> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> a9ec8d95266d5944d493392a06eb1651c03222f1
>
> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
> 64B3B76C 747BA64A FFC9A836 EDAB8D86
> 4E0735CC AA29ACA9 07767C58 D1C0FEDA
> CA7E73A3 ADA3944D 464314B2 4BE0E476
>
> I'm assuming I did something wrong. It was my first attempt at signing.
I'll take another shot at it.
> 3) mvn dependency:analyze of the server module shows lots of unused
> declared dependencies, those should be cleaned up, especially
> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
> either GPL or CDDL license. Not sure which parts of OpenDMK are which
> license, but as it's unused better remove it.
>
OK - I'll take a look at it.
>
> 4) When trying to build esme-java-client with "mvn clean install" I
> get "Embedded error: Error while executing the external compiler" if
> JAVA_HOME is not set.
>
How can you deal with this via maven? Is this an ESME problem or a maven
problem?
>
> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> should not have that. You could have created the release using svn
> export of
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
> to avoid that.
>
OK. Didn't know that.
>
> 6) I couldn't find license information for the
> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> ok?
>
Don't know - I'll have to check. This was from our JMX interface .
>
> Sorry that I didn't have time to look at that during the ESME podling vote.
>
> Apart from the GPL dependency the release preparation looks mostly ok,
> rat reports are good, license/notice are provided, etc.
>
> -Bertrand
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
Like I said - I'm seeing this first release as a learning experience (grin,
grin)
On Tue, Feb 16, 2010 at 5:28 PM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> Hi,
>
> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com>
> wrote:
> > ...The candidate can be found at:
> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
>
> Unfortunately I'm -1 on the release, I have a few issues including a
> GPL dependency.
>
> 1) jwebunit dependency is GPL
> The server module depends on
>
> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>
> which according to http://jwebunit.sourceforge.net/license.html is GPL.
>
I didn't check any maven dependencies, because they weren't part of SVN.
>
> 2) The sha1 digest does not match, did I do something wrong?
>
> $ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
> SHA1(apache-esme-incubating-1.0-src.tar.gz)=
> a9ec8d95266d5944d493392a06eb1651c03222f1
>
> $ cat apache-esme-incubating-1.0-src.tar.gz.sha
> apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
> 64B3B76C 747BA64A FFC9A836 EDAB8D86
> 4E0735CC AA29ACA9 07767C58 D1C0FEDA
> CA7E73A3 ADA3944D 464314B2 4BE0E476
>
> I'm assuming I did something wrong. It was my first attempt at signing.
I'll take another shot at it.
> 3) mvn dependency:analyze of the server module shows lots of unused
> declared dependencies, those should be cleaned up, especially
> openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
> either GPL or CDDL license. Not sure which parts of OpenDMK are which
> license, but as it's unused better remove it.
>
OK - I'll take a look at it.
>
> 4) When trying to build esme-java-client with "mvn clean install" I
> get "Embedded error: Error while executing the external compiler" if
> JAVA_HOME is not set.
>
How can you deal with this via maven? Is this an ESME problem or a maven
problem?
>
> 5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
> should not have that. You could have created the release using svn
> export of
> http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
> to avoid that.
>
OK. Didn't know that.
>
> 6) I couldn't find license information for the
> com.twitter:stats:jar:1.3:compile dependency, was that checked to be
> ok?
>
Don't know - I'll have to check. This was from our JMX interface .
>
> Sorry that I didn't have time to look at that during the ESME podling vote.
>
> Apart from the GPL dependency the release preparation looks mostly ok,
> rat reports are good, license/notice are provided, etc.
>
> -Bertrand
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Joe Schaefer <jo...@yahoo.com>.
----- Original Message ----
> From: Bertrand Delacretaz <bd...@apache.org>
> To: esme-dev@incubator.apache.org
> Cc: general@incubator.apache.org
> Sent: Tue, February 16, 2010 11:28:22 AM
> Subject: Re: [VOTE] Approve the release of apache-esme-incubating-1.0
>
> Hi,
>
> On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch wrote:
> > ...The candidate can be found at:
> > http://people.apache.org/~rhirsch/esme/
>
> Unfortunately I'm -1 on the release, I have a few issues including a
> GPL dependency.
>
> 1) jwebunit dependency is GPL
> The server module depends on
>
> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
>
> which according to http://jwebunit.sourceforge.net/license.html is GPL.
Well isn't jwebunit a test framework, in which case, (and assuming there
are no dependencies on it in the production-ready codebase of esme) do
we really care that it's GPL or not? (Note an exception to the (L)GPL
policy was recently granted for build dependencies, so I think it's might
be possible to extend that to test deps.)
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com> wrote:
> ...The candidate can be found at:
> http://people.apache.org/~rhirsch/esme/
Unfortunately I'm -1 on the release, I have a few issues including a
GPL dependency.
1) jwebunit dependency is GPL
The server module depends on
net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
which according to http://jwebunit.sourceforge.net/license.html is GPL.
2) The sha1 digest does not match, did I do something wrong?
$ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
SHA1(apache-esme-incubating-1.0-src.tar.gz)=
a9ec8d95266d5944d493392a06eb1651c03222f1
$ cat apache-esme-incubating-1.0-src.tar.gz.sha
apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
64B3B76C 747BA64A FFC9A836 EDAB8D86
4E0735CC AA29ACA9 07767C58 D1C0FEDA
CA7E73A3 ADA3944D 464314B2 4BE0E476
3) mvn dependency:analyze of the server module shows lots of unused
declared dependencies, those should be cleaned up, especially
openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
either GPL or CDDL license. Not sure which parts of OpenDMK are which
license, but as it's unused better remove it.
4) When trying to build esme-java-client with "mvn clean install" I
get "Embedded error: Error while executing the external compiler" if
JAVA_HOME is not set.
5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
should not have that. You could have created the release using svn
export of http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
to avoid that.
6) I couldn't find license information for the
com.twitter:stats:jar:1.3:compile dependency, was that checked to be
ok?
Sorry that I didn't have time to look at that during the ESME podling vote.
Apart from the GPL dependency the release preparation looks mostly ok,
rat reports are good, license/notice are provided, etc.
-Bertrand
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by "Mattmann, Chris A (388J)" <ch...@jpl.nasa.gov>.
Hi guys,
On 2/16/10 8:22 AM, "Daniel Kulp" <dk...@apache.org> wrote:
>> What would be better in the pom.xml:
>> <version>apache-esme-1.0</version>?
>
> No, just 1.0-incubator or similar. If this is the 1.0 release, the version
> number should be 1.0. The 1.1 release would have a version of 1.1.
According to:
http://incubator.apache.org/guides/releasemanagement.html#naming
The release should contain the word: "incubating". So,
"apache-esme-1.0-incubating" is probably the appropriate title.
HTH,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: Chris.Mattmann@jpl.nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by "Mattmann, Chris A (388J)" <ch...@jpl.nasa.gov>.
Hi guys,
On 2/16/10 8:22 AM, "Daniel Kulp" <dk...@apache.org> wrote:
>> What would be better in the pom.xml:
>> <version>apache-esme-1.0</version>?
>
> No, just 1.0-incubator or similar. If this is the 1.0 release, the version
> number should be 1.0. The 1.1 release would have a version of 1.1.
According to:
http://incubator.apache.org/guides/releasemanagement.html#naming
The release should contain the word: "incubating". So,
"apache-esme-1.0-incubating" is probably the appropriate title.
HTH,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: Chris.Mattmann@jpl.nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: Fwd: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Daniel Kulp <dk...@apache.org>.
On Tue February 16 2010 10:18:10 am Richard Hirsch wrote:
> On Tue, Feb 16, 2010 at 3:57 PM, Daniel Kulp <dk...@apache.org> wrote:
> > 2) The tar unpacks into a "trunk" directory. That really should unpack
> > into
> > a "apache-esme-1.0" directory or similar.
>
> I'll change this for the next release.
>
> > 3) The "version" number in the pom is still 0.3.0-SNAPSHOT. Thus, if you
> > build it, you get a snapshot war. Not a "huge" deal if we're not
> > providing
> > a binary war, but a bit unusual and unexpected.
>
> What would be better in the pom.xml:
> <version>apache-esme-1.0</version>?
No, just 1.0-incubator or similar. If this is the 1.0 release, the version
number should be 1.0. The 1.1 release would have a version of 1.1.
> > 4) Snapshot dependencies. It has dependencies on snapshots from Lift.
> > Not
> > good for a "release" as the release isn't really reproducible.
>
> Do you mean: <lift.version>1.1-SNAPSHOT</lift.version>? I'll remember it
> for the next release.
Yep.
> > 5) Very minor suggestion: if you are Java 6 only, you could exclude
> > things like activation.jar, xml-apis, and most likely xerces to make the
> > war a little
> > bit smaller..
>
> We are hoping to be JDK 1.5 "buildable" again in the future (crossing our
> fingers...), so I wanted to leave these files in the release
Ah. Ok. Makes sense. :-)
Dan
>
> > As far as the legal bits go, looks ok for a source release, so +1.
> >
> > Dan
>
> Thanks
>
> > On Mon February 15 2010 10:05:43 am Richard Hirsch wrote:
> > > The ESME community has voted on and approved the release of ESME 1.0.
> > > We would now like to request the approval of the Incubator PMC for
> > > this release.
> >
> > > Details of the ESME community vote can be found here:
> > http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%
> > 3C
> >
> > > fa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
> > >
> > > The candidate can be found at:
> > > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erh
> > > irsch/esme/>
> > >
> > > See the CHANGES.txt file for details on release contents. The release
> > > candidate is a tar archive of the sources in
> >
> > https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
> >
> > > The MD5 checksum of the apache-esme-incubating-1.0-
> > > src.tar.gz release package is
> > > A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
> > >
> > > Please vote on releasing this package as Apache ESME 1.0-incubating.
> > >
> > > Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> > > please include the testing you performed to arrive at your vote
> > >
> > > [ ] +1 Publish
> > > [ ] 0 Abstain
> > > [ ] -1 Don't publish, because...
> > >
> > > Below is a summary of the vote on the ESME mailing list
> > >
> > > Thanks
> > >
> > > Dick
> > >
> > > ---------------
> > >
> > > Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM.
> > > ✆ to esme-dev@incubator.apache.org
> > > date Mon, Feb 15, 2010 at 4:00 PM
> > > subject [VOTE][RESULT] ESME 1.0
> > > mailed-by gmail.com
> > >
> > >
> > > Hello All,
> > >
> > > Voting on the ESME 1.0 candidate release has concluded
> > >
> > > Results:
> > >
> > > 6 binding +1 vote
> > >
> > > Dick Hirsch +1
> > > Mrinal Wadhwa +1
> > > Vassil Dichev +1
> > > Ethan Jewett +1
> > > Anne Kathrine Petteroe +1
> > > Darren Hague +1
> > >
> > > 1 non-binding +1 votes
> > >
> > > Daniel Koller +1
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> >
> > --
> > Daniel Kulp
> > dkulp@apache.org
> > http://www.dankulp.com/blog
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: Fwd: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Daniel Kulp <dk...@apache.org>.
On Tue February 16 2010 10:18:10 am Richard Hirsch wrote:
> On Tue, Feb 16, 2010 at 3:57 PM, Daniel Kulp <dk...@apache.org> wrote:
> > 2) The tar unpacks into a "trunk" directory. That really should unpack
> > into
> > a "apache-esme-1.0" directory or similar.
>
> I'll change this for the next release.
>
> > 3) The "version" number in the pom is still 0.3.0-SNAPSHOT. Thus, if you
> > build it, you get a snapshot war. Not a "huge" deal if we're not
> > providing
> > a binary war, but a bit unusual and unexpected.
>
> What would be better in the pom.xml:
> <version>apache-esme-1.0</version>?
No, just 1.0-incubator or similar. If this is the 1.0 release, the version
number should be 1.0. The 1.1 release would have a version of 1.1.
> > 4) Snapshot dependencies. It has dependencies on snapshots from Lift.
> > Not
> > good for a "release" as the release isn't really reproducible.
>
> Do you mean: <lift.version>1.1-SNAPSHOT</lift.version>? I'll remember it
> for the next release.
Yep.
> > 5) Very minor suggestion: if you are Java 6 only, you could exclude
> > things like activation.jar, xml-apis, and most likely xerces to make the
> > war a little
> > bit smaller..
>
> We are hoping to be JDK 1.5 "buildable" again in the future (crossing our
> fingers...), so I wanted to leave these files in the release
Ah. Ok. Makes sense. :-)
Dan
>
> > As far as the legal bits go, looks ok for a source release, so +1.
> >
> > Dan
>
> Thanks
>
> > On Mon February 15 2010 10:05:43 am Richard Hirsch wrote:
> > > The ESME community has voted on and approved the release of ESME 1.0.
> > > We would now like to request the approval of the Incubator PMC for
> > > this release.
> >
> > > Details of the ESME community vote can be found here:
> > http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%
> > 3C
> >
> > > fa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
> > >
> > > The candidate can be found at:
> > > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erh
> > > irsch/esme/>
> > >
> > > See the CHANGES.txt file for details on release contents. The release
> > > candidate is a tar archive of the sources in
> >
> > https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
> >
> > > The MD5 checksum of the apache-esme-incubating-1.0-
> > > src.tar.gz release package is
> > > A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
> > >
> > > Please vote on releasing this package as Apache ESME 1.0-incubating.
> > >
> > > Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> > > please include the testing you performed to arrive at your vote
> > >
> > > [ ] +1 Publish
> > > [ ] 0 Abstain
> > > [ ] -1 Don't publish, because...
> > >
> > > Below is a summary of the vote on the ESME mailing list
> > >
> > > Thanks
> > >
> > > Dick
> > >
> > > ---------------
> > >
> > > Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM.
> > > ✆ to esme-dev@incubator.apache.org
> > > date Mon, Feb 15, 2010 at 4:00 PM
> > > subject [VOTE][RESULT] ESME 1.0
> > > mailed-by gmail.com
> > >
> > >
> > > Hello All,
> > >
> > > Voting on the ESME 1.0 candidate release has concluded
> > >
> > > Results:
> > >
> > > 6 binding +1 vote
> > >
> > > Dick Hirsch +1
> > > Mrinal Wadhwa +1
> > > Vassil Dichev +1
> > > Ethan Jewett +1
> > > Anne Kathrine Petteroe +1
> > > Darren Hague +1
> > >
> > > 1 non-binding +1 votes
> > >
> > > Daniel Koller +1
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> >
> > --
> > Daniel Kulp
> > dkulp@apache.org
> > http://www.dankulp.com/blog
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
We need to find the official lift.version for 1.1. that is is the official
release and not the snapshot.
Although for the next release, we could be looking at lift 2.0.
On Tue, Feb 16, 2010 at 4:49 PM, Vassil Dichev <vd...@apache.org> wrote:
> >> 4) Snapshot dependencies. It has dependencies on snapshots from Lift.
> >> Not
> >> good for a "release" as the release isn't really reproducible.
> >>
> >
> > Do you mean: <lift.version>1.1-SNAPSHOT</lift.version>? I'll remember it
> for
> > the next release.
>
> Actually this might be a problem if Lift introduces breaking changes,
> which is not unlikely for a snapshot version. We have to check a fixed
> version which we can use.
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Vassil Dichev <vd...@apache.org>.
>> 4) Snapshot dependencies. It has dependencies on snapshots from Lift.
>> Not
>> good for a "release" as the release isn't really reproducible.
>>
>
> Do you mean: <lift.version>1.1-SNAPSHOT</lift.version>? I'll remember it for
> the next release.
Actually this might be a problem if Lift introduces breaking changes,
which is not unlikely for a snapshot version. We have to check a fixed
version which we can use.
Fwd: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
---------- Forwarded message ----------
From: Richard Hirsch <hi...@gmail.com>
Date: Tue, Feb 16, 2010 at 4:17 PM
Subject: Re: [VOTE] Approve the release of apache-esme-incubating-1.0
To: Daniel Kulp <dk...@apache.org>
On Tue, Feb 16, 2010 at 3:57 PM, Daniel Kulp <dk...@apache.org> wrote:
>
> +1 (mentor and IPMC binding)
>
> Some thoughts, but nothing that I would consider a "show stopper" since
> this
> is a source only release (aka: not providing a prebuilt war type thing or
> deploying it to Maven central):
>
> 1) The README mentions a "Collective work: Copyright 2007", but the NOTICE
> starts the copyright at 2008. That said, I'd just remove the License
> section
> from the README entirely.
>
Done.
>
> 2) The tar unpacks into a "trunk" directory. That really should unpack
> into
> a "apache-esme-1.0" directory or similar.
>
I'll change this for the next release.
>
> 3) The "version" number in the pom is still 0.3.0-SNAPSHOT. Thus, if you
> build it, you get a snapshot war. Not a "huge" deal if we're not
> providing
> a binary war, but a bit unusual and unexpected.
>
What would be better in the pom.xml: <version>apache-esme-1.0</version>?
>
> 4) Snapshot dependencies. It has dependencies on snapshots from Lift.
> Not
> good for a "release" as the release isn't really reproducible.
>
Do you mean: <lift.version>1.1-SNAPSHOT</lift.version>? I'll remember it for
the next release.
>
> 5) Very minor suggestion: if you are Java 6 only, you could exclude things
> like activation.jar, xml-apis, and most likely xerces to make the war a
> little
> bit smaller..
>
We are hoping to be JDK 1.5 "buildable" again in the future (crossing our
fingers...), so I wanted to leave these files in the release
>
> As far as the legal bits go, looks ok for a source release, so +1.
>
> Dan
>
Thanks
>
>
> On Mon February 15 2010 10:05:43 am Richard Hirsch wrote:
> > The ESME community has voted on and approved the release of ESME 1.0.
> > We would now like to request the approval of the Incubator PMC for
> > this release.
> >
> > Details of the ESME community vote can be found here:
> >
> http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3C
> > fa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
> >
> > The candidate can be found at:
> >
> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
> >
> > See the CHANGES.txt file for details on release contents. The release
> > candidate is a tar archive of the sources in
> >
> https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
> >
> > The MD5 checksum of the apache-esme-incubating-1.0-
> > src.tar.gz release package is
> > A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
> >
> > Please vote on releasing this package as Apache ESME 1.0-incubating.
> >
> > Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> > please include the testing you performed to arrive at your vote
> > [ ] +1 Publish
> > [ ] 0 Abstain
> > [ ] -1 Don't publish, because...
> >
> > Below is a summary of the vote on the ESME mailing list
> >
> > Thanks
> >
> > Dick
> >
> > ---------------
> >
> > Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆
> > to esme-dev@incubator.apache.org
> > date Mon, Feb 15, 2010 at 4:00 PM
> > subject [VOTE][RESULT] ESME 1.0
> > mailed-by gmail.com
> >
> >
> > Hello All,
> >
> > Voting on the ESME 1.0 candidate release has concluded
> >
> > Results:
> >
> > 6 binding +1 vote
> >
> > Dick Hirsch +1
> > Mrinal Wadhwa +1
> > Vassil Dichev +1
> > Ethan Jewett +1
> > Anne Kathrine Petteroe +1
> > Darren Hague +1
> >
> > 1 non-binding +1 votes
> >
> > Daniel Koller +1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
>
> --
> Daniel Kulp
> dkulp@apache.org
> http://www.dankulp.com/blog
>
Fwd: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
---------- Forwarded message ----------
From: Richard Hirsch <hi...@gmail.com>
Date: Tue, Feb 16, 2010 at 4:17 PM
Subject: Re: [VOTE] Approve the release of apache-esme-incubating-1.0
To: Daniel Kulp <dk...@apache.org>
On Tue, Feb 16, 2010 at 3:57 PM, Daniel Kulp <dk...@apache.org> wrote:
>
> +1 (mentor and IPMC binding)
>
> Some thoughts, but nothing that I would consider a "show stopper" since
> this
> is a source only release (aka: not providing a prebuilt war type thing or
> deploying it to Maven central):
>
> 1) The README mentions a "Collective work: Copyright 2007", but the NOTICE
> starts the copyright at 2008. That said, I'd just remove the License
> section
> from the README entirely.
>
Done.
>
> 2) The tar unpacks into a "trunk" directory. That really should unpack
> into
> a "apache-esme-1.0" directory or similar.
>
I'll change this for the next release.
>
> 3) The "version" number in the pom is still 0.3.0-SNAPSHOT. Thus, if you
> build it, you get a snapshot war. Not a "huge" deal if we're not
> providing
> a binary war, but a bit unusual and unexpected.
>
What would be better in the pom.xml: <version>apache-esme-1.0</version>?
>
> 4) Snapshot dependencies. It has dependencies on snapshots from Lift.
> Not
> good for a "release" as the release isn't really reproducible.
>
Do you mean: <lift.version>1.1-SNAPSHOT</lift.version>? I'll remember it for
the next release.
>
> 5) Very minor suggestion: if you are Java 6 only, you could exclude things
> like activation.jar, xml-apis, and most likely xerces to make the war a
> little
> bit smaller..
>
We are hoping to be JDK 1.5 "buildable" again in the future (crossing our
fingers...), so I wanted to leave these files in the release
>
> As far as the legal bits go, looks ok for a source release, so +1.
>
> Dan
>
Thanks
>
>
> On Mon February 15 2010 10:05:43 am Richard Hirsch wrote:
> > The ESME community has voted on and approved the release of ESME 1.0.
> > We would now like to request the approval of the Incubator PMC for
> > this release.
> >
> > Details of the ESME community vote can be found here:
> >
> http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3C
> > fa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
> >
> > The candidate can be found at:
> >
> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
> >
> > See the CHANGES.txt file for details on release contents. The release
> > candidate is a tar archive of the sources in
> >
> https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
> >
> > The MD5 checksum of the apache-esme-incubating-1.0-
> > src.tar.gz release package is
> > A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
> >
> > Please vote on releasing this package as Apache ESME 1.0-incubating.
> >
> > Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> > please include the testing you performed to arrive at your vote
> > [ ] +1 Publish
> > [ ] 0 Abstain
> > [ ] -1 Don't publish, because...
> >
> > Below is a summary of the vote on the ESME mailing list
> >
> > Thanks
> >
> > Dick
> >
> > ---------------
> >
> > Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆
> > to esme-dev@incubator.apache.org
> > date Mon, Feb 15, 2010 at 4:00 PM
> > subject [VOTE][RESULT] ESME 1.0
> > mailed-by gmail.com
> >
> >
> > Hello All,
> >
> > Voting on the ESME 1.0 candidate release has concluded
> >
> > Results:
> >
> > 6 binding +1 vote
> >
> > Dick Hirsch +1
> > Mrinal Wadhwa +1
> > Vassil Dichev +1
> > Ethan Jewett +1
> > Anne Kathrine Petteroe +1
> > Darren Hague +1
> >
> > 1 non-binding +1 votes
> >
> > Daniel Koller +1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
>
> --
> Daniel Kulp
> dkulp@apache.org
> http://www.dankulp.com/blog
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Daniel Kulp <dk...@apache.org>.
+1 (mentor and IPMC binding)
Some thoughts, but nothing that I would consider a "show stopper" since this
is a source only release (aka: not providing a prebuilt war type thing or
deploying it to Maven central):
1) The README mentions a "Collective work: Copyright 2007", but the NOTICE
starts the copyright at 2008. That said, I'd just remove the License section
from the README entirely.
2) The tar unpacks into a "trunk" directory. That really should unpack into
a "apache-esme-1.0" directory or similar.
3) The "version" number in the pom is still 0.3.0-SNAPSHOT. Thus, if you
build it, you get a snapshot war. Not a "huge" deal if we're not providing
a binary war, but a bit unusual and unexpected.
4) Snapshot dependencies. It has dependencies on snapshots from Lift. Not
good for a "release" as the release isn't really reproducible.
5) Very minor suggestion: if you are Java 6 only, you could exclude things
like activation.jar, xml-apis, and most likely xerces to make the war a little
bit smaller..
As far as the legal bits go, looks ok for a source release, so +1.
Dan
On Mon February 15 2010 10:05:43 am Richard Hirsch wrote:
> The ESME community has voted on and approved the release of ESME 1.0.
> We would now like to request the approval of the Incubator PMC for
> this release.
>
> Details of the ESME community vote can be found here:
> http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3C
> fa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
>
> The candidate can be found at:
>
> http://people.apache.org/~rhirsch/esme/
>
> See the CHANGES.txt file for details on release contents. The release
> candidate is a tar archive of the sources in
> https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
>
> The MD5 checksum of the apache-esme-incubating-1.0-
> src.tar.gz release package is
> A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
>
> Please vote on releasing this package as Apache ESME 1.0-incubating.
>
> Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> please include the testing you performed to arrive at your vote
> [ ] +1 Publish
> [ ] 0 Abstain
> [ ] -1 Don't publish, because...
>
> Below is a summary of the vote on the ESME mailing list
>
> Thanks
>
> Dick
>
> ---------------
>
> Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆
> to esme-dev@incubator.apache.org
> date Mon, Feb 15, 2010 at 4:00 PM
> subject [VOTE][RESULT] ESME 1.0
> mailed-by gmail.com
>
>
> Hello All,
>
> Voting on the ESME 1.0 candidate release has concluded
>
> Results:
>
> 6 binding +1 vote
>
> Dick Hirsch +1
> Mrinal Wadhwa +1
> Vassil Dichev +1
> Ethan Jewett +1
> Anne Kathrine Petteroe +1
> Darren Hague +1
>
> 1 non-binding +1 votes
>
> Daniel Koller +1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Richard Hirsch <hi...@gmail.com>.
@Glen: Thanks for the tip. I've updated the README for the next release.
D.
On Mon, Feb 15, 2010 at 9:34 PM, Glen Daniels <gl...@thoughtcraft.com> wrote:
> Seems to work fine, although you should perhaps make super-clear in the
> next
> version's README that you require JDK 1.6 (I was on 1.5 and had build
> problems).
>
> +1 from me for the release.
>
> Thanks,
> --Glen
>
> On 2/15/2010 10:05 AM, Richard Hirsch wrote:
> > The ESME community has voted on and approved the release of ESME 1.0.
> > We would now like to request the approval of the Incubator PMC for
> > this release.
> >
> > Details of the ESME community vote can be found here:
> >
> http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3Cfa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
> >
> > The candidate can be found at:
> >
> > http://people.apache.org/~rhirsch/esme/<http://people.apache.org/%7Erhirsch/esme/>
> >
> > See the CHANGES.txt file for details on release contents. The release
> > candidate is a tar archive of the sources in
> >
> https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
> >
> > The MD5 checksum of the apache-esme-incubating-1.0-
> > src.tar.gz release package is
> > A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
> >
> > Please vote on releasing this package as Apache ESME 1.0-incubating.
> >
> > Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> > please include the testing you performed to arrive at your vote
> > [ ] +1 Publish
> > [ ] 0 Abstain
> > [ ] -1 Don't publish, because...
> >
> > Below is a summary of the vote on the ESME mailing list
> >
> > Thanks
> >
> > Dick
> >
> > ---------------
> >
> > Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆
> > to esme-dev@incubator.apache.org
> > date Mon, Feb 15, 2010 at 4:00 PM
> > subject [VOTE][RESULT] ESME 1.0
> > mailed-by gmail.com
> >
> >
> > Hello All,
> >
> > Voting on the ESME 1.0 candidate release has concluded
> >
> > Results:
> >
> > 6 binding +1 vote
> >
> > Dick Hirsch +1
> > Mrinal Wadhwa +1
> > Vassil Dichev +1
> > Ethan Jewett +1
> > Anne Kathrine Petteroe +1
> > Darren Hague +1
> >
> > 1 non-binding +1 votes
> >
> > Daniel Koller +1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Seems to work fine, although you should perhaps make super-clear in the next
version's README that you require JDK 1.6 (I was on 1.5 and had build problems).
+1 from me for the release.
Thanks,
--Glen
On 2/15/2010 10:05 AM, Richard Hirsch wrote:
> The ESME community has voted on and approved the release of ESME 1.0.
> We would now like to request the approval of the Incubator PMC for
> this release.
>
> Details of the ESME community vote can be found here:
> http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3Cfa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
>
> The candidate can be found at:
>
> http://people.apache.org/~rhirsch/esme/
>
> See the CHANGES.txt file for details on release contents. The release
> candidate is a tar archive of the sources in
> https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
>
> The MD5 checksum of the apache-esme-incubating-1.0-
> src.tar.gz release package is
> A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
>
> Please vote on releasing this package as Apache ESME 1.0-incubating.
>
> Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> please include the testing you performed to arrive at your vote
> [ ] +1 Publish
> [ ] 0 Abstain
> [ ] -1 Don't publish, because...
>
> Below is a summary of the vote on the ESME mailing list
>
> Thanks
>
> Dick
>
> ---------------
>
> Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆
> to esme-dev@incubator.apache.org
> date Mon, Feb 15, 2010 at 4:00 PM
> subject [VOTE][RESULT] ESME 1.0
> mailed-by gmail.com
>
>
> Hello All,
>
> Voting on the ESME 1.0 candidate release has concluded
>
> Results:
>
> 6 binding +1 vote
>
> Dick Hirsch +1
> Mrinal Wadhwa +1
> Vassil Dichev +1
> Ethan Jewett +1
> Anne Kathrine Petteroe +1
> Darren Hague +1
>
> 1 non-binding +1 votes
>
> Daniel Koller +1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Daniel Kulp <dk...@apache.org>.
+1 (mentor and IPMC binding)
Some thoughts, but nothing that I would consider a "show stopper" since this
is a source only release (aka: not providing a prebuilt war type thing or
deploying it to Maven central):
1) The README mentions a "Collective work: Copyright 2007", but the NOTICE
starts the copyright at 2008. That said, I'd just remove the License section
from the README entirely.
2) The tar unpacks into a "trunk" directory. That really should unpack into
a "apache-esme-1.0" directory or similar.
3) The "version" number in the pom is still 0.3.0-SNAPSHOT. Thus, if you
build it, you get a snapshot war. Not a "huge" deal if we're not providing
a binary war, but a bit unusual and unexpected.
4) Snapshot dependencies. It has dependencies on snapshots from Lift. Not
good for a "release" as the release isn't really reproducible.
5) Very minor suggestion: if you are Java 6 only, you could exclude things
like activation.jar, xml-apis, and most likely xerces to make the war a little
bit smaller..
As far as the legal bits go, looks ok for a source release, so +1.
Dan
On Mon February 15 2010 10:05:43 am Richard Hirsch wrote:
> The ESME community has voted on and approved the release of ESME 1.0.
> We would now like to request the approval of the Incubator PMC for
> this release.
>
> Details of the ESME community vote can be found here:
> http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3C
> fa2d9f451002120649u54cdd8b5red151033d655b66a@mail.gmail.com%3E
>
> The candidate can be found at:
>
> http://people.apache.org/~rhirsch/esme/
>
> See the CHANGES.txt file for details on release contents. The release
> candidate is a tar archive of the sources in
> https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/
>
> The MD5 checksum of the apache-esme-incubating-1.0-
> src.tar.gz release package is
> A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18
>
> Please vote on releasing this package as Apache ESME 1.0-incubating.
>
> Please vote to publish this release by Thursday, Feb 18 16:03 CET,
> please include the testing you performed to arrive at your vote
> [ ] +1 Publish
> [ ] 0 Abstain
> [ ] -1 Don't publish, because...
>
> Below is a summary of the vote on the ESME mailing list
>
> Thanks
>
> Dick
>
> ---------------
>
> Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆
> to esme-dev@incubator.apache.org
> date Mon, Feb 15, 2010 at 4:00 PM
> subject [VOTE][RESULT] ESME 1.0
> mailed-by gmail.com
>
>
> Hello All,
>
> Voting on the ESME 1.0 candidate release has concluded
>
> Results:
>
> 6 binding +1 vote
>
> Dick Hirsch +1
> Mrinal Wadhwa +1
> Vassil Dichev +1
> Ethan Jewett +1
> Anne Kathrine Petteroe +1
> Darren Hague +1
>
> 1 non-binding +1 votes
>
> Daniel Koller +1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
--
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Approve the release of apache-esme-incubating-1.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hi...@gmail.com> wrote:
> ...The candidate can be found at:
> http://people.apache.org/~rhirsch/esme/
Unfortunately I'm -1 on the release, I have a few issues including a
GPL dependency.
1) jwebunit dependency is GPL
The server module depends on
net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test
which according to http://jwebunit.sourceforge.net/license.html is GPL.
2) The sha1 digest does not match, did I do something wrong?
$ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
SHA1(apache-esme-incubating-1.0-src.tar.gz)=
a9ec8d95266d5944d493392a06eb1651c03222f1
$ cat apache-esme-incubating-1.0-src.tar.gz.sha
apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
64B3B76C 747BA64A FFC9A836 EDAB8D86
4E0735CC AA29ACA9 07767C58 D1C0FEDA
CA7E73A3 ADA3944D 464314B2 4BE0E476
3) mvn dependency:analyze of the server module shows lots of unused
declared dependencies, those should be cleaned up, especially
openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
either GPL or CDDL license. Not sure which parts of OpenDMK are which
license, but as it's unused better remove it.
4) When trying to build esme-java-client with "mvn clean install" I
get "Embedded error: Error while executing the external compiler" if
JAVA_HOME is not set.
5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
should not have that. You could have created the release using svn
export of http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1.0-incubating/
to avoid that.
6) I couldn't find license information for the
com.twitter:stats:jar:1.3:compile dependency, was that checked to be
ok?
Sorry that I didn't have time to look at that during the ESME podling vote.
Apart from the GPL dependency the release preparation looks mostly ok,
rat reports are good, license/notice are provided, etc.
-Bertrand
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org