You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/23 17:46:34 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #15724: [Broker] Replicator producer should have blockIfQueueFull=true

lhotari commented on code in PR #15724:
URL: https://github.com/apache/pulsar/pull/15724#discussion_r879728693


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java:
##########
@@ -83,6 +83,7 @@ public AbstractReplicator(String topicName, String replicatorPrefix, String loca
                 .enableBatching(false)
                 .sendTimeout(0, TimeUnit.SECONDS) //
                 .maxPendingMessages(producerQueueSize) //
+                .blockIfQueueFull(true)

Review Comment:
   Thanks for reviewing @merlimat . Yes, blocking would be problematic in this case.
   
   Would you mind also reviewing #15723 since the memory limit is currently causing regressions in geo-replication in 2.10 . 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org