You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ignacio Vera (JIRA)" <ji...@apache.org> on 2017/12/01 07:15:00 UTC

[jira] [Updated] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

     [ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ignacio Vera updated LUCENE-8071:
---------------------------------
    Attachment: LUCENE-8071.patch
                LUCENE-8071-test.patch

Attached the test and proposed solution.

I basically force the shape to create at least 4 sectors if the radius is big. I have realized as well that the shape has always a minimum of two sectors. Therefore there is a lot of code that can be removed as it is checking for number of sectors lower than 2.



> GeoExactCircle should  create circles with right number of planes
> -----------------------------------------------------------------
>
>                 Key: LUCENE-8071
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8071
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>         Attachments: LUCENE-8071-test.patch, LUCENE-8071.patch
>
>
> Hi [~kwright@metacarta.com],
> There is still a situation when the test can fail. It happens when the planet model is a SPHERE and the radius is slightly lower than PI. The circle is created with two sectors but the circle plane is too big and the shape is bogus.
> I will attach a test and a proposed solution. (I hope this is the last issue of this saga)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org