You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/07/29 22:24:04 UTC
Review Request 24064: Flume: API required to provide temporal
min/max/avg/sum/rate for a Flume metric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24064/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-6662
https://issues.apache.org/jira/browse/AMBARI-6662
Repository: ambari
Description
-------
Updated rrd.py to do the following use case: Collect metrics across regex-matching rrd files and provide min/max/avg/sum aggregate metrics across all hosts. Flume requires special metrics considering many processes can coexist on one host.
Also addressed a small issue that was forcing the UI to show duplicate alerts. I just threw that in because I had noticed it.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java cc0f939
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json c560d2a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 1cbdf39
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 a3561e9
ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cbd3262
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 1abd849
Diff: https://reviews.apache.org/r/24064/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:56.017s
[INFO] Finished at: Tue Jul 29 16:22:21 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 24064: Flume: API required to provide temporal
min/max/avg/sum/rate for a Flume metric
Posted by Nate Cole <nc...@hortonworks.com>.
> On July 29, 2014, 4:57 p.m., Tom Beerbower wrote:
> > Looks good. So will there be an rrd.py script for each new stack that includes Ganglia?
Thanks for reviewing! So long as we aren't collecting metrics ourselves, we'll have to keep rrd.py as a necessary evil. New stacks hopefully will extend the 'base' one so it won't be a big deal.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24064/#review49021
-----------------------------------------------------------
On July 29, 2014, 4:53 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24064/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 4:53 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-6662
> https://issues.apache.org/jira/browse/AMBARI-6662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Updated rrd.py to do the following use case: Collect metrics across regex-matching rrd files and provide min/max/avg/sum aggregate metrics across all hosts. Flume requires special metrics considering many processes can coexist on one host.
>
> Also addressed a small issue that was forcing the UI to show duplicate alerts. I just threw that in because I had noticed it.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py b27097a
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java cc0f939
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json c560d2a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 1cbdf39
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 a3561e9
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cbd3262
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 328dfff
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java 2942c7a
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 1abd849
>
> Diff: https://reviews.apache.org/r/24064/diff/
>
>
> Testing
> -------
>
> Manual testing to verify old + new functionality. We don't have explicit tests for rrd.py.
>
> Unit tests:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:56.017s
> [INFO] Finished at: Tue Jul 29 16:22:21 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 24064: Flume: API required to provide temporal
min/max/avg/sum/rate for a Flume metric
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24064/#review49021
-----------------------------------------------------------
Ship it!
Looks good. So will there be an rrd.py script for each new stack that includes Ganglia?
- Tom Beerbower
On July 29, 2014, 8:53 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24064/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 8:53 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-6662
> https://issues.apache.org/jira/browse/AMBARI-6662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Updated rrd.py to do the following use case: Collect metrics across regex-matching rrd files and provide min/max/avg/sum aggregate metrics across all hosts. Flume requires special metrics considering many processes can coexist on one host.
>
> Also addressed a small issue that was forcing the UI to show duplicate alerts. I just threw that in because I had noticed it.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py b27097a
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java cc0f939
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json c560d2a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 1cbdf39
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 a3561e9
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cbd3262
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 328dfff
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java 2942c7a
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 1abd849
>
> Diff: https://reviews.apache.org/r/24064/diff/
>
>
> Testing
> -------
>
> Manual testing to verify old + new functionality. We don't have explicit tests for rrd.py.
>
> Unit tests:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:56.017s
> [INFO] Finished at: Tue Jul 29 16:22:21 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 24064: Flume: API required to provide temporal
min/max/avg/sum/rate for a Flume metric
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24064/#review49027
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On July 29, 2014, 8:53 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24064/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 8:53 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-6662
> https://issues.apache.org/jira/browse/AMBARI-6662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Updated rrd.py to do the following use case: Collect metrics across regex-matching rrd files and provide min/max/avg/sum aggregate metrics across all hosts. Flume requires special metrics considering many processes can coexist on one host.
>
> Also addressed a small issue that was forcing the UI to show duplicate alerts. I just threw that in because I had noticed it.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py b27097a
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java cc0f939
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json c560d2a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 1cbdf39
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 a3561e9
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cbd3262
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 328dfff
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java 2942c7a
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 1abd849
>
> Diff: https://reviews.apache.org/r/24064/diff/
>
>
> Testing
> -------
>
> Manual testing to verify old + new functionality. We don't have explicit tests for rrd.py.
>
> Unit tests:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:56.017s
> [INFO] Finished at: Tue Jul 29 16:22:21 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 24064: Flume: API required to provide temporal
min/max/avg/sum/rate for a Flume metric
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24064/
-----------------------------------------------------------
(Updated July 29, 2014, 4:53 p.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Changes
-------
Sigh. Updating to patch to fix a couple of broken tests and a deployment issue. Seriously, what's wrong with people!
Bugs: AMBARI-6662
https://issues.apache.org/jira/browse/AMBARI-6662
Repository: ambari
Description
-------
Updated rrd.py to do the following use case: Collect metrics across regex-matching rrd files and provide min/max/avg/sum aggregate metrics across all hosts. Flume requires special metrics considering many processes can coexist on one host.
Also addressed a small issue that was forcing the UI to show duplicate alerts. I just threw that in because I had noticed it.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py b27097a
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java cc0f939
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json c560d2a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 1cbdf39
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 a3561e9
ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cbd3262
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 328dfff
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java 2942c7a
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 1abd849
Diff: https://reviews.apache.org/r/24064/diff/
Testing
-------
Manual testing to verify old + new functionality. We don't have explicit tests for rrd.py.
Unit tests:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:56.017s
[INFO] Finished at: Tue Jul 29 16:22:21 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 24064: Flume: API required to provide temporal
min/max/avg/sum/rate for a Flume metric
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24064/
-----------------------------------------------------------
(Updated July 29, 2014, 4:24 p.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-6662
https://issues.apache.org/jira/browse/AMBARI-6662
Repository: ambari
Description
-------
Updated rrd.py to do the following use case: Collect metrics across regex-matching rrd files and provide min/max/avg/sum aggregate metrics across all hosts. Flume requires special metrics considering many processes can coexist on one host.
Also addressed a small issue that was forcing the UI to show duplicate alerts. I just threw that in because I had noticed it.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java cc0f939
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json c560d2a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 1cbdf39
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 a3561e9
ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cbd3262
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 1abd849
Diff: https://reviews.apache.org/r/24064/diff/
Testing (updated)
-------
Manual testing to verify old + new functionality. We don't have explicit tests for rrd.py.
Unit tests:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:56.017s
[INFO] Finished at: Tue Jul 29 16:22:21 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole