You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bugraoz93 (via GitHub)" <gi...@apache.org> on 2026/01/31 17:39:05 UTC

[PR] [v3-1-test] Update pmc verification docs (#61271) [airflow]

bugraoz93 opened a new pull request, #61294:
URL: https://github.com/apache/airflow/pull/61294

   * Update Helm Chart release instructions for PMC Checks
   
   * Update KEY download instructions for PMC Checks
   
   * Update dev/README_RELEASE_HELM_CHART.md (cherry picked from commit c74b24ac9b133cc83af62ba35393b28efc7343cb)
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [WIP] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #61294:
URL: https://github.com/apache/airflow/pull/61294#discussion_r2750083766


##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -485,29 +467,51 @@ AIRFLOW_REPO_ROOT=$(pwd -P)
 ```shell
 VERSION=12.0.1
 VERSION_SUFFIX=rc1
+VERSION_RC=${VERSION}${VERSION_SUFFIX}
 ```
 
 3. Check-out the branch from which the release was made and cleanup dist folder:
 
 ```shell
-git checkout helm-chart/${VERSION}${VERSION_SUFFIX}
+git checkout helm-chart/${VERSION_RC}
 rm -rf dist/*
 ```
 
 4. Build the source tarball and package. Since you are not releasing the package, you should ignore version
    check and skip tagging. There is no need to specify version as it is stored in Chart.yaml of the rc tag.
 
 ```shell
-breeze release-management prepare-helm-chart-tarball --version-suffix rc1 --ignore-version-check --skip-tagging
-breeze release-management prepare-helm-chart-package
+breeze release-management prepare-helm-chart-tarball --version-suffix ${VERSION_SUFFIX} --ignore-version-check --skip-tagging
+breeze release-management prepare-helm-chart-package --version-suffix ${VERSION_SUFFIX}

Review Comment:
   This pop to my eyes as a change which I saw in other docs too using the suffix to generate the files
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [WIP] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #61294:
URL: https://github.com/apache/airflow/pull/61294#discussion_r2750083766


##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -485,29 +467,51 @@ AIRFLOW_REPO_ROOT=$(pwd -P)
 ```shell
 VERSION=12.0.1
 VERSION_SUFFIX=rc1
+VERSION_RC=${VERSION}${VERSION_SUFFIX}
 ```
 
 3. Check-out the branch from which the release was made and cleanup dist folder:
 
 ```shell
-git checkout helm-chart/${VERSION}${VERSION_SUFFIX}
+git checkout helm-chart/${VERSION_RC}
 rm -rf dist/*
 ```
 
 4. Build the source tarball and package. Since you are not releasing the package, you should ignore version
    check and skip tagging. There is no need to specify version as it is stored in Chart.yaml of the rc tag.
 
 ```shell
-breeze release-management prepare-helm-chart-tarball --version-suffix rc1 --ignore-version-check --skip-tagging
-breeze release-management prepare-helm-chart-package
+breeze release-management prepare-helm-chart-tarball --version-suffix ${VERSION_SUFFIX} --ignore-version-check --skip-tagging
+breeze release-management prepare-helm-chart-package --version-suffix ${VERSION_SUFFIX}

Review Comment:
   This pop to my eyes as a change which I saw in other docs too using the suffix to generate the files :thinking:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 merged PR #61294:
URL: https://github.com/apache/airflow/pull/61294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [WIP] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #61294:
URL: https://github.com/apache/airflow/pull/61294#issuecomment-3830698603

   Jed fixed this part will merge this and backport from that should fix the part already in main. Not merging this also makes backport harder to choose


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #61294:
URL: https://github.com/apache/airflow/pull/61294#issuecomment-3828893308

   This should be backported before #61291 to keep things easier. Just info


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [WIP] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #61294:
URL: https://github.com/apache/airflow/pull/61294#discussion_r2750102190


##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -485,29 +467,51 @@ AIRFLOW_REPO_ROOT=$(pwd -P)
 ```shell
 VERSION=12.0.1
 VERSION_SUFFIX=rc1
+VERSION_RC=${VERSION}${VERSION_SUFFIX}
 ```
 
 3. Check-out the branch from which the release was made and cleanup dist folder:
 
 ```shell
-git checkout helm-chart/${VERSION}${VERSION_SUFFIX}
+git checkout helm-chart/${VERSION_RC}
 rm -rf dist/*
 ```
 
 4. Build the source tarball and package. Since you are not releasing the package, you should ignore version
    check and skip tagging. There is no need to specify version as it is stored in Chart.yaml of the rc tag.
 
 ```shell
-breeze release-management prepare-helm-chart-tarball --version-suffix rc1 --ignore-version-check --skip-tagging
-breeze release-management prepare-helm-chart-package
+breeze release-management prepare-helm-chart-tarball --version-suffix ${VERSION_SUFFIX} --ignore-version-check --skip-tagging
+breeze release-management prepare-helm-chart-package --version-suffix ${VERSION_SUFFIX}

Review Comment:
   To be precise 
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_PYTHON_CLIENT.md#L412
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_AIRFLOW.md#L800
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_AIRFLOWCTL.md#L511



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [WIP] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #61294:
URL: https://github.com/apache/airflow/pull/61294#discussion_r2750102190


##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -485,29 +467,51 @@ AIRFLOW_REPO_ROOT=$(pwd -P)
 ```shell
 VERSION=12.0.1
 VERSION_SUFFIX=rc1
+VERSION_RC=${VERSION}${VERSION_SUFFIX}
 ```
 
 3. Check-out the branch from which the release was made and cleanup dist folder:
 
 ```shell
-git checkout helm-chart/${VERSION}${VERSION_SUFFIX}
+git checkout helm-chart/${VERSION_RC}
 rm -rf dist/*
 ```
 
 4. Build the source tarball and package. Since you are not releasing the package, you should ignore version
    check and skip tagging. There is no need to specify version as it is stored in Chart.yaml of the rc tag.
 
 ```shell
-breeze release-management prepare-helm-chart-tarball --version-suffix rc1 --ignore-version-check --skip-tagging
-breeze release-management prepare-helm-chart-package
+breeze release-management prepare-helm-chart-tarball --version-suffix ${VERSION_SUFFIX} --ignore-version-check --skip-tagging
+breeze release-management prepare-helm-chart-package --version-suffix ${VERSION_SUFFIX}

Review Comment:
   To be precise 
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_PYTHON_CLIENT.md#L412
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_AIRFLOW.md#L800
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_AIRFLOWCTL.md#L511



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [WIP] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #61294:
URL: https://github.com/apache/airflow/pull/61294#issuecomment-3829414121

   Added WIP to prevent further merges so we can make it work fully
   cc:@jscheffl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [WIP] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #61294:
URL: https://github.com/apache/airflow/pull/61294#discussion_r2750102190


##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -485,29 +467,51 @@ AIRFLOW_REPO_ROOT=$(pwd -P)
 ```shell
 VERSION=12.0.1
 VERSION_SUFFIX=rc1
+VERSION_RC=${VERSION}${VERSION_SUFFIX}
 ```
 
 3. Check-out the branch from which the release was made and cleanup dist folder:
 
 ```shell
-git checkout helm-chart/${VERSION}${VERSION_SUFFIX}
+git checkout helm-chart/${VERSION_RC}
 rm -rf dist/*
 ```
 
 4. Build the source tarball and package. Since you are not releasing the package, you should ignore version
    check and skip tagging. There is no need to specify version as it is stored in Chart.yaml of the rc tag.
 
 ```shell
-breeze release-management prepare-helm-chart-tarball --version-suffix rc1 --ignore-version-check --skip-tagging
-breeze release-management prepare-helm-chart-package
+breeze release-management prepare-helm-chart-tarball --version-suffix ${VERSION_SUFFIX} --ignore-version-check --skip-tagging
+breeze release-management prepare-helm-chart-package --version-suffix ${VERSION_SUFFIX}

Review Comment:
   To be precise 
   
   https://github.com/apache/airflow/blob/dc8124115825dbb4d7b19d786d0adfc15c5884db/dev/README_RELEASE_PYTHON_CLIENT.md?plain=1#L451
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_AIRFLOW.md#L800
   
   https://github.com/apache/airflow/blob/main/dev%2FREADME_RELEASE_AIRFLOWCTL.md#L511



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [v3-1-test] Update pmc verification docs (#61271) [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #61294:
URL: https://github.com/apache/airflow/pull/61294#issuecomment-3828894036

   On a second thought it doesn't really matter :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org