You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/12/16 08:30:42 UTC
[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1775
[ZEPPELIN-1745] View revisions in non-editable mode
### What is this PR for?
This is to make view of revisions non-editable
### What type of PR is it?
Improvement
### Todos
* [x] - disable action bar buttons
* [ ] - disable per paragraph editing
* [ ] - hotkeys?
### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)
### How should this be tested?
TBD
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? possibly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/revision-view
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1775
----
commit 9db56ce63910d9738b2f7a874cab8e6570f16b49
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T04:20:22Z
change var name revisionDisabled -> revisionView
commit cd4e37072c8e154d551ed0c3361fff719a8d55ae
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:10:26Z
disable run all
commit 4f12a5bff226e7f871e810a254daeaea58f3b395
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:12:09Z
disable clear output
commit 5c9dd80a94ed990a41251c105a9c7b697bf3221c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:18:02Z
disable clone note
commit 49f0e15ff215e925657b2972ec7f239b64c2e104
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:19:21Z
disable export note
commit a05f355a96feb1cf7a424cda6775862439b974b0
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:22:14Z
disable revision commit
commit dbb680cda6df168030bda2eebcbcba1ca32c0b62
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:24:16Z
disable remove note
commit 00a0a247162791f2d332c0049ea469008b0e2177
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:25:42Z
disable scheduler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
merged master and finally CI is green. @Leemoonsoo ready for final check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@Leemoonsoo @cloverhearts @1ambda thanks for the review! I addressed all your comments and updated the screenshot above. Please check it out and let me know what you think.
Also [CI logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/187629252/log.txt) seems to be failing only in selenium profile with flaky test from [ZEPPELIN-1836](https://issues.apache.org/jira/browse/ZEPPELIN-1836).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1775
[ZEPPELIN-1745] View revisions in non-editable mode
### What is this PR for?
This is to make view of revisions non-editable
### What type of PR is it?
Improvement
### Todos
* [x] - disable action bar buttons
* [x] - disable per paragraph editing actions
* [x] - disable hotkeys
### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)
### How should this be tested?
1. initialize `GitNotebookRepo` by adding
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
in your `conf/zeppelin-env.sh`
2. go to any note and create few revisions using commit menu
3. then switch between revisions, during which you shouldn't be able to modify note
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/revision-view
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1775
----
commit 4c838954d38f13a6714fe9c460687e66bf92f16c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T04:20:22Z
change var name revisionDisabled -> revisionView
commit fa1397df6d0fcc469d09bb86c223e7b2bd1d007a
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:10:26Z
disable run all
commit 8e978005f99ac1120db08abfe759f3654c3bf846
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:12:09Z
disable clear output
commit 46238e8395ed93c4db5de575223319f4a604f6c3
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:18:02Z
disable clone note
commit 50d40ad2af176e029ba31426065e230c41048c25
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:19:21Z
disable export note
commit 5d9f877722211fcf96482f36c909855bef6936e6
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:22:14Z
disable revision commit
commit ab8ab4db37d6d374b18bc9590f13f96bd1c58bf8
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:24:16Z
disable remove note
commit 711c0b325d07f36ece5ed1ab78d086b975bdcbc4
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:25:42Z
disable scheduler
commit 7d115b821f0734dfb361d1018c0e60b0e7d6d157
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T04:21:51Z
disable + new paragraph
commit 19cacbd6116342dd5e11f63eac419b557554df9e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T04:26:37Z
don't show paragraph settings menu
commit c55de951adaaaa0ee97d16530465e3dae1651679
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T05:09:27Z
don't show run/cancel on paragraph
commit 00fb556059d561d986b4c4d2ef054f7f79e7d6b7
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T08:00:39Z
make paragraph title non-editable
commit 9b85e05e0ffc03653d64984d6e27f283b7b0e4fc
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T05:20:07Z
disable editor editing
normally it should be done on change of .revisionView however at that time editor isn't loaded yet
commit 7751b69f28d5113226fb36caff6becdb985cfb22
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:11:50Z
disable hotkeys
commit 81346e9313b2e5c7d5b1bd205df3d2000ffe9dfb
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:32:15Z
disable editing note name
commit 0946377d72f2dd2bdcec63b425396d2b2c965701
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:41:34Z
disable show/hide code in note action-bar
commit 46d67af60eab15099a22950e6e191995f92fcc34
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:43:20Z
disable show/hide output in note action bar
commit 1eea8ce1437e9d8232991c8a236ed911bdfe6cbe
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:47:25Z
don't show paragraph level hide editor button
commit aff02b95e1b42a9d5031e6f20e28a95e0adebab8
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:48:13Z
don't show paragraph level hide output buttton
commit e9d3ceb59136e7d51b1bb17b8574e18faa507c9d
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-27T07:07:11Z
disable edit on db click md interpreter
commit 4bfe5605deb7bc6d024ba2cbc6bed6ae3d850451
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-29T06:18:31Z
gray out editor on revision view
commit 2823142ac018cfe7f7ac85a9871e5b2072cfb384
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-29T12:45:01Z
add group span for ng-if
commit 06e2977de8fb0bc0e0b3981c1eac076ca4bfad04
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-29T12:47:07Z
check newValue for undefined
commit 1a5a6a7b74d7c8634237b9d2de04df2784cd1b28
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-29T15:50:55Z
render result change without commit
commit fa05bdb274bb88d7cddb36f11f3d94e33df37b4d
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-29T16:23:07Z
Merge branch 'master' into feat/revision-view
commit 84d2c5abe77a0e9e3695338dcafe38f5594be7e3
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-29T17:03:56Z
disable personalized mode button
commit 843abf4d73746fff8213cf3b4f1b5b9d4d1917e1
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-30T05:54:07Z
remove escaped single quote inside console
was failing to build, problem with removing console messages for prod
commit b3a78c77fb04eaddab06692836787342656de50a
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-30T22:05:25Z
dont show bingings, perms, hotkeys
commit efe09c08268a1df6a3013087cff7f18d5766a61d
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-31T05:42:42Z
enable report view without save
commit bbaf286d60a07d4f5f7dd7a55e0f836ab116507d
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-01-01T21:13:22Z
initialize looknfeel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov Is it WIP?
Then please feel free to add WIP in PR title and ping back, when it's ready for reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@Leemoonsoo thanks for testing, right i could reproduce it. So in that case probably it shouldn't be allowed to change graph properties or pivot settings while viewing revisions, right? because otherwise it's changing `note.json`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@AhyoungRyu actually i thought about it and couldn't find a reason why not let user change "Interpreter bindings" and "Note permissions" even in read-only mode, since they're still not able to run or edit. Do you think it's not common sense and confusing? Let me know what you think and we can change that easily. I wasn't also sure about it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@1ambda actually i've tried to reproduce [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) and even with git 2.11.0 wasn't able to do it. also from documentation [here](https://github.com/git/git/tree/master/Documentation/RelNotes) only from 2.11.0 `--allow-empty` commits was introduced, meaning only git versions 2.11+ could be a problem which is the most recent version and can be built from the source only for now. So I think reviewing this PR wouldn't much depend on git version, and [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) will be addressed separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@AhyoungRyu thanks for review, it wasn't intended behaviour actually, fixed in bbaf286d60a07d4f5f7dd7a55e0f836ab116507d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov How about disable "Interpreter binding" & "Note permission" buttons as well? Currently I can change the bound interpreters and note permission for the readonly-mode note.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@AhyoungRyu I think it makes sense and addressed your feedback. please check it out and let me know if it's fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1775
[ZEPPELIN-1745] View revisions in non-editable mode
### What is this PR for?
This is to make view of revisions non-editable
### What type of PR is it?
Improvement
### Todos
* [x] - disable action bar buttons
* [x] - disable per paragraph editing actions
* [x] - disable hotkeys
### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)
### How should this be tested?
1. initialize `GitNotebookRepo` by adding
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
in your `conf/zeppelin-env.sh`
2. go to any note and create few revisions using commit menu
3. then switch between revisions, during which you shouldn't be able to modify note
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/revision-view
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1775
----
commit 9db56ce63910d9738b2f7a874cab8e6570f16b49
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T04:20:22Z
change var name revisionDisabled -> revisionView
commit cd4e37072c8e154d551ed0c3361fff719a8d55ae
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:10:26Z
disable run all
commit 4f12a5bff226e7f871e810a254daeaea58f3b395
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:12:09Z
disable clear output
commit 5c9dd80a94ed990a41251c105a9c7b697bf3221c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:18:02Z
disable clone note
commit 49f0e15ff215e925657b2972ec7f239b64c2e104
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:19:21Z
disable export note
commit a05f355a96feb1cf7a424cda6775862439b974b0
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:22:14Z
disable revision commit
commit dbb680cda6df168030bda2eebcbcba1ca32c0b62
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:24:16Z
disable remove note
commit 00a0a247162791f2d332c0049ea469008b0e2177
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-16T08:25:42Z
disable scheduler
commit ee87a53805f9af9c657db24938e47ea409cfa258
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T04:21:51Z
disable + new paragraph
commit 9d73be4f8447596600b6f9723922d521f66d337f
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T04:26:37Z
don't show paragraph settings menu
commit 2cf28dce40b14bed547fe5727850093ef490a258
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T05:09:27Z
don't show run/cancel on paragraph
commit 45a11cf45e0531e3159eb399e0b3d07a305ccbc4
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-19T08:00:39Z
make paragraph title non-editable
commit e61e049efdf53b8c386f60f64444a11be3e43518
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T05:20:07Z
disable editor editing
normally it should be done on change of .revisionView however at that time editor isn't loaded yet
commit e78599cc82fc22e253ba4f52dcdd7482133bf6f1
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:11:50Z
disable hotkeys
commit 464d19f3b3cef37def095f8dd30e35c208041e6e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:32:15Z
disable editing note name
commit 4c71b6def9164f0675b2f9483a88fa01a7a26483
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:41:34Z
disable show/hide code in note action-bar
commit ebf2d2fd55a2042d65579ae0149a98a6de07b944
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:43:20Z
disable show/hide output in note action bar
commit 9b42e0ef9a503e8eebb3ca0fa9673ea10097e61e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:47:25Z
don't show paragraph level hide editor button
commit 6963abae404e4aadae6445c8990e23ba52d44183
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T06:48:13Z
don't show paragraph level hide output buttton
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov
>since they're still not able to run or edit
Yes you're right. I just thought it's not common sense as you told. Since the user can't run or edit anyway, but he can do sth in interpreter binding page and note permission setting page. That's why I suggested to block those features by disabling the icon buttons.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Tested and LGTM. Thanks @khalidhuseynov for the improvement.
Merge to master if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov Thanks for your consideration! Tested again and it works well as we said :)
And there is one minor thing in lookandfeel setting menu. Is this intended behavior?
- Head
<img width="191" alt="before" src="https://cloud.githubusercontent.com/assets/10060731/21576429/4727add2-cf72-11e6-96cc-d096bafbae40.png">
- Read-only mode
<img width="191" alt="screen shot 2016-12-31 at 3 49 53 pm" src="https://cloud.githubusercontent.com/assets/10060731/21576423/0b1be682-cf72-11e6-88d1-a5b662b632e4.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov Thanks for reply!
> yeah that's good point, do you have something in mind regarding it? i was thinking whether it should be more of a mode switch (say different mode added in addition to report mode, etc) or just represent visually (say gray out editor background like when running note), or something else.
We might use css transparent property to let user know this paragraphs are readonly like in running interpreters
<img width="707" alt="screen shot 2016-12-28 at 12 54 15 pm" src="https://cloud.githubusercontent.com/assets/4968473/21513606/0624d15a-ccfe-11e6-826c-fe2a1feb79f3.png">
> thanks for testing, addressed under 50e1472. please check it out.
I checked and works well!
> actually we have issue regarding this one to have GitNotebookRepo as default repo, in that case we don't need to hide it i believe.
Glad to hear that! Actually i want it to be default \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
FYI - you can install 2.11.0 using brew.
@khalidhuseynov is right, that should be handled in the separate issue. Let's talk about it on ZEPPELIN-1737.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Works well as described. Here are few things to consider.
- It would be great if there is a signal (whatever) so let user know that this is committed version of note. It's confusing at first for me.
- Enabling and modifying committed notes affects on the HEAD note. What about disabling **double click** to committed paragraphs (you can check this in screenshot below)
- the last one is not directly related with this issue. But It would be good to hide git notebook related icons if we are not using `GitNotebookRepo`
<img width="398" alt="screen shot 2016-12-23 at 6 50 35 pm" src="https://cloud.githubusercontent.com/assets/4968473/21451287/4a921aa2-c941-11e6-9dae-a56770ce06cf.png">
Thanks for implementing great feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Glad to help reviewing this PR :)
Let me check and then give you feedbacks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1775
For other reviewers
- If you are using git 2.10+, Notebook revision feature will not work. Checkout [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Tested this branch and found
1. select HEAD
2. and then switch to any revision.
3. change height of graph or change pivot setting
4. HEAD is changed by 3)
@khalidhuseynov could you check scenario above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1775
good feature!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@1ambda thanks for review. answers in order:
> It would be great if there is a signal (whatever) so let user know that this is committed version of note. It's confusing at first for me. (Assume that someone get the link for a committed note. He might wonder why he can not modify this note)
yeah that's good point, do you have something in mind regarding it? i was thinking whether it should be more of a mode switch (say different mode added in addition to report mode, etc) or just represent visually (say gray out editor background like when running note), or something else.
> Enabling and modifying committed notes affects on the HEAD note. What about disabling double click to committed paragraphs (you can check this in screenshot below)
thanks for testing, addressed under 50e1472957446f7f907e2ea8b8eb19f4347eac8b. please check it out.
> the last one is not directly related with this issue. But It would be good to hide git notebook icons if we are other notebook repo rather than GitNotebookRepo.
actually we have issue regarding this one to have `GitNotebookRepo` as default repo, in that case we don't need to hide it i believe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@bzz it's ready now, also /cc @cloverhearts @1ambda to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1775
Tested again and now I can see the text in the looknfeel dropdown menu of non-editable mode note. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---