You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/06 18:31:18 UTC
[GitHub] [incubator-tvm] soiferj opened a new pull request #5002: [Runtime]
Export GraphRuntime in tvm_runtime.dll
soiferj opened a new pull request #5002: [Runtime] Export GraphRuntime in tvm_runtime.dll
URL: https://github.com/apache/incubator-tvm/pull/5002
Currently, the GraphRuntime class is unusable in C++ from Windows. This change exposes the class.
@jmorrill would you be able to take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] jmorrill commented on issue #5002: [Runtime] Export
GraphRuntime in tvm_runtime.dll
Posted by GitBox <gi...@apache.org>.
jmorrill commented on issue #5002: [Runtime] Export GraphRuntime in tvm_runtime.dll
URL: https://github.com/apache/incubator-tvm/pull/5002#issuecomment-595914989
@soiferj This is where it gets a little embarrassing for me. I've never been able to get a good link to tvm_runtime.dll, even using tvm_runtime_pack.cc...So like killing a a fly with a rocket launcher, I work off this CMake change:
https://github.com/jmorrill/tvm/blob/cc0b1e750512b690bbecc9e98a30f7a9945843b1/CMakeLists.txt#L282 aka "export everything"
I can try again to get this tvm_runtime_pack.cc method to give me a link and then see if your fix solves it :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] jmorrill edited a comment on issue #5002: [Runtime]
Export GraphRuntime in tvm_runtime.dll
Posted by GitBox <gi...@apache.org>.
jmorrill edited a comment on issue #5002: [Runtime] Export GraphRuntime in tvm_runtime.dll
URL: https://github.com/apache/incubator-tvm/pull/5002#issuecomment-595914989
@soiferj This is where it gets a little embarrassing for me. I've never been able to get a good link to tvm_runtime.dll, even using tvm_runtime_pack.cc without some other changes...So like killing a a fly with a rocket launcher, I work off this CMake change:
https://github.com/jmorrill/tvm/blob/cc0b1e750512b690bbecc9e98a30f7a9945843b1/CMakeLists.txt#L282 aka "export everything"
I can try again to get this tvm_runtime_pack.cc method to give me a link and then see if your fix solves it :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] soiferj commented on issue #5002: [Runtime] Export
GraphRuntime in tvm_runtime.dll
Posted by GitBox <gi...@apache.org>.
soiferj commented on issue #5002: [Runtime] Export GraphRuntime in tvm_runtime.dll
URL: https://github.com/apache/incubator-tvm/pull/5002#issuecomment-595961932
Awesome! Thanks @jmorrill. Would you mind approving the PR if it looks good? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] jmorrill commented on issue #5002: [Runtime] Export
GraphRuntime in tvm_runtime.dll
Posted by GitBox <gi...@apache.org>.
jmorrill commented on issue #5002: [Runtime] Export GraphRuntime in tvm_runtime.dll
URL: https://github.com/apache/incubator-tvm/pull/5002#issuecomment-595952667
@soiferj Thank you. This fixes my need to have `set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)` and can re-enable INTERPROCEDURAL_OPTIMIZATION on it.
tvm_runtime.dll links fine on VS2019!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #5002: [Runtime] Export
GraphRuntime in tvm_runtime.dll
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5002: [Runtime] Export GraphRuntime in tvm_runtime.dll
URL: https://github.com/apache/incubator-tvm/pull/5002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services