[GitHub] [hbase] ndimiduk commented on a change in pull request #859: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #859: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…
URL: https://github.com/apache/hbase/pull/859#discussion_r349826991
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailover.java
 ##########
 @@ -116,7 +116,7 @@ public void test() throws Exception {
         .filter(p -> (p instanceof ServerCrashProcedure) &&
             ((ServerCrashProcedure) p).getServerName().equals(SERVER_FOR_TEST)).findAny();
     assertTrue("Should have one SCP for " + SERVER_FOR_TEST, procedure.isPresent());
-    assertFalse("Submit the SCP for the same serverName " + SERVER_FOR_TEST + " which should fail",
+    assertTrue("Submit the SCP for the same serverName " + SERVER_FOR_TEST + " which should fail",
 
 Review comment:
   Huh? why does this assertion flip?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services