[GitHub] [spark] HyukjinKwon edited a comment on pull request #31436: [SPARK-34327][BUILD] Strip passwords from inlining into build information while releasing.

[GitBox <gi...@apache.org>]

HyukjinKwon edited a comment on pull request #31436:
URL: https://github.com/apache/spark/pull/31436#issuecomment-772224640


   @ScrapCodes, just to clarify, this doesn't fix an actual issue but potential issue, is it correct? When we build the distribution, we don't use the URL with a password IIRC so `git config --get remote.origin.url` wouldn't contain the password. And the code you pointed out is when we push a tag.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org