You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/30 13:46:28 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6170: Simplify HashJoin memory accounting

tustvold commented on code in PR #6170:
URL: https://github.com/apache/arrow-datafusion/pull/6170#discussion_r1181234436


##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -113,8 +109,6 @@ pub struct HashJoinExec {
     schema: SchemaRef,
     /// Build-side data
     left_fut: OnceAsync<JoinLeftData>,
-    /// Operator-level memory reservation for left data
-    reservation: SharedOptionalMemoryReservation,

Review Comment:
   This reservation is instead moved into JoinLeftData



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org