You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2016/11/04 22:53:01 UTC
incubator-mynewt-newt git commit: MYNEWT-470 - Fix newt test
Repository: incubator-mynewt-newt
Updated Branches:
refs/heads/develop 035421ea9 -> 0fa789525
MYNEWT-470 - Fix newt test
My previous commit for this fix assumed the presence of an app builder.
This is an invalid assumption when packages are being unit tested. Now,
only clean artifacts when Build() gets called, rathe than PrepBuild().
Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/commit/0fa78952
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/tree/0fa78952
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/diff/0fa78952
Branch: refs/heads/develop
Commit: 0fa789525153a297bc1e1375cd652fbfdd73962c
Parents: 035421e
Author: Christopher Collins <cc...@apache.org>
Authored: Fri Nov 4 15:51:23 2016 -0700
Committer: Christopher Collins <cc...@apache.org>
Committed: Fri Nov 4 15:51:23 2016 -0700
----------------------------------------------------------------------
newt/builder/build.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/blob/0fa78952/newt/builder/build.go
----------------------------------------------------------------------
diff --git a/newt/builder/build.go b/newt/builder/build.go
index b01e78c..6e2f9b5 100644
--- a/newt/builder/build.go
+++ b/newt/builder/build.go
@@ -351,8 +351,6 @@ func (b *Builder) PrepBuild() error {
b.logDepInfo()
- b.CleanArtifacts()
-
// Populate the base set of compiler flags. Flags from the following
// packages get applied to every source file:
// * target
@@ -442,6 +440,8 @@ func (b *Builder) addSysinitBpkg() (*BuildPackage, error) {
}
func (b *Builder) Build() error {
+ b.CleanArtifacts()
+
// Build the packages alphabetically to ensure a consistent order.
bpkgs := b.sortedBuildPackages()