You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by mfenniak <gi...@git.apache.org> on 2016/07/19 22:13:00 UTC
[GitHub] kafka pull request #1639: MINOR: Remove slf4j-log4j from kafka-streams compi...
GitHub user mfenniak opened a pull request:
https://github.com/apache/kafka/pull/1639
MINOR: Remove slf4j-log4j from kafka-streams compile dependencies
As kafka-streams is intended to be used by applications that may or may not wish to use log4j, kafka-streams itself should not have a dependency on a concrete log framework. This change adapts the dependencies to be API-only for compile, and framework-specific for the test runtime only.
I read through the [Contributing Code Guidelines](https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes) and interpreted this as a trivial change that doesn't require a Jira ticket. Please let me know if I've interpreted that wrongly.
This contribution is my original work and I license the work to the project under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mfenniak/kafka fix-slf4j-dependency-for-streams
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1639
----
commit a466eb14744fbaae9e0ce2188cf30c17e0a6d517
Author: Mathieu Fenniak <ma...@encouragemarketing.com>
Date: 2016-07-19T22:02:15Z
Remove slf4j-log4j from kafka-streams dependencies
As kafka-streams is intended to be used by client applications that may or may
not wish to use log4j, kafka-streams itself should not have a dependency on a
concrete log framework. This change adapts the dependencies to be API-only for
compile, and framework-specific for the test runtime.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #1639: MINOR: Remove slf4j-log4j from kafka-streams compi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---