You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/04/02 12:12:35 UTC
svn commit: r1789875 - in /ofbiz/branches/release16.11: ./
applications/content/widget/content/ContentForms.xml
Author: jleroux
Date: Sun Apr 2 12:12:35 2017
New Revision: 1789875
URL: http://svn.apache.org/viewvc?rev=1789875&view=rev
Log:
"Applied fix from trunk framework for revision: 1789874 "
------------------------------------------------------------------------
r1789874 | jleroux | 2017-04-02 14:11:44 +0200 (dim. 02 avr. 2017) | 29 lignes
Fixed: Sort Links in Lookup for Owner Content Id causes unwanted behaviour on
Find Content page
(OFBIZ-9279)
How to reproduce :
1. Log in the Content component
2. Go to the Content tab. https://localhost:8443/content/control/findContent
3. In the search form, open the lookup of the field ' Owner Content Id '
4. Click on any of the table header links to sort the table. Results will be
displayed on a new unstyled window closing the Lookup dialog.
Problem:
1. Lookup dialog for ownerContentId uses "ListLookupContent" form to list
Content records.
2. "ListLookupContent" form extends "ListContent" form for all the fields.
3. Sort-field is set to true in "ListContent" form for all the fields.
4. Sort-field adds <a> hyperlink to "LookupContent" .
5. When clicked <a> link it moves to a new page and doesn't renders the response
in the Lookup dialog.
Solution:
First of all it is a lookup to select ownerContentId so as the pattern followed
in other lookups in OFBiz it should not have any sort-fields.
To set it false, it should be overridden. If all fields needs to be overridden
it is better not to extend "ListContent" form and add these fields right away.
Apart from that added 'header-row-style="header-row-2"' to form.
Thanks: Aditya Sharma
------------------------------------------------------------------------
Modified:
ofbiz/branches/release16.11/ (props changed)
ofbiz/branches/release16.11/applications/content/widget/content/ContentForms.xml
Propchange: ofbiz/branches/release16.11/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sun Apr 2 12:12:35 2017
@@ -10,5 +10,5 @@
/ofbiz/branches/json-integration-refactoring:1634077-1635900
/ofbiz/branches/multitenant20100310:921280-927264
/ofbiz/branches/release13.07:1547657
-/ofbiz/ofbiz-framework/trunk:1783202,1783388,1784549,1784558,1784708,1785882,1785925,1786079,1786214,1786525,1787047,1787133,1787176,1787535,1787906-1787911,1787949,1789665,1789863
+/ofbiz/ofbiz-framework/trunk:1783202,1783388,1784549,1784558,1784708,1785882,1785925,1786079,1786214,1786525,1787047,1787133,1787176,1787535,1787906-1787911,1787949,1789665,1789863,1789874
/ofbiz/trunk:1770481,1770490,1770540,1771440,1771448,1771516,1771935,1772346,1772880,1774772,1775441,1779724,1780659,1781109,1781125,1781979,1782498,1782520
Modified: ofbiz/branches/release16.11/applications/content/widget/content/ContentForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release16.11/applications/content/widget/content/ContentForms.xml?rev=1789875&r1=1789874&r2=1789875&view=diff
==============================================================================
--- ofbiz/branches/release16.11/applications/content/widget/content/ContentForms.xml (original)
+++ ofbiz/branches/release16.11/applications/content/widget/content/ContentForms.xml Sun Apr 2 12:12:35 2017
@@ -117,25 +117,35 @@ under the License.
<form name="LookupContent" target="LookupContent" title="" type="single" extends="FindContent" header-row-style="header-row" default-table-style="basic-table"/>
- <form name="ListLookupContent" extends="ListContent" type="list" list-name="listIt" paginate-target="LookupContent"
- odd-row-style="alternate-row" default-table-style="basic-table hover-bar">
+ <form name="ListLookupContent" type="list" list-name="listIt" paginate-target="LookupContent"
+ odd-row-style="alternate-row" header-row-style="header-row-2" default-table-style="basic-table hover-bar">
<actions>
<set field="parameters.sortField" from-field="parameters.sortField" default-value="contentId"/>
- <call-parent-actions/>
+ <service service-name="performFind" result-map="result" result-map-list="listIt">
+ <field-map field-name="inputFields" from-field="parameters"/>
+ <field-map field-name="entityName" value="Content"/>
+ <field-map field-name="orderBy" from-field="parameters.sortField"/>
+ <field-map field-name="viewIndex" from-field="viewIndex"/>
+ <field-map field-name="viewSize" from-field="viewSize"/>
+ </service>
</actions>
<field name="contentId" widget-style="smallSubmit">
<hyperlink description="${contentId}" target="javascript:set_value('${contentId}')" also-hidden="false" target-type="plain"/>
</field>
<field name="contentName"><display/></field>
- <field name="mimeTypeId"><display/></field>
- <field name="dataResourceId" use-when="dataResourceId!=null" title="${uiLabelMap.ContentDataResourceId}" sort-field="true">
+ <field name="description"><display/></field>
+ <field name="statusId" title="${uiLabelMap.CommonStatus}"><display-entity entity-name="StatusItem"></display-entity></field>
+ <field name="localeString"><display-entity entity-name="CountryCode" key-field-name="countryCode" description="${countryName}[${countryCode}]"></display-entity></field>
+ <field name="contentTypeId" title="${uiLabelMap.ContentType}"><display-entity entity-name="ContentType"></display-entity></field>
+ <field name="mimeTypeId" title="${uiLabelMap.ContentMimeType}"><display-entity entity-name="MimeType"></display-entity></field>
+ <field name="dataResourceId" title="${uiLabelMap.FormFieldTitle_dataResourceTitle}" use-when="dataResourceId==null"><display/></field>
+ <field name="dataResourceId" title="${uiLabelMap.FormFieldTitle_dataResourceTitle}" use-when="dataResourceId!=null">
<display-entity entity-name="DataResource" key-field-name="dataResourceId" description="${dataResourceName}"/>
</field>
- <field name="ownerContentId" use-when="ownerContentId!=null" title="${uiLabelMap.FormFieldTitle_ownerContentId}" sort-field="true">
+ <field name="ownerContentId" use-when="ownerContentId==null" title="${uiLabelMap.FormFieldTitle_ownerContentId}"><display/></field>
+ <field name="ownerContentId" use-when="ownerContentId!=null" title="${uiLabelMap.FormFieldTitle_ownerContentId}">
<display-entity entity-name="Content" key-field-name="contentId" description="${contentName}"/>
</field>
- <field name="createdByUserLogin"><ignored/></field>
- <on-event-update-area event-type="paginate" area-id="search-results" area-target=""/>
</form>
<form name="EditContent" target="updateContent" title="" type="single" default-map-name="currentValue"