You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2010/10/16 12:17:22 UTC
[jira] Created: (WICKET-3111) TransparentWebMarkupContainer appears
magically for html elements without 'wicket:id' but with 'href' attribute
TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
----------------------------------------------------------------------------------------------------------------
Key: WICKET-3111
URL: https://issues.apache.org/jira/browse/WICKET-3111
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M2.1
Reporter: Martin Grigorov
If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3111) TransparentWebMarkupContainer
appears magically for html elements without 'wicket:id' but with 'href'
attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3111:
---------------------------------------
Assignee: Juergen Donnerstag
Hi Juergen,
Can you review the attached patch?
All unit tests pass successfully.
The quickstart works OK on 1.4-SNAPSHOT without any modifications.
I'll transform the quickstart app to unit test in the meantime.
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Juergen Donnerstag
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3111) TransparentWebMarkupContainer
appears magically for html elements without 'wicket:id' but with 'href'
attribute
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921813#action_12921813 ]
Hudson commented on WICKET-3111:
--------------------------------
Integrated in Apache Wicket 1.5.x #412 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/412/])
WICKET-3111 TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
Add test case for Panel with <a href="..."/> for which an auto component is added (TransparentWebMarkupContainer) and this causes that the any inner ComponentTags cannot be found with MarkupFragment#find(String childId)
fixed: TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
Issue: WICKET-3111
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M3
>
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3111) TransparentWebMarkupContainer appears
magically for html elements without 'wicket:id' but with 'href' attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3111:
------------------------------------
Attachment: wicket-3111.tgz
Attach a quickstart application.
Just change
<a href="something/else"> to
<a ahref="something/else">
and the unit test will pass.
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Attachments: wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3111) TransparentWebMarkupContainer
appears magically for html elements without 'wicket:id' but with 'href'
attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921805#action_12921805 ]
Martin Grigorov commented on WICKET-3111:
-----------------------------------------
Thanks!
One more review, please: org.apache.wicket.markupFragments.MarkupFragmentTest.testPanelWithAutoComponent()
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M3
>
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3111) TransparentWebMarkupContainer
appears magically for html elements without 'wicket:id' but with 'href'
attribute
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921804#action_12921804 ]
Juergen Donnerstag commented on WICKET-3111:
--------------------------------------------
The patch is exactly right. I was about to commit exactly that.
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Juergen Donnerstag
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3111) TransparentWebMarkupContainer appears
magically for html elements without 'wicket:id' but with 'href' attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3111:
------------------------------------
Attachment: WICKET-3111.patch
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3111) TransparentWebMarkupContainer
appears magically for html elements without 'wicket:id' but with 'href'
attribute
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921811#action_12921811 ]
Juergen Donnerstag commented on WICKET-3111:
--------------------------------------------
They are looking good => applied. Thanks a lot for the effort.
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M3
>
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3111) TransparentWebMarkupContainer
appears magically for html elements without 'wicket:id' but with 'href'
attribute
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921817#action_12921817 ]
Hudson commented on WICKET-3111:
--------------------------------
Integrated in Apache Wicket 1.5.x #413 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/413/])
test cases for IMarkupFragment, getAssociatedMarkup(), getMarkup() and getMarkup(child). Thanks Martin
Issue: WICKET-3111
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M3
>
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3111)
TransparentWebMarkupContainer appears magically for html elements without
'wicket:id' but with 'href' attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921662#action_12921662 ]
Martin Grigorov edited comment on WICKET-3111 at 10/16/10 6:25 AM:
-------------------------------------------------------------------
Attach a quickstart application.
In MyPanel.html just change
<a href="something/else"> to
<a ahref="something/else">
and the unit test will pass.
was (Author: mgrigorov):
Attach a quickstart application.
Just change
<a href="something/else"> to
<a ahref="something/else">
and the unit test will pass.
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Attachments: wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3111) TransparentWebMarkupContainer
appears magically for html elements without 'wicket:id' but with 'href'
attribute
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-3111.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M3
> TransparentWebMarkupContainer appears magically for html elements without 'wicket:id' but with 'href' attribute
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3111
> URL: https://issues.apache.org/jira/browse/WICKET-3111
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M3
>
> Attachments: WICKET-3111.patch, wicket-3111.tgz
>
>
> If in a Panel there is a <a> element with specified 'href' attribute but without 'wicket:id' then Wicket creates automatically TransparentWebMarkupContainer (respectfully a ComponentTag for it) for it and this causes problems with finding the inner real ComponentTag's.
> See attached quickstart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.