[GitHub] [spark] MaxGekk commented on a diff in pull request #36500: [WIP][SQL] Wrap asserts/illegal state exceptions by the INTERNAL_ERROR exception

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #36500:
URL: https://github.com/apache/spark/pull/36500#discussion_r871181464


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala:
##########
@@ -762,10 +763,11 @@ class WholeStageCodegenSuite extends QueryTest with SharedSparkSession
           "SELECT AVG(v) FROM VALUES(1) t(v)",
           // Tet case with keys
           "SELECT k, AVG(v) FROM VALUES((1, 1)) t(k, v) GROUP BY k").foreach { query =>
-          val errMsg = intercept[IllegalStateException] {
+          val e = intercept[SparkException] {
             sql(query).collect

Review Comment:
   It throws `IllegalStateException` intentionally for testing, see https://github.com/apache/spark/blob/725df02d3b9ec214a71ababb52d1a9b97997ead8/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregateCodegenSupport.scala#L345-L347 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org