Re: [PR] [core] Give SeekablePositionedMappingInputStream to FileIndexer, allow FileIndexer to seek and skip if they need to. [paimon]

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #3406:
URL: https://github.com/apache/paimon/pull/3406#discussion_r1624146966


##########
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexer.java:
##########
@@ -29,7 +30,7 @@ public interface FileIndexer {
 
     FileIndexWriter createWriter();
 
-    FileIndexReader createReader(byte[] serializedBytes);
+    FileIndexReader createReader(SeekablePositionedMappingInputStream inputStream);

Review Comment:
   Does here need `SeekablePositionedMappingInputStream`? Can it just be `SeekableInputStream`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org