You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/29 15:42:58 UTC
[GitHub] [hive] hmangla98 opened a new pull request #2133: Set repl.source.for property in the db if db is under replication in incremental dump.
hmangla98 opened a new pull request #2133:
URL: https://github.com/apache/hive/pull/2133
What changes were proposed in this pull request?
Set repl.source.for property in the db if db is under replication in incremental dump.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha merged pull request #2133: HIVE-24953: Set repl.source.for property in the db if db is under replication in incremental dump.
Posted by GitBox <gi...@apache.org>.
aasha merged pull request #2133:
URL: https://github.com/apache/hive/pull/2133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] hmangla98 commented on a change in pull request #2133: HIVE-24953: Set repl.source.for property in the db if db is under replication in incremental dump.
Posted by GitBox <gi...@apache.org>.
hmangla98 commented on a change in pull request #2133:
URL: https://github.com/apache/hive/pull/2133#discussion_r605367734
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -1026,8 +1015,27 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive hiveDb)
}
}
- private void updateReplSourceFor(Hive hiveDb, String dbName, Database db,
- String value) throws HiveException {
+ private void checkReplSourceFor(Hive hiveDb, String dbName, Database db) throws HiveException {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #2133: HIVE-24953: Set repl.source.for property in the db if db is under replication in incremental dump.
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #2133:
URL: https://github.com/apache/hive/pull/2133#discussion_r605364903
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -1026,8 +1015,27 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive hiveDb)
}
}
- private void updateReplSourceFor(Hive hiveDb, String dbName, Database db,
- String value) throws HiveException {
+ private void checkReplSourceFor(Hive hiveDb, String dbName, Database db) throws HiveException {
Review comment:
rename to setReplSourceFor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org