You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2023/06/16 20:16:34 UTC

[GitHub] [arrow] laurentgo opened a new pull request, #36132: MINOR: [Java] Fix dependencies scope in flight-sql module

laurentgo opened a new pull request, #36132:
URL: https://github.com/apache/arrow/pull/36132

   ### Rationale for this change
   flight-sql module advertises dependencies which are not actually used by the published code, causing those dependencies to show up in downstream projects.
   
   ### What changes are included in this PR?
   Fix dependencies scope in flight-sql module:
   * move hamcrest to test scope as it is only used during unit tests
   * add optional flag for commons-cli as it is only used in the example class
   
   ### Are these changes tested?
   No new test. Confirming that there's no build issue
   
   ### Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm merged pull request #36132: MINOR: [Java] Fix dependencies scope in flight-sql module

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #36132:
URL: https://github.com/apache/arrow/pull/36132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36132: MINOR: [Java] Fix dependencies scope in flight-sql module

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36132:
URL: https://github.com/apache/arrow/pull/36132#issuecomment-1596459571

   Conbench analyzed the 6 benchmark runs on commit `565b9571`.
   
   There were 9 benchmark results indicating a performance regression:
   
   - Commit Run on `arm64-t4g-linux-compute` at [2023-06-17 00:16:09Z](http://conbench.ursa.dev/compare/runs/38149d9135a44674aa0e57df6c8a511e...71d27fe230174218af06fb9c883e8c16/)
     - [params=complex_expression/batch_size:100000/null_prob:0/bool_true_prob:50/real_time, source=cpp-micro, suite=arrow-acero-filter-benchmark](http://conbench.ursa.dev/compare/benchmarks/0648cda38d117d1f8000f5dd267b0404...0648cfbce31475528000bde755599dc1)
   
   - Commit Run on `arm64-m6g-linux-compute` at [2023-06-17 01:40:08Z](http://conbench.ursa.dev/compare/runs/6dcb45b1cc8d421a91363e15d663af35...8db5cbc9f70344ffb3d867019923bbb7/)
     - [source=cpp-micro, suite=arrow-type-benchmark](http://conbench.ursa.dev/compare/benchmarks/0648cfc9cad075328000874b654a4140...0648d0eff4dd7047800006e3abe3b43d)
   - and 7 more (see the report linked below)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/14361734495) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org