You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "byronellis (via GitHub)" <gi...@apache.org> on 2023/01/27 00:03:19 UTC
[GitHub] [beam] byronellis opened a new pull request, #25196: Schema convenience functions
byronellis opened a new pull request, #25196:
URL: https://github.com/apache/beam/pull/25196
While spending a bunch of times working with writing down schemas in Java recently one of the things that kept coming up was the need to make fields nullable more often than not. While there are convenience functions for NOT NULL fields there aren't equivalent nullable versions. This is just a small PR that adds equivalent convenience methods to the schema builder for nullable fields.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] byronellis commented on pull request #25196: Schema convenience functions
Posted by "byronellis (via GitHub)" <gi...@apache.org>.
byronellis commented on PR #25196:
URL: https://github.com/apache/beam/pull/25196#issuecomment-1405856053
Updated to use addNullableField
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #25196: Schema convenience functions
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #25196:
URL: https://github.com/apache/beam/pull/25196#issuecomment-1405884380
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #25196: Schema convenience functions
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #25196:
URL: https://github.com/apache/beam/pull/25196#issuecomment-1406874677
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a diff in pull request #25196: Schema convenience functions
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on code in PR #25196:
URL: https://github.com/apache/beam/pull/25196#discussion_r1088466944
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java:
##########
@@ -142,82 +142,163 @@ public Builder addByteField(String name) {
return this;
}
+ public Builder addNullableByteField(String name) {
+ fields.add(Field.nullable(name, FieldType.BYTE));
Review Comment:
Probably we should use the existing "addNullableField" function when implementing these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #25196: Schema convenience functions
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj merged PR #25196:
URL: https://github.com/apache/beam/pull/25196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] byronellis commented on pull request #25196: Schema convenience functions
Posted by "byronellis (via GitHub)" <gi...@apache.org>.
byronellis commented on PR #25196:
URL: https://github.com/apache/beam/pull/25196#issuecomment-1406973150
Yay, everything passed finally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] byronellis commented on a diff in pull request #25196: Schema convenience functions
Posted by "byronellis (via GitHub)" <gi...@apache.org>.
byronellis commented on code in PR #25196:
URL: https://github.com/apache/beam/pull/25196#discussion_r1088468571
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java:
##########
@@ -142,82 +142,163 @@ public Builder addByteField(String name) {
return this;
}
+ public Builder addNullableByteField(String name) {
+ fields.add(Field.nullable(name, FieldType.BYTE));
Review Comment:
sure, no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org