You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/01/31 15:30:08 UTC

[GitHub] [yunikorn-core] craigcondit commented on pull request #498: [YUNIKORN-1549][core] Introduce a config to specify what attribute to use as instance type

craigcondit commented on PR #498:
URL: https://github.com/apache/yunikorn-core/pull/498#issuecomment-1410588873

   Please add a constant to the SI for the configuration key and default value. There is NO need to change the shim at all - every configuration setting in the configmap is passed along to the core as of v1.2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org