[GitHub] [druid] kfaraz commented on a change in pull request #12223: Method to specify eternity in the scan query builder

[GitBox <gi...@apache.org>]

kfaraz commented on a change in pull request #12223:
URL: https://github.com/apache/druid/pull/12223#discussion_r809062338



##########
File path: processing/src/main/java/org/apache/druid/query/Druids.java
##########
@@ -869,6 +860,16 @@ public ScanQueryBuilder intervals(QuerySegmentSpec q)
       return this;
     }
 
+    /**
+     * Convenience method for an interval over all time.

Review comment:
       Nit: maybe link the to the `intervals()` method in this javadoc to clarify that it is a syntax sugar for that method.

##########
File path: processing/src/main/java/org/apache/druid/query/Druids.java
##########
@@ -869,6 +860,16 @@ public ScanQueryBuilder intervals(QuerySegmentSpec q)
       return this;
     }
 
+    /**
+     * Convenience method for an interval over all time.
+     */
+    public ScanQueryBuilder eternity()

Review comment:
       Would a name like `intervalEternity` or `withIntervalEternity` be more representative of what we are trying to do here?
   
   The other methods are names of the params that the Scan query needs e.g. `dataSource`, `virtualColumns`, whereas `eternity` is a value of the param `intervals`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org