You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Mohammad Islam <mi...@yahoo.com> on 2014/02/13 10:28:35 UTC

Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-6024
    https://issues.apache.org/jira/browse/HIVE-6024


Repository: hive-git


Description
-------

Excerpt from the JIRA:
"Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."


Diffs
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e59decc 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java d13d0b0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java a22a15f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 

Diff: https://reviews.apache.org/r/18065/diff/


Testing
-------

Ran some existing q tests with "LOAD DATA LOCAL INPATH".


Thanks,

Mohammad Islam


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Mohammad Islam <mi...@yahoo.com>.

> On Feb. 27, 2014, 5:54 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2340
> > <https://reviews.apache.org/r/18065/diff/3/?file=504442#file504442line2340>
> >
> >     Should this be srcs = srcFs.globStatus(srcf) instead ?

Done


> On Feb. 27, 2014, 5:54 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2238
> > <https://reviews.apache.org/r/18065/diff/3/?file=504442#file504442line2238>
> >
> >     Though its not super clear from https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML it seems to imply that source can be dir. Can you test the current behavior? ie whether loading from local dir is allowed or not currently. If it is allowed, we need to mimic that behavior here.

Yes. Source could be local dir. It works in current version as well.
I'm adding a new .q test case.


- Mohammad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/#review35637
-----------------------------------------------------------


On Feb. 26, 2014, 8:20 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18065/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 8:20 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6024
>     https://issues.apache.org/jira/browse/HIVE-6024
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Excerpt from the JIRA:
> "Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
> 
> Diff: https://reviews.apache.org/r/18065/diff/
> 
> 
> Testing
> -------
> 
> Ran some existing q tests with "LOAD DATA LOCAL INPATH".
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/#review35637
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/18065/#comment66268>

    Though its not super clear from https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML it seems to imply that source can be dir. Can you test the current behavior? ie whether loading from local dir is allowed or not currently. If it is allowed, we need to mimic that behavior here.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/18065/#comment66267>

    Should this be srcs = srcFs.globStatus(srcf) instead ?


- Ashutosh Chauhan


On Feb. 26, 2014, 8:20 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18065/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 8:20 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6024
>     https://issues.apache.org/jira/browse/HIVE-6024
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Excerpt from the JIRA:
> "Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
> 
> Diff: https://reviews.apache.org/r/18065/diff/
> 
> 
> Testing
> -------
> 
> Ran some existing q tests with "LOAD DATA LOCAL INPATH".
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/
-----------------------------------------------------------

(Updated March 11, 2014, 8:49 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

uploading the correct patch file.


Bugs: HIVE-6024
    https://issues.apache.org/jira/browse/HIVE-6024


Repository: hive-git


Description
-------

Excerpt from the JIRA:
"Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java a190155 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e10bdb4 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 3dd0f6f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
  ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
  ql/src/test/results/clientpositive/input4.q.out 9b169f9 
  ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/stats11.q.out ce1197e 
  ql/src/test/results/clientpositive/stats3.q.out a14e449 

Diff: https://reviews.apache.org/r/18065/diff/


Testing
-------

Ran some existing q tests with "LOAD DATA LOCAL INPATH".


Thanks,

Mohammad Islam


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/
-----------------------------------------------------------

(Updated March 11, 2014, 8:37 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Addressed test failure,


Bugs: HIVE-6024
    https://issues.apache.org/jira/browse/HIVE-6024


Repository: hive-git


Description
-------

Excerpt from the JIRA:
"Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java a190155 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e10bdb4 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 3dd0f6f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
  ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
  ql/src/test/results/clientpositive/input4.q.out 9b169f9 
  ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/stats11.q.out ce1197e 
  ql/src/test/results/clientpositive/stats3.q.out a14e449 

Diff: https://reviews.apache.org/r/18065/diff/


Testing
-------

Ran some existing q tests with "LOAD DATA LOCAL INPATH".


Thanks,

Mohammad Islam


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/
-----------------------------------------------------------

(Updated March 7, 2014, 10:21 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Addressed unit test failures.
Please check 3 .q.out changes. Those were required because this patch removes one extra copy phase.


Bugs: HIVE-6024
    https://issues.apache.org/jira/browse/HIVE-6024


Repository: hive-git


Description
-------

Excerpt from the JIRA:
"Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java a190155 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 9ec22ca 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
  ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
  ql/src/test/results/clientpositive/input4.q.out 9b169f9 
  ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/stats11.q.out ce1197e 
  ql/src/test/results/clientpositive/stats3.q.out a14e449 

Diff: https://reviews.apache.org/r/18065/diff/


Testing
-------

Ran some existing q tests with "LOAD DATA LOCAL INPATH".


Thanks,

Mohammad Islam


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Carl Steinbach <cw...@apache.org>.

> On Feb. 28, 2014, 10:11 a.m., Carl Steinbach wrote:
> > ql/src/test/queries/clientpositive/load_local_dir_test.q, line 2
> > <https://reviews.apache.org/r/18065/diff/4/?file=506815#file506815line2>
> >
> >     This test passes with or without the rest of the patch. It doesn't seem to demonstrate any change in behavior.
> 
> Mohammad Islam wrote:
>     Yes. This JIRA is to change the hive internal data movement for HQL 'LOAD LOCAL ...' -- no new feature is added.
>     I understood Ashutosh's concern to verify whether this new internal change would break the HQL like LOAD LOCAL from a *directory*. I didn't find any existing .q file that covered this test. Therefore added a new one to make sure existing behavior doesn't break.
>

Ok, makes sense. Thanks for the explanation.


- Carl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/#review35771
-----------------------------------------------------------


On Feb. 28, 2014, 8:03 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18065/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 8:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6024
>     https://issues.apache.org/jira/browse/HIVE-6024
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Excerpt from the JIRA:
> "Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
>   ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
>   ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18065/diff/
> 
> 
> Testing
> -------
> 
> Ran some existing q tests with "LOAD DATA LOCAL INPATH".
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Mohammad Islam <mi...@yahoo.com>.

> On Feb. 28, 2014, 10:11 a.m., Carl Steinbach wrote:
> > ql/src/test/queries/clientpositive/load_local_dir_test.q, line 2
> > <https://reviews.apache.org/r/18065/diff/4/?file=506815#file506815line2>
> >
> >     This test passes with or without the rest of the patch. It doesn't seem to demonstrate any change in behavior.

Yes. This JIRA is to change the hive internal data movement for HQL 'LOAD LOCAL ...' -- no new feature is added.
I understood Ashutosh's concern to verify whether this new internal change would break the HQL like LOAD LOCAL from a *directory*. I didn't find any existing .q file that covered this test. Therefore added a new one to make sure existing behavior doesn't break.


- Mohammad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/#review35771
-----------------------------------------------------------


On Feb. 28, 2014, 8:03 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18065/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 8:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6024
>     https://issues.apache.org/jira/browse/HIVE-6024
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Excerpt from the JIRA:
> "Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
>   ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
>   ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18065/diff/
> 
> 
> Testing
> -------
> 
> Ran some existing q tests with "LOAD DATA LOCAL INPATH".
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Carl Steinbach <cw...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/#review35771
-----------------------------------------------------------



ql/src/test/queries/clientpositive/load_local_dir_test.q
<https://reviews.apache.org/r/18065/#comment66516>

    This test passes with or without the rest of the patch. It doesn't seem to demonstrate any change in behavior.


- Carl Steinbach


On Feb. 28, 2014, 8:03 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18065/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 8:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6024
>     https://issues.apache.org/jira/browse/HIVE-6024
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Excerpt from the JIRA:
> "Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
>   ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
>   ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18065/diff/
> 
> 
> Testing
> -------
> 
> Ran some existing q tests with "LOAD DATA LOCAL INPATH".
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 8:03 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Addressed review comment.
Add a new .q test to load local directory.


Bugs: HIVE-6024
    https://issues.apache.org/jira/browse/HIVE-6024


Repository: hive-git


Description
-------

Excerpt from the JIRA:
"Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
  ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
  ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/18065/diff/


Testing
-------

Ran some existing q tests with "LOAD DATA LOCAL INPATH".


Thanks,

Mohammad Islam


Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 8:20 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Rebased...


Bugs: HIVE-6024
    https://issues.apache.org/jira/browse/HIVE-6024


Repository: hive-git


Description
-------

Excerpt from the JIRA:
"Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though."


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 

Diff: https://reviews.apache.org/r/18065/diff/


Testing
-------

Ran some existing q tests with "LOAD DATA LOCAL INPATH".


Thanks,

Mohammad Islam