You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/05 06:34:21 UTC
[GitHub] [ozone] captainzmc commented on pull request #1746: HDDS-4631. Fix client set quota with 0.
captainzmc commented on pull request #1746:
URL: https://github.com/apache/ozone/pull/1746#issuecomment-754432275
Hi @linyiqun @ayushtkn Sorry for the late reply, we can continue to discuss this problem.
Maybe I didn't make it clear before, let's do an example：
ozone sh bucket create vol1 （This should be success）
ozone sh bucket create vol1 --space-quota 0TB --namespace-quota 0 （This should be unsuccessful）
These are two different cases. But in both cases in [CreateVolumeHandler quotaOptions.getQuotaInNamespace()](https://github.com/apache/ozone/blob/master/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/CreateVolumeHandler.java#L68) is 0.
Different cases receives the same parameters. Because the long variable is also 0 by default when it is not declared.
Let's look at another example，this also has the same problem：
ozone sh volume setquota vol1 --space-quota 10TB （This should be success）
ozone sh volume setquota vol1 --space-quota 10TB --namespace-quota 0 （This should be unsuccessful）
Because of this, I changed long to a string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org