[jira] [Issue Comment Edited] (CAMEL-4938) ManagedBrowsableEndpoint are broken

["Babak Vahdat (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196165#comment-13196165 ] 

Babak Vahdat edited comment on CAMEL-4938 at 1/30/12 3:17 PM:
--------------------------------------------------------------

Claus,

thanks beforehand for providing & applying the patch which indeed resolved the problem, however the solution is to my understanding is not *generic* as we've now introduced SEDA Endpoint specific logic into DefaultManagementObjectStrategy:

{code}
        } else if (endpoint instanceof SedaEndpoint) {
            ManagedSedaEndpoint me = new ManagedSedaEndpoint((SedaEndpoint) endpoint);
            me.init(context.getManagementStrategy());
            return me;
{code}

And have also introduced a ManagedSedaEndpoint which is again *Endpoint specific*, IMHO not nice!

Another note: by enableing JMX on

{code}
org.apache.camel.component.jms.BrowsableQueueTest
{code}

I see that the JMX operations are enlisted twice, causing (almost) the same behaviour (see the attached screenshot).

Shouldn't we remove the ManagedResource & ManagedOperation annotations on JmsQueueEndpoint as well? The same as you did for SedaEndpoint?
                
      was (Author: bvahdat):
    Claus,

thanks beforehand for providing & applying the patch which indeed resolved the problem, however the solution
is to my understanding is not *generic* as we've now introduced SEDA Endpoint specific logic into DefaultManagementObjectStrategy:

{code}
        } else if (endpoint instanceof SedaEndpoint) {
            ManagedSedaEndpoint me = new ManagedSedaEndpoint((SedaEndpoint) endpoint);
            me.init(context.getManagementStrategy());
            return me;
{code}

And have also introduced a ManagedSedaEndpoint which is again *Endpoint specific*, IMHO not nice!

Another note: by enableing JMX on

{code}
org.apache.camel.component.jms.BrowsableQueueTest
{code}

I see that the JMX operations are enlisted twice, causing (almost) the same behaviour (see the attached screenshot).

Shouldn't we remove the ManagedResource & ManagedOperation annotations on JmsQueueEndpoint as well? The same as you did for SedaEndpoint?
                  
> ManagedBrowsableEndpoint are broken
> -----------------------------------
>
>                 Key: CAMEL-4938
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4938
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core, jmx
>    Affects Versions: 2.9.0
>            Reporter: Vid Cheruvu
>            Assignee: Babak Vahdat
>             Fix For: 2.9.1, 2.10.0
>
>         Attachments: CAMEL-4938.patch, org.apache.camel.component.jms.BrowsableQueueTest.jpg
>
>
> ManagedeBrowsableEndpoint are broken which means any component that inherit ManagedBrowsableEndpoint have errors as well. Please see the link below which will have error screen shot of queueSize JMX operations.
> http://camel.465427.n5.nabble.com/JMX-queue-size-operation-fails-Camel-2-9-0-td5233089.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira