You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/29 21:18:48 UTC

Review Request 71180: Fixed column key name.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71180/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Bugs: MESOS-9907
    https://issues.apache.org/jira/browse/MESOS-9907


Repository: mesos


Description
-------

This column contained only information on draining while in review, but
was changed to now display a more general agent state. While doing that
we missed changing the used column key, and fix this with this follow-up
patch.


Diffs
-----

  src/webui/app/agents/agents.html 0c6d330e86d44fda311e68229f308309f8a8f98f 


Diff: https://reviews.apache.org/r/71180/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 71180: Fixed column key name.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71180/#review216949
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On July 29, 2019, 9:18 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71180/
> -----------------------------------------------------------
> 
> (Updated July 29, 2019, 9:18 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9907
>     https://issues.apache.org/jira/browse/MESOS-9907
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This column contained only information on draining while in review, but
> was changed to now display a more general agent state. While doing that
> we missed changing the used column key, and fix this with this follow-up
> patch.
> 
> 
> Diffs
> -----
> 
>   src/webui/app/agents/agents.html 0c6d330e86d44fda311e68229f308309f8a8f98f 
> 
> 
> Diff: https://reviews.apache.org/r/71180/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>